From: Mimi Zohar <zohar@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
Paul Moore <paul@paul-moore.com>
Cc: linux-integrity@vger.kernel.org, tusharsu@linux.microsoft.com,
linux-kernel@vger.kernel.org, linux-audit@redhat.com
Subject: Re: [PATCH] IMA: Add log statements for failure conditions
Date: Fri, 05 Jun 2020 17:34:27 -0400 [thread overview]
Message-ID: <1591392867.4615.20.camel@linux.ibm.com> (raw)
In-Reply-To: <48ff60f1-df93-5ce7-a254-8bfd1dba2ade@linux.microsoft.com>
On Fri, 2020-06-05 at 14:09 -0700, Lakshmi Ramasubramanian wrote:
> On 6/5/20 1:49 PM, Paul Moore wrote:
>
> >
> >> Since a pr_xyz() call was already present, I just wanted to change the
> >> log level to keep the code change to the minimum. But if audit log is
> >> the right approach for this case, I'll update.
> >
> > Generally we reserve audit for things that are required for various
> > security certifications and/or "security relevant". From what you
> > mentioned above, it seems like this would fall into the second
> > category if not the first.
> >
> > Looking at your patch it doesn't look like you are trying to record
> > anything special so you may be able to use the existing
> > integrity_audit_msg(...) helper. Of course then the question comes
> > down to the audit record type (the audit_msgno argument), the
> > operation (op), and the comm/cause (cause).
> >
> > Do you feel that any of the existing audit record types are a good fit for this?
> >
>
> Maybe I can use the audit_msgno "AUDIT_INTEGRITY_PCR" with appropriate
> strings for "op" and "cause".
>
> Mimi - please let me know if you think this audit_msgno would be ok to
> use. I see this code used, for instance, for boot aggregate measurement.
>
> integrity_audit_msg(AUDIT_INTEGRITY_PCR, NULL, boot_aggregate_name, op,
> audit_cause, result, 0);
Yes, AUDIT_INTEGRITY_PCR is also used for failures to add to the
measurement list.
thanks,
Mimi
next prev parent reply other threads:[~2020-06-05 21:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 16:32 [PATCH] IMA: Add log statements for failure conditions Lakshmi Ramasubramanian
2020-06-05 18:46 ` Mimi Zohar
2020-06-05 19:37 ` Paul Moore
2020-06-05 19:54 ` Lakshmi Ramasubramanian
2020-06-05 20:49 ` Paul Moore
2020-06-05 21:09 ` Lakshmi Ramasubramanian
2020-06-05 21:34 ` Mimi Zohar [this message]
2020-06-05 21:36 ` Lakshmi Ramasubramanian
-- strict thread matches above, loose matches on Subject: below --
2020-02-07 19:53 [PATCH] IMA: Updated KBUILD_MODNAME for IMA files to ima Tushar Sugandhi
2020-02-07 19:53 ` [PATCH] IMA: Add log statements for failure conditions Tushar Sugandhi
2020-02-09 12:57 ` Mimi Zohar
2020-02-10 2:46 ` Joe Perches
2020-02-10 16:40 ` Lakshmi Ramasubramanian
2020-02-10 16:50 ` Joe Perches
2020-02-10 21:42 ` Tushar Sugandhi
[not found] ` <0c9099b5-da29-3e71-0933-123dfe08442c@linux.microsoft.com>
2020-02-10 21:46 ` Mimi Zohar
2020-02-10 22:19 ` Tushar Sugandhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1591392867.4615.20.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=linux-audit@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nramas@linux.microsoft.com \
--cc=paul@paul-moore.com \
--cc=tusharsu@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).