* [PATCH v2] tpm_tis_spi_main: set cs_change = 0 when timesout
@ 2021-02-05 8:41 wanghongzhe
0 siblings, 0 replies; 2+ messages in thread
From: wanghongzhe @ 2021-02-05 8:41 UTC (permalink / raw)
To: peterhuewe, jarkko, jgg; +Cc: linux-integrity, linux-kernel
when i reach TPM_RETRY, the cs cannot change back to 'high'.
So the TPM chips thinks this communication is not over.
And next times communication cannot be effective because
the communications mixed up with the last time.
v1 -> v2:
- fix spi_xfer->cs_change error
Signed-off-by: wanghongzhe <wanghongzhe@huawei.com>
---
drivers/char/tpm/tpm_tis_spi_main.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/char/tpm/tpm_tis_spi_main.c b/drivers/char/tpm/tpm_tis_spi_main.c
index 3856f6ebcb34..6c52cbb28881 100644
--- a/drivers/char/tpm/tpm_tis_spi_main.c
+++ b/drivers/char/tpm/tpm_tis_spi_main.c
@@ -64,8 +64,18 @@ static int tpm_tis_spi_flow_control(struct tpm_tis_spi_phy *phy,
break;
}
- if (i == TPM_RETRY)
+ if (i == TPM_RETRY) {
+ /* change back to 'high',
+ * So the TPM chips thinks the last communication
+ * is done.
+ */
+ spi_xfer->cs_change = 0;
+ spi_xfer->len = 1;
+ spi_message_init(&m);
+ spi_message_add_tail(spi_xfer, &m);
+ ret = spi_sync_locked(phy->spi_device, &m);
return -ETIMEDOUT;
+ }
}
return 0;
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v2] tpm_tis_spi_main: set cs_change = 0 when timesout
2021-02-07 23:42 [PATCH v1] " Jarkko Sakkinen
@ 2021-02-08 2:43 ` wanghongzhe
0 siblings, 0 replies; 2+ messages in thread
From: wanghongzhe @ 2021-02-08 2:43 UTC (permalink / raw)
To: peterhuewe, jarkko, jgg; +Cc: linux-integrity, linux-kernel
The cs cannot change back to 'high' when the count is
TPM_RETRY. So the TPM chips thought this communication
is not over. And next times communication cannot be
effective because the communications mixed up with the
last time.
v1 -> v2:
- fix spi_xfer.cs_change to spi_xfer->cs_change
Signed-off-by: wanghongzhe <wanghongzhe@huawei.com>
---
drivers/char/tpm/tpm_tis_spi_main.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/char/tpm/tpm_tis_spi_main.c b/drivers/char/tpm/tpm_tis_spi_main.c
index 3856f6ebcb34..6c52cbb28881 100644
--- a/drivers/char/tpm/tpm_tis_spi_main.c
+++ b/drivers/char/tpm/tpm_tis_spi_main.c
@@ -64,8 +64,18 @@ static int tpm_tis_spi_flow_control(struct tpm_tis_spi_phy *phy,
break;
}
- if (i == TPM_RETRY)
+ if (i == TPM_RETRY) {
+ /* change back to 'high',
+ * So the TPM chips thinks the last communication
+ * is done.
+ */
+ spi_xfer->cs_change = 0;
+ spi_xfer->len = 1;
+ spi_message_init(&m);
+ spi_message_add_tail(spi_xfer, &m);
+ ret = spi_sync_locked(phy->spi_device, &m);
return -ETIMEDOUT;
+ }
}
return 0;
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-08 1:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-05 8:41 [PATCH v2] tpm_tis_spi_main: set cs_change = 0 when timesout wanghongzhe
2021-02-07 23:42 [PATCH v1] " Jarkko Sakkinen
2021-02-08 2:43 ` [PATCH v2] " wanghongzhe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).