From: Hao Wu <hao.wu@rubrik.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
Nayna Jain <nayna@linux.vnet.ibm.com>,
peterhuewe@gmx.de, jgg@ziepe.ca, arnd@arndb.de,
gregkh@linuxfoundation.org, Hamza Attak <hamza@hpe.com>,
why2jjj.linux@gmail.com, zohar@linux.vnet.ibm.com,
linux-integrity@vger.kernel.org,
Paul Menzel <pmenzel@molgen.mpg.de>,
Ken Goldman <kgold@linux.ibm.com>,
Seungyeop Han <seungyeop.han@rubrik.com>,
Shrihari Kalkar <shrihari.kalkar@rubrik.com>,
Anish Jhaveri <anish.jhaveri@rubrik.com>
Subject: Re: [PATCH] Fix Atmel TPM crash caused by too frequent queries
Date: Mon, 28 Sep 2020 13:27:14 -0700 [thread overview]
Message-ID: <18048BE4-2700-4BF9-8959-D024ECF0B704@rubrik.com> (raw)
In-Reply-To: <20200928194745.GB125819@linux.intel.com>
> On Sep 28, 2020, at 12:47 PM, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> wrote:
>
> On Mon, Sep 28, 2020 at 10:49:56AM -0700, Hao Wu wrote:
>> Hi Jarkko,
>>
>> https://github.com/torvalds/linux/commit/9f3fc7bcddcb51234e23494531f93ab60475e1c3
>> Is the one introducing the issue since 4.14. Then the other three commits
>> changed the relevant code a bit. Probably you can check the timestamp / release version
>> on each commit to understand the relationship.
>>
>> I think the original patch commit message can help you understand the root cause.
>> Attaching the commit here for your convenience.
>>
>> Thanks
>> Hao
>
> Please, again, when you respond quote properly instead of putting your
> response on top. Thank you.
>
> Yes, I know the issue and it is already documented also in the James'
> earlier patch that did a similar change. I.e. for some reason some TPM's
> (or the bus itself) do not like poking it too often.
Yes, probably. Although the issue James’s patch fixes has the same error code,
it is about a different issue which is similar.
> So: what if you revert on using msleep(TPM_TIMEOUT) in
> wait_for_tpm_stat(), i.e. revert to the behaviour before the
> aformentioned commit?
I believe that should resolve the issue as well
Thanks
Hao
next prev parent reply other threads:[~2020-09-28 20:27 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 22:31 [PATCH] Fix Atmel TPM crash caused by too frequent queries Hao Wu
2020-09-26 22:57 ` James Bottomley
2020-09-26 23:10 ` Hao Wu
2020-09-27 18:25 ` James Bottomley
2020-09-28 0:11 ` Hao Wu
2020-09-28 0:15 ` Hao Wu
2020-09-28 1:22 ` James Bottomley
2020-09-28 5:59 ` Hao Wu
2020-09-28 22:11 ` James Bottomley
2020-09-29 4:46 ` Hao Wu
2020-09-30 2:16 ` Jarkko Sakkinen
2020-09-30 14:54 ` James Bottomley
2020-09-30 15:37 ` Jarkko Sakkinen
2020-09-30 20:48 ` James Bottomley
2020-09-30 21:09 ` Jarkko Sakkinen
2020-09-30 22:31 ` James Bottomley
2020-10-01 1:50 ` Jarkko Sakkinen
2020-10-01 4:53 ` James Bottomley
2020-10-01 18:15 ` Nayna
2020-10-01 18:32 ` James Bottomley
2020-10-01 23:04 ` Jarkko Sakkinen
2020-10-17 6:11 ` Hao Wu
2020-10-18 5:09 ` Jarkko Sakkinen
2020-10-18 5:20 ` Hao Wu
2020-11-14 4:39 ` Hao Wu
2020-11-18 21:11 ` Jarkko Sakkinen
2020-11-18 23:23 ` Hao Wu
2021-05-09 6:18 ` Hao Wu
2021-05-09 6:31 ` Hao Wu
2021-05-10 2:17 ` Mimi Zohar
2021-05-10 3:15 ` Hao Wu
2021-05-10 17:28 ` Jarkko Sakkinen
2020-09-28 1:08 ` Jarkko Sakkinen
2020-09-28 6:03 ` Hao Wu
2020-09-28 14:16 ` Jarkko Sakkinen
2020-09-28 17:49 ` Hao Wu
2020-09-28 19:47 ` Jarkko Sakkinen
2020-09-28 20:27 ` Hao Wu [this message]
2020-09-30 2:11 ` Jarkko Sakkinen
2020-09-30 3:41 ` Hao Wu
[not found] ` <EA1EE8F8-F054-4E1B-B830-231398D33CB8@rubrik.com>
2020-10-01 14:16 ` Mimi Zohar
-- strict thread matches above, loose matches on Subject: below --
2021-06-20 23:18 Hao Wu
2021-06-23 13:35 ` Jarkko Sakkinen
2021-06-24 5:49 ` Hao Wu
2021-06-29 20:06 ` Jarkko Sakkinen
2021-06-30 4:27 ` Hao Wu
2021-06-24 5:33 ` Hao Wu
2021-06-29 20:07 ` Jarkko Sakkinen
2020-09-14 6:13 Hao Wu
2020-09-14 6:17 ` Greg KH
2020-09-15 2:52 ` Hao Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18048BE4-2700-4BF9-8959-D024ECF0B704@rubrik.com \
--to=hao.wu@rubrik.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=anish.jhaveri@rubrik.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hamza@hpe.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=kgold@linux.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=nayna@linux.vnet.ibm.com \
--cc=peterhuewe@gmx.de \
--cc=pmenzel@molgen.mpg.de \
--cc=seungyeop.han@rubrik.com \
--cc=shrihari.kalkar@rubrik.com \
--cc=why2jjj.linux@gmail.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).