From: Mimi Zohar <zohar@linux.ibm.com>
To: Petr Vorel <pvorel@suse.cz>,
Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc: Vitaly Chikunov <vt@altlinux.org>,
Stefan Berger <stefanb@linux.ibm.com>,
linux-integrity@vger.kernel.org,
Jia Zhang <zhang.jia@linux.alibaba.com>,
"YiLin . Li" <YiLin.Li@linux.alibaba.com>
Subject: Re: [PATCH ima-evm-utils v5] ima-evm-utils: Support SM2/3 algorithm for sign and verify
Date: Mon, 19 Jul 2021 08:51:08 -0400 [thread overview]
Message-ID: <1aa1a53101d9eeb6c358bb65677a8b733c19e663.camel@linux.ibm.com> (raw)
In-Reply-To: <YPQqhTPLTafjLCXP@pevik>
Hi -
On Sun, 2021-07-18 at 15:20 +0200, Petr Vorel wrote:
> > On 7/17/21 12:39 AM, Mimi Zohar wrote:
> > > On Fri, 2021-07-16 at 17:22 +0800, Tianjia Zhang wrote:
> > > > diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
> > > > index 088c041..17407ff 100644
> > > > --- a/.github/workflows/ci.yml
> > > > +++ b/.github/workflows/ci.yml
> > > > @@ -17,6 +17,7 @@ jobs:
> > > > ARCH: i386
> > > > TSS: tpm2-tss
> > > > VARIANT: i386
> > > > + OPENSSL3: true
> > > > # cross compilation builds
> > > > - container: "debian:stable"
> > > > @@ -51,6 +52,7 @@ jobs:
> > > > env:
> > > > CC: clang
> > > > TSS: ibmtss
> > > > + OPENSSL3: true
>
> > > I haven't had a chance to look at the entire patch, but defining
> > > OPENSSL3 kind of stood out. Just as "CC" and "TSS" are generic, I'd
> > > prefer something more generic here. In the past there was a request
> > > to support Libressl, which never materialized.
>
>
> > I agree that it is appropriate to use a generic variable name. I am thinking
> > of 'CRYPTOGRAPHY' or 'CRYPPTO_LIBRARY'. Are there any better suggestions?
> How about COMPILE_OPENSSL? Because that's the current purpose.
Hm, wondering if it makes sense to generalize this further, including
Vitaly's suggestion?
In this case, the generic name would be "SSL" (e.g. "SSL=openssl").
Prefixing a generic name with "COMPILE_[TSS|CC|SSL]=<tag|commit>" would
indicate compiling the application from source.
thanks,
Mimi
next prev parent reply other threads:[~2021-07-19 12:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 9:22 [PATCH ima-evm-utils v5] ima-evm-utils: Support SM2/3 algorithm for sign and verify Tianjia Zhang
2021-07-16 16:39 ` Mimi Zohar
2021-07-17 1:48 ` Tianjia Zhang
2021-07-17 14:22 ` Vitaly Chikunov
2021-07-18 2:22 ` Tianjia Zhang
2021-07-18 13:20 ` Petr Vorel
2021-07-19 12:51 ` Mimi Zohar [this message]
2021-07-20 7:06 ` Tianjia Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1aa1a53101d9eeb6c358bb65677a8b733c19e663.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=YiLin.Li@linux.alibaba.com \
--cc=linux-integrity@vger.kernel.org \
--cc=pvorel@suse.cz \
--cc=stefanb@linux.ibm.com \
--cc=tianjia.zhang@linux.alibaba.com \
--cc=vt@altlinux.org \
--cc=zhang.jia@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).