linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>,
	Petr Vorel <pvorel@suse.cz>, Vitaly Chikunov <vt@altlinux.org>,
	Stefan Berger <stefanb@linux.ibm.com>,
	linux-integrity@vger.kernel.org,
	Jia Zhang <zhang.jia@linux.alibaba.com>,
	"YiLin . Li" <YiLin.Li@linux.alibaba.com>
Subject: Re: [PATCH ima-evm-utils v5] ima-evm-utils: Support SM2/3 algorithm for sign and verify
Date: Fri, 16 Jul 2021 12:39:45 -0400	[thread overview]
Message-ID: <f7c05b2618125cb0887ee0302c1197a8c8f49864.camel@linux.ibm.com> (raw)
In-Reply-To: <20210716092237.17153-1-tianjia.zhang@linux.alibaba.com>

Hi Tianjia,

On Fri, 2021-07-16 at 17:22 +0800, Tianjia Zhang wrote:
> diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
> index 088c041..17407ff 100644
> --- a/.github/workflows/ci.yml
> +++ b/.github/workflows/ci.yml
> @@ -17,6 +17,7 @@ jobs:
>                ARCH: i386
>                TSS: tpm2-tss
>                VARIANT: i386
> +              OPENSSL3: true
>  
>            # cross compilation builds
>            - container: "debian:stable"
> @@ -51,6 +52,7 @@ jobs:
>              env:
>                CC: clang
>                TSS: ibmtss
> +              OPENSSL3: true

I haven't had a chance to look at the entire patch, but defining
OPENSSL3 kind of stood out.  Just as "CC" and "TSS" are generic, I'd
prefer something more generic here.   In the past there was a request
to support Libressl, which never materialized.

thanks,

Mimi


  reply	other threads:[~2021-07-16 16:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-16  9:22 [PATCH ima-evm-utils v5] ima-evm-utils: Support SM2/3 algorithm for sign and verify Tianjia Zhang
2021-07-16 16:39 ` Mimi Zohar [this message]
2021-07-17  1:48   ` Tianjia Zhang
2021-07-17 14:22     ` Vitaly Chikunov
2021-07-18  2:22       ` Tianjia Zhang
2021-07-18 13:20     ` Petr Vorel
2021-07-19 12:51       ` Mimi Zohar
2021-07-20  7:06         ` Tianjia Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7c05b2618125cb0887ee0302c1197a8c8f49864.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=YiLin.Li@linux.alibaba.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=pvorel@suse.cz \
    --cc=stefanb@linux.ibm.com \
    --cc=tianjia.zhang@linux.alibaba.com \
    --cc=vt@altlinux.org \
    --cc=zhang.jia@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).