From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
stable <stable@vger.kernel.org>, James Morris <jmorris@namei.org>,
Tomas Winkler <tomas.winkler@intel.com>,
Jerry Snitselaar <jsnitsel@redhat.com>
Subject: Re: [PATCH] tpm/tpm_crb: Avoid unaligned reads in crb_recv():
Date: Mon, 4 Feb 2019 13:47:24 +0200 [thread overview]
Message-ID: <20190204114724.GB26799@linux.intel.com> (raw)
In-Reply-To: <CAHk-=whOU=Ek3C6=r2xkTtdv==He=KxUjz_8x2Jo3nJJiDW3VQ@mail.gmail.com>
On Fri, Feb 01, 2019 at 09:49:05AM -0800, Linus Torvalds wrote:
> On Fri, Feb 1, 2019 at 3:33 AM Jarkko Sakkinen
> <jarkko.sakkinen@linux.intel.com> wrote:
> >
> > Thus, it makes sense to fix this also in tpm_crb, not least because
> > the fix can be then backported to stable kernels and make them more robust
> > when compiled in differing environments.
>
> Ack, looks sane to me, and should help both the backport and probably
> generate better code too.
>
> In the meantime, I've committed the iomem.c change with a *long*
> commit message. For all we know, there might be other cases like this
> lurking somewhere else that just happened to work. Plus it's the right
> thing to do anyway.
>
> Linus
Great!
Umh, so, should my tpm_crb change committed to 5.0 with the minor changes
implemented suggested by Tomas or not? Can also include it to my 5.1 PR.
Either WFM.
/Jarkko
next prev parent reply other threads:[~2019-02-04 11:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 11:19 [PATCH] tpm/tpm_crb: Avoid unaligned reads in crb_recv(): Jarkko Sakkinen
2019-02-01 17:49 ` Linus Torvalds
2019-02-04 11:47 ` Jarkko Sakkinen [this message]
2019-02-01 18:42 ` Jerry Snitselaar
2019-02-01 19:20 ` Winkler, Tomas
2019-02-04 11:44 ` Jarkko Sakkinen
2019-02-04 12:17 ` David Laight
2019-02-05 10:44 ` Jarkko Sakkinen
2019-02-05 10:47 ` Jarkko Sakkinen
2019-02-05 10:49 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204114724.GB26799@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jmorris@namei.org \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tomas.winkler@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).