From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
James Morris <jmorris@namei.org>,
Tomas Winkler <tomas.winkler@intel.com>,
Jerry Snitselaar <jsnitsel@redhat.com>
Subject: Re: [PATCH] tpm/tpm_crb: Avoid unaligned reads in crb_recv():
Date: Tue, 5 Feb 2019 12:44:06 +0200 [thread overview]
Message-ID: <20190205104406.GA1823@linux.intel.com> (raw)
In-Reply-To: <0446c899270a4b128a6d05e62d63e704@AcuMS.aculab.com>
On Mon, Feb 04, 2019 at 12:17:43PM +0000, David Laight wrote:
> From: Jarkko Sakkinen
> > Sent: 01 February 2019 11:20
> > The current approach to read first 6 bytes from the response and then tail
> > of the response, can cause the 2nd memcpy_fromio() to do an unaligned read
> > (e.g. read 32-bit word from address aligned to a 16-bits), depending on how
> > memcpy_fromio() is implemented. If this happens, the read will fail and the
> > memory controller will fill the read with 1's.
>
> To my mind memcpy_to/fromio() should only be used on IO addresses that are
> adequately like memory, and should be implemented in a way that that won't
> generate invalid bus cycles.
> Also memcpy_fromio() should also be allowed to do 'aligned' accesses that
> go beyond the ends of the required memory area.
>
> ...
> >
> > - memcpy_fromio(buf, priv->rsp, 6);
> > + memcpy_fromio(buf, priv->rsp, 8);
> > expected = be32_to_cpup((__be32 *) &buf[2]);
> > - if (expected > count || expected < 6)
> > + if (expected > count || expected < 8)
> > return -EIO;
> >
> > - memcpy_fromio(&buf[6], &priv->rsp[6], expected - 6);
> > + memcpy_fromio(&buf[8], &priv->rsp[8], expected - 8);
>
> Why not just use readl() or readq() ?
>
> Bound to generate better code.
For the first read can be done. The second read is of variable
length.
/Jarkko
next prev parent reply other threads:[~2019-02-05 10:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 11:19 [PATCH] tpm/tpm_crb: Avoid unaligned reads in crb_recv(): Jarkko Sakkinen
2019-02-01 17:49 ` Linus Torvalds
2019-02-04 11:47 ` Jarkko Sakkinen
2019-02-01 18:42 ` Jerry Snitselaar
2019-02-01 19:20 ` Winkler, Tomas
2019-02-04 11:44 ` Jarkko Sakkinen
2019-02-04 12:17 ` David Laight
2019-02-05 10:44 ` Jarkko Sakkinen [this message]
2019-02-05 10:47 ` Jarkko Sakkinen
2019-02-05 10:49 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205104406.GA1823@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=David.Laight@ACULAB.COM \
--cc=jmorris@namei.org \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tomas.winkler@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).