* [PATCH v3 -next] tpm: Fix the type of the return value in calc_tpm2_event_size()
@ 2019-02-20 8:25 Yue Haibing
2019-02-20 8:52 ` Jarkko Sakkinen
0 siblings, 1 reply; 2+ messages in thread
From: Yue Haibing @ 2019-02-20 8:25 UTC (permalink / raw)
To: peterhuewe, jarkko.sakkinen, jgg, arnd, gregkh
Cc: linux-kernel, linux-integrity, linux-security-module,
Yue Haibing, stable
calc_tpm2_event_size() has an invalid signature because
it returns a 'size_t' where as its signature says that
it returns 'int'.
Cc: <stable@vger.kernel.org>
Fixes: 4d23cc323cdb ("tpm: add securityfs support for TPM 2.0 firmware event log")
Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
v3: fix My real name and cc stable
v2: modify patch title and commit message as Jarkko suggested
---
drivers/char/tpm/eventlog/tpm2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/eventlog/tpm2.c b/drivers/char/tpm/eventlog/tpm2.c
index d8b7713..f824563 100644
--- a/drivers/char/tpm/eventlog/tpm2.c
+++ b/drivers/char/tpm/eventlog/tpm2.c
@@ -37,8 +37,8 @@
*
* Returns size of the event. If it is an invalid event, returns 0.
*/
-static int calc_tpm2_event_size(struct tcg_pcr_event2_head *event,
- struct tcg_pcr_event *event_header)
+static size_t calc_tpm2_event_size(struct tcg_pcr_event2_head *event,
+ struct tcg_pcr_event *event_header)
{
struct tcg_efi_specid_event_head *efispecid;
struct tcg_event_field *event_field;
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3 -next] tpm: Fix the type of the return value in calc_tpm2_event_size()
2019-02-20 8:25 [PATCH v3 -next] tpm: Fix the type of the return value in calc_tpm2_event_size() Yue Haibing
@ 2019-02-20 8:52 ` Jarkko Sakkinen
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Sakkinen @ 2019-02-20 8:52 UTC (permalink / raw)
To: Yue Haibing
Cc: peterhuewe, jgg, arnd, gregkh, linux-kernel, linux-integrity,
linux-security-module, stable
On Wed, Feb 20, 2019 at 04:25:38PM +0800, Yue Haibing wrote:
> calc_tpm2_event_size() has an invalid signature because
> it returns a 'size_t' where as its signature says that
> it returns 'int'.
>
> Cc: <stable@vger.kernel.org>
> Fixes: 4d23cc323cdb ("tpm: add securityfs support for TPM 2.0 firmware event log")
> Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> v3: fix My real name and cc stable
> v2: modify patch title and commit message as Jarkko suggested
Thanks,
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-20 8:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-20 8:25 [PATCH v3 -next] tpm: Fix the type of the return value in calc_tpm2_event_size() Yue Haibing
2019-02-20 8:52 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).