linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vitaly Chikunov <vt@altlinux.org>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: Petr Vorel <pvorel@suse.cz>,
	"BrunoE.O.Meneguele" <bmeneg@redhat.com>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	linux-integrity <linux-integrity@vger.kernel.org>
Subject: Re: ima-evm-utils:  library version
Date: Wed, 24 Jul 2019 20:28:01 +0300	[thread overview]
Message-ID: <20190724172801.y64bs2byyuqfsezf@altlinux.org> (raw)
In-Reply-To: <1563972698.4245.21.camel@linux.ibm.com>

Mimi,

On Wed, Jul 24, 2019 at 08:51:38AM -0400, Mimi Zohar wrote:
> 
> In preparing the ima-evm-utils v1.2 release, I noticed that the
> library version was never updated.  It is still "0.0.0".  Should I set
> it to something?  If so, what versioning scheme do you recommend -
> using the libtool current[:revision[:age]], prepending the release
> version on the .so, or suffixing the release version on the .so?

libtool rules should be followed:

  https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html

I think you should change 0.0.0 to 1.0.0 just before release. Since we are
changed ABI of calc_keyid_v2 (RSA *key -> EVP_PKEY *pkey). (There is also
changes to read_pub_pkey and get_filesize.)

> The other option is to leave the version as 0.0.0 and let the distro
> package maintainers deal with it.

I think you should update it properly.

> Posting a patch that sets the library version would be most welcome.

diff --git a/src/Makefile.am b/src/Makefile.am
index 9c037e2..b794c50 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -4,7 +4,7 @@ libimaevm_la_SOURCES = libimaevm.c
 libimaevm_la_CPPFLAGS = $(AM_CPPFLAGS) $(LIBCRYPTO_CFLAGS)
 # current[:revision[:age]]
 # result: [current-age].age.revision
-libimaevm_la_LDFLAGS = -version-info 0:0:0
+libimaevm_la_LDFLAGS = -version-info 1:0:0
 libimaevm_la_LIBADD =  $(LIBCRYPTO_LIBS)

Thanks,

  reply	other threads:[~2019-07-24 17:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-24 12:51 ima-evm-utils: library version Mimi Zohar
2019-07-24 17:28 ` Vitaly Chikunov [this message]
2019-07-24 18:04   ` Bruno E. O. Meneguele
2019-07-25  0:36     ` Mimi Zohar
2019-07-24 19:17   ` Vitaly Chikunov
2019-07-24 22:27     ` Mimi Zohar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190724172801.y64bs2byyuqfsezf@altlinux.org \
    --to=vt@altlinux.org \
    --cc=bmeneg@redhat.com \
    --cc=dbaryshkov@gmail.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=pvorel@suse.cz \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).