linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tpm/tpm_ftpm_tee: trivial checkpatch fixes
@ 2019-08-13 13:05 Sasha Levin
  2019-08-13 13:37 ` Rob Herring
  2019-08-15 21:02 ` Jarkko Sakkinen
  0 siblings, 2 replies; 5+ messages in thread
From: Sasha Levin @ 2019-08-13 13:05 UTC (permalink / raw)
  To: jarkko.sakkinen, peterhuewe
  Cc: mark.rutland, robh+dt, jgg, linux-kernel, devicetree,
	linux-integrity, Sasha Levin

Fixes a few checkpatch warnings (and ignores some), mostly around
spaces/tabs and documentation.

Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml |  2 ++
 drivers/char/tpm/Kconfig                               |  2 +-
 drivers/char/tpm/tpm_ftpm_tee.c                        | 10 +++++-----
 3 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 6992bbbbffab6..d61a203138cbe 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -575,6 +575,8 @@ patternProperties:
     description: Micro Crystal AG
   "^micron,.*":
     description: Micron Technology Inc.
+  "^microsoft,.*":
+    description: Microsoft Corporation
   "^mikroe,.*":
     description: MikroElektronika d.o.o.
   "^miniand,.*":
diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index 17bfbf9f572fc..9c37047f4b562 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -167,7 +167,7 @@ config TCG_VTPM_PROXY
 config TCG_FTPM_TEE
 	tristate "TEE based fTPM Interface"
 	depends on TEE && OPTEE
-	---help---
+	help
 	  This driver proxies for firmware TPM running in TEE.
 
 source "drivers/char/tpm/st33zp24/Kconfig"
diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_tee.c
index 5679a5af9a96a..6640a14dbe48c 100644
--- a/drivers/char/tpm/tpm_ftpm_tee.c
+++ b/drivers/char/tpm/tpm_ftpm_tee.c
@@ -38,7 +38,7 @@ static const uuid_t ftpm_ta_uuid =
  * @count:	the number of bytes to read.
  *
  * Return:
- * 	In case of success the number of bytes received.
+ *	In case of success the number of bytes received.
  *	On failure, -errno.
  */
 static int ftpm_tee_tpm_op_recv(struct tpm_chip *chip, u8 *buf, size_t count)
@@ -67,7 +67,7 @@ static int ftpm_tee_tpm_op_recv(struct tpm_chip *chip, u8 *buf, size_t count)
  * @len:	the number of bytes to send.
  *
  * Return:
- * 	In case of success, returns 0.
+ *	In case of success, returns 0.
  *	On failure, -errno
  */
 static int ftpm_tee_tpm_op_send(struct tpm_chip *chip, u8 *buf, size_t len)
@@ -212,7 +212,7 @@ static int ftpm_tee_match(struct tee_ioctl_version_data *ver, const void *data)
  * @pdev: the platform_device description.
  *
  * Return:
- * 	On success, 0. On failure, -errno.
+ *	On success, 0. On failure, -errno.
  */
 static int ftpm_tee_probe(struct platform_device *pdev)
 {
@@ -302,7 +302,7 @@ static int ftpm_tee_probe(struct platform_device *pdev)
  * @pdev: the platform_device description.
  *
  * Return:
- * 	0 always.
+ *	0 always.
  */
 static int ftpm_tee_remove(struct platform_device *pdev)
 {
@@ -323,7 +323,7 @@ static int ftpm_tee_remove(struct platform_device *pdev)
 	/* close the context with TEE driver */
 	tee_client_close_context(pvt_data->ctx);
 
-        /* memory allocated with devm_kzalloc() is freed automatically */
+	/* memory allocated with devm_kzalloc() is freed automatically */
 
 	return 0;
 }
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] tpm/tpm_ftpm_tee: trivial checkpatch fixes
  2019-08-13 13:05 [PATCH] tpm/tpm_ftpm_tee: trivial checkpatch fixes Sasha Levin
@ 2019-08-13 13:37 ` Rob Herring
  2019-08-19 13:32   ` Jarkko Sakkinen
  2019-08-15 21:02 ` Jarkko Sakkinen
  1 sibling, 1 reply; 5+ messages in thread
From: Rob Herring @ 2019-08-13 13:37 UTC (permalink / raw)
  To: Sasha Levin
  Cc: Jarkko Sakkinen, Peter Huewe, Mark Rutland, Jason Gunthorpe,
	linux-kernel, devicetree, linux-integrity

On Tue, Aug 13, 2019 at 7:06 AM Sasha Levin <sashal@kernel.org> wrote:
>
> Fixes a few checkpatch warnings (and ignores some), mostly around
> spaces/tabs and documentation.
>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
>  Documentation/devicetree/bindings/vendor-prefixes.yaml |  2 ++

Acked-by: Rob Herring <robh@kernel.org>

>  drivers/char/tpm/tpm_ftpm_tee.c                        | 10 +++++-----
>  3 files changed, 8 insertions(+), 6 deletions(-)

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] tpm/tpm_ftpm_tee: trivial checkpatch fixes
  2019-08-13 13:05 [PATCH] tpm/tpm_ftpm_tee: trivial checkpatch fixes Sasha Levin
  2019-08-13 13:37 ` Rob Herring
@ 2019-08-15 21:02 ` Jarkko Sakkinen
  2019-08-19 16:44   ` Jarkko Sakkinen
  1 sibling, 1 reply; 5+ messages in thread
From: Jarkko Sakkinen @ 2019-08-15 21:02 UTC (permalink / raw)
  To: Sasha Levin
  Cc: peterhuewe, mark.rutland, robh+dt, jgg, linux-kernel, devicetree,
	linux-integrity

On Tue, Aug 13, 2019 at 09:05:59AM -0400, Sasha Levin wrote:
> Fixes a few checkpatch warnings (and ignores some), mostly around
> spaces/tabs and documentation.
> 
> Signed-off-by: Sasha Levin <sashal@kernel.org>

Thank you!

I'll squash these to the existing patches.

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

/Jarkko

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] tpm/tpm_ftpm_tee: trivial checkpatch fixes
  2019-08-13 13:37 ` Rob Herring
@ 2019-08-19 13:32   ` Jarkko Sakkinen
  0 siblings, 0 replies; 5+ messages in thread
From: Jarkko Sakkinen @ 2019-08-19 13:32 UTC (permalink / raw)
  To: Rob Herring
  Cc: Sasha Levin, Peter Huewe, Mark Rutland, Jason Gunthorpe,
	linux-kernel, devicetree, linux-integrity

On Tue, Aug 13, 2019 at 07:37:32AM -0600, Rob Herring wrote:
> On Tue, Aug 13, 2019 at 7:06 AM Sasha Levin <sashal@kernel.org> wrote:
> >
> > Fixes a few checkpatch warnings (and ignores some), mostly around
> > spaces/tabs and documentation.
> >
> > Signed-off-by: Sasha Levin <sashal@kernel.org>
> > ---
> >  Documentation/devicetree/bindings/vendor-prefixes.yaml |  2 ++
> 
> Acked-by: Rob Herring <robh@kernel.org>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

/Jarkko

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] tpm/tpm_ftpm_tee: trivial checkpatch fixes
  2019-08-15 21:02 ` Jarkko Sakkinen
@ 2019-08-19 16:44   ` Jarkko Sakkinen
  0 siblings, 0 replies; 5+ messages in thread
From: Jarkko Sakkinen @ 2019-08-19 16:44 UTC (permalink / raw)
  To: Sasha Levin
  Cc: peterhuewe, mark.rutland, robh+dt, jgg, linux-kernel, devicetree,
	linux-integrity

On Fri, Aug 16, 2019 at 12:02:01AM +0300, Jarkko Sakkinen wrote:
> On Tue, Aug 13, 2019 at 09:05:59AM -0400, Sasha Levin wrote:
> > Fixes a few checkpatch warnings (and ignores some), mostly around
> > spaces/tabs and documentation.
> > 
> > Signed-off-by: Sasha Levin <sashal@kernel.org>
> 
> Thank you!
> 
> I'll squash these to the existing patches.
> 
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

Oops, replied this twice, sorry :-)

Anyway, I pushed the patch. I think I just keep it as separate
after all.

/Jarkko

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-08-19 17:00 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-13 13:05 [PATCH] tpm/tpm_ftpm_tee: trivial checkpatch fixes Sasha Levin
2019-08-13 13:37 ` Rob Herring
2019-08-19 13:32   ` Jarkko Sakkinen
2019-08-15 21:02 ` Jarkko Sakkinen
2019-08-19 16:44   ` Jarkko Sakkinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).