Linux-Integrity Archive on lore.kernel.org
 help / color / Atom feed
* [RESEND][PATCH v2-resend] MAINTAINERS: fix style in KEYS-TRUSTED entry
@ 2019-08-25 17:00 Lukas Bulwahn
  2019-08-26  5:40 ` Jarkko Sakkinen
  0 siblings, 1 reply; 3+ messages in thread
From: Lukas Bulwahn @ 2019-08-25 17:00 UTC (permalink / raw)
  To: James Bottomley, Jarkko Sakkinen, Mimi Zohar
  Cc: linux-integrity, keyrings, linux-kernel, Lukas Bulwahn

Mimi Zohar used spaces instead of a tab when adding Jarkko Sakkinen as
further maintainer to the KEYS-TRUSTED section entry.

In fact, ./scripts/checkpatch.pl -f MAINTAINERS complains:

  WARNING: MAINTAINERS entries use one tab after TYPE:
  #8581: FILE: MAINTAINERS:8581:
  +M:      Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

The issue was detected when writing a script that parses MAINTAINERS.

Fixes: 34bccd61b139 ("MAINTAINERS: add Jarkko as maintainer for trusted keys")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
v1: https://lore.kernel.org/patchwork/patch/1040412/
  - Joe Perches clarified that this is a style defect.

v2: applies cleanly to v5.1-rc4 and next-20190412

v2-resend: applies cleanly to v5.3-rc5 and next-20190823

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 43604d6ab96c..6cb9a4927da8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8937,7 +8937,7 @@ F:	security/keys/encrypted-keys/
 
 KEYS-TRUSTED
 M:	James Bottomley <jejb@linux.ibm.com>
-M:      Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
+M:	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
 M:	Mimi Zohar <zohar@linux.ibm.com>
 L:	linux-integrity@vger.kernel.org
 L:	keyrings@vger.kernel.org
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RESEND][PATCH v2-resend] MAINTAINERS: fix style in KEYS-TRUSTED entry
  2019-08-25 17:00 [RESEND][PATCH v2-resend] MAINTAINERS: fix style in KEYS-TRUSTED entry Lukas Bulwahn
@ 2019-08-26  5:40 ` Jarkko Sakkinen
  2019-09-02 14:08   ` Jarkko Sakkinen
  0 siblings, 1 reply; 3+ messages in thread
From: Jarkko Sakkinen @ 2019-08-26  5:40 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: James Bottomley, Mimi Zohar, linux-integrity, keyrings, linux-kernel

On Sun, Aug 25, 2019 at 07:00:15PM +0200, Lukas Bulwahn wrote:
> Mimi Zohar used spaces instead of a tab when adding Jarkko Sakkinen as
> further maintainer to the KEYS-TRUSTED section entry.
> 
> In fact, ./scripts/checkpatch.pl -f MAINTAINERS complains:
> 
>   WARNING: MAINTAINERS entries use one tab after TYPE:
>   #8581: FILE: MAINTAINERS:8581:
>   +M:      Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> 
> The issue was detected when writing a script that parses MAINTAINERS.
> 
> Fixes: 34bccd61b139 ("MAINTAINERS: add Jarkko as maintainer for trusted keys")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Acked-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

/Jarkko

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RESEND][PATCH v2-resend] MAINTAINERS: fix style in KEYS-TRUSTED entry
  2019-08-26  5:40 ` Jarkko Sakkinen
@ 2019-09-02 14:08   ` Jarkko Sakkinen
  0 siblings, 0 replies; 3+ messages in thread
From: Jarkko Sakkinen @ 2019-09-02 14:08 UTC (permalink / raw)
  To: Lukas Bulwahn
  Cc: James Bottomley, Mimi Zohar, linux-integrity, keyrings, linux-kernel

On Mon, Aug 26, 2019 at 08:40:24AM +0300, Jarkko Sakkinen wrote:
> On Sun, Aug 25, 2019 at 07:00:15PM +0200, Lukas Bulwahn wrote:
> > Mimi Zohar used spaces instead of a tab when adding Jarkko Sakkinen as
> > further maintainer to the KEYS-TRUSTED section entry.
> > 
> > In fact, ./scripts/checkpatch.pl -f MAINTAINERS complains:
> > 
> >   WARNING: MAINTAINERS entries use one tab after TYPE:
> >   #8581: FILE: MAINTAINERS:8581:
> >   +M:      Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > 
> > The issue was detected when writing a script that parses MAINTAINERS.
> > 
> > Fixes: 34bccd61b139 ("MAINTAINERS: add Jarkko as maintainer for trusted keys")
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> 
> Acked-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

Including to my v5.4 PR.

/Jarkko

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-25 17:00 [RESEND][PATCH v2-resend] MAINTAINERS: fix style in KEYS-TRUSTED entry Lukas Bulwahn
2019-08-26  5:40 ` Jarkko Sakkinen
2019-09-02 14:08   ` Jarkko Sakkinen

Linux-Integrity Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-integrity/0 linux-integrity/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-integrity linux-integrity/ https://lore.kernel.org/linux-integrity \
		linux-integrity@vger.kernel.org linux-integrity@archiver.kernel.org
	public-inbox-index linux-integrity


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-integrity


AGPL code for this site: git clone https://public-inbox.org/ public-inbox