linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vitaly Chikunov <vt@altlinux.org>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: linux-integrity <linux-integrity@vger.kernel.org>,
	Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
Subject: Re: [PATCH v7] ima-evm-utils: Add some tests for evmctl
Date: Mon, 23 Mar 2020 19:17:24 +0300	[thread overview]
Message-ID: <20200323161724.uljnhparsske5ijm@altlinux.org> (raw)
In-Reply-To: <1584973422.5188.247.camel@linux.ibm.com>

Mimi,

On Mon, Mar 23, 2020 at 10:23:42AM -0400, Mimi Zohar wrote:
> 
> I really appreciate your creating this set of tests!  However, when
> you first posted this patch, I asked you to break it up into more
> manageable pieces to review.  I understand this isn't the Linux
> kernel, "just" some tests, but there is good reason that the Linux
> kernel development requires large patches be broken up into more
> manageable small, logical changes.
> 
> I've recently asked a few people to help review this patch.  I
> understand that it is a lot of work to break this patch up into
> smaller patches, but it will simplify review.
> 
> If I was to break up this patch, I would start by making the test
> driver and each of the tests a separate patch.  The test driver patch
> description should reference the GNU documentation, with an
> explanation as to why a custom driver is preferred[1].

I don't use custom driver. Default simple driver is used, I think it's
called "Parallel Test Harness".

There is only two tests - ima_hash and sign_verify. ima_hash tests
ima_hash evmctl command making ima hashes and verifying them;
sign_verify tests {ima_,}{sign,verify} commands making signatures and
verifying them. (They are tested together, because they are related
(verify need sign first, evm sign can produce ima signature too) and
can verify each other).

Thanks,


  reply	other threads:[~2020-03-23 16:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-23 14:23 [PATCH v7] ima-evm-utils: Add some tests for evmctl Mimi Zohar
2020-03-23 16:17 ` Vitaly Chikunov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-08-17 23:33 Vitaly Chikunov
2020-03-19 15:18 ` Lakshmi Ramasubramanian
2020-03-19 15:49   ` Vitaly Chikunov
2020-03-19 16:36     ` Lakshmi Ramasubramanian
2020-03-19 21:57       ` Lakshmi Ramasubramanian
2020-03-22 22:10         ` Vitaly Chikunov
2020-03-23 15:48           ` Lakshmi Ramasubramanian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200323161724.uljnhparsske5ijm@altlinux.org \
    --to=vt@altlinux.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=nramas@linux.microsoft.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).