Re: [PATCHv8 0/3] optee: register drivers on optee bus

From: Jens Wiklander <jens.wiklander@linaro.org>
To: Maxim Uvarov <maxim.uvarov@linaro.org>,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"tee-dev @ lists . linaro . org" <tee-dev@lists.linaro.org>,
	peterhuewe@gmx.de, Jason Gunthorpe <jgg@ziepe.ca>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-integrity@vger.kernel.org, Arnd Bergmann <arnd@linaro.org>,
	Sumit Garg <sumit.garg@linaro.org>
Subject: Re: [PATCHv8 0/3] optee: register drivers on optee bus
Date: Tue, 16 Jun 2020 10:29:07 +0200	[thread overview]
Message-ID: <20200616082907.GA2305431@jade> (raw)
In-Reply-To: <CAD8XO3YTz=xN2k5h8HsrYsLUgmC6dD57XbBj63e+3_xFF1H0rw@mail.gmail.com>

Hi Maxim and Jarkko,

On Mon, Jun 15, 2020 at 05:32:40PM +0300, Maxim Uvarov wrote:
> ping.
> Patchset was reviewed and all comments are codeverd. Optee-os patches
> were merged. These kernel patches look like they are hanging
> somewhere...

I'm almost OK with this patchset, except that
Documentation/ABI/testing/sysfs-bus-optee-devices needs to be updated
for the new kernel version and TEE mailing list which we're changing right
now.

The last patch touches files I'm not maintainer of. That patch depends
on the previous patches so it makes sense to keep them together.  If a
TPM device driver maintainer would ack that patch I can take it via my
tree. Or we can do it the other way around (with a v9 patchset),
whichever is preferred.

Cheers,
Jens

> 
> Thanks,
> Maxim.
> 
> On Thu, 4 Jun 2020 at 20:58, Maxim Uvarov <maxim.uvarov@linaro.org> wrote:
> >
> > v8: - fix v7 check.
> > v7: - check return value of dev_set_name() (Jarkko Sakkinen)
> > v6: - description, comments, patches reorder and destroy workqueue (Sumit Garg)
> > v5: - removed pr_err and fix typos in description (Jarkko Sakkinen)
> >     - added missed kfree in optee_open()
> > v4: - sysfs entry is optee-ta-uuid (Jerome Forissier, Sumit Garg)
> >     - added Documentation/ABI/testing/sysfs-bus-optee-devices (Greg Kroah-Hartman)
> > v3: - support tee-suppicant restart (Jens Wiklander)
> >     - description and comments (Jarkko Sakkinen)
> >     - do not name optee drivers by index in sysfs (Sumit Garg)
> > v2: - write TEE with capital letters.
> >     - declare __optee_enumerate_device() as static.
> >
> > Maxim Uvarov (3):
> >   optee: use uuid for sysfs driver entry
> >   optee: enable support for multi-stage bus enumeration
> >   tpm_ftpm_tee: register driver on TEE bus
> >
> >  .../ABI/testing/sysfs-bus-optee-devices       |  8 +++
> >  MAINTAINERS                                   |  1 +
> >  drivers/char/tpm/tpm_ftpm_tee.c               | 70 ++++++++++++++++---
> >  drivers/tee/optee/core.c                      | 27 ++++++-
> >  drivers/tee/optee/device.c                    | 38 +++++-----
> >  drivers/tee/optee/optee_private.h             | 10 ++-
> >  6 files changed, 119 insertions(+), 35 deletions(-)
> >  create mode 100644 Documentation/ABI/testing/sysfs-bus-optee-devices
> >
> > --
> > 2.17.1
> >