* [PATCH v5 0/2] synquacer: add TPM support @ 2020-07-28 3:14 Masahisa Kojima 2020-07-28 3:14 ` [PATCH v5 1/2] tpm: tis: add support for MMIO TPM on SynQuacer Masahisa Kojima 2020-07-28 3:14 ` [PATCH v5 2/2] dt-bindings: Add SynQucer TPM MMIO as a trivial device Masahisa Kojima 0 siblings, 2 replies; 8+ messages in thread From: Masahisa Kojima @ 2020-07-28 3:14 UTC (permalink / raw) To: linux-kernel Cc: masahisa.kojima, jarkko.sakkinen, linux-arm-kernel, ardb, devicetree, linux-integrity, peterhuewe, jgg This adds support for driving the TPM on Socionext SynQuacer platform using the driver for a memory mapped TIS frame. v5: - modify multi-line comment style - remove MODULE_AUTHOR() and MODULE_VERSION() v4: - add ACPI support - modify function and structure name v3: - prepare new module to handle TPM MMIO access on SynQuacer platform v2: - don't use read/write_bytes() to implement read/write16/32 since that uses the wrong address Cc: jarkko.sakkinen@linux.intel.com Cc: linux-arm-kernel@lists.infradead.org Cc: ardb@kernel.org Cc: devicetree@vger.kernel.org Cc: linux-integrity@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: peterhuewe@gmx.de Cc: jgg@ziepe.ca Masahisa Kojima (2): tpm: tis: add support for MMIO TPM on SynQuacer dt-bindings: Add SynQucer TPM MMIO as a trivial device .../devicetree/bindings/trivial-devices.yaml | 2 + drivers/char/tpm/Kconfig | 12 + drivers/char/tpm/Makefile | 1 + drivers/char/tpm/tpm_tis_synquacer.c | 208 ++++++++++++++++++ 4 files changed, 223 insertions(+) create mode 100644 drivers/char/tpm/tpm_tis_synquacer.c -- 2.20.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v5 1/2] tpm: tis: add support for MMIO TPM on SynQuacer 2020-07-28 3:14 [PATCH v5 0/2] synquacer: add TPM support Masahisa Kojima @ 2020-07-28 3:14 ` Masahisa Kojima 2020-08-13 21:51 ` Jarkko Sakkinen 2020-07-28 3:14 ` [PATCH v5 2/2] dt-bindings: Add SynQucer TPM MMIO as a trivial device Masahisa Kojima 1 sibling, 1 reply; 8+ messages in thread From: Masahisa Kojima @ 2020-07-28 3:14 UTC (permalink / raw) To: linux-kernel Cc: masahisa.kojima, jarkko.sakkinen, linux-arm-kernel, ardb, devicetree, linux-integrity, peterhuewe, jgg When fitted, the SynQuacer platform exposes its SPI TPM via a MMIO window that is backed by the SPI command sequencer in the SPI bus controller. This arrangement has the limitation that only byte size accesses are supported, and so we'll need to provide a separate module that take this into account. Signed-off-by: Ard Biesheuvel <ardb@kernel.org> Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org> --- drivers/char/tpm/Kconfig | 12 ++ drivers/char/tpm/Makefile | 1 + drivers/char/tpm/tpm_tis_synquacer.c | 208 +++++++++++++++++++++++++++ 3 files changed, 221 insertions(+) create mode 100644 drivers/char/tpm/tpm_tis_synquacer.c diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig index 58b4c573d176..a18c314da211 100644 --- a/drivers/char/tpm/Kconfig +++ b/drivers/char/tpm/Kconfig @@ -74,6 +74,18 @@ config TCG_TIS_SPI_CR50 If you have a H1 secure module running Cr50 firmware on SPI bus, say Yes and it will be accessible from within Linux. +config TCG_TIS_SYNQUACER + tristate "TPM Interface Specification 1.2 Interface / TPM 2.0 FIFO Interface (MMIO - SynQuacer)" + depends on ARCH_SYNQUACER + select TCG_TIS_CORE + help + If you have a TPM security chip that is compliant with the + TCG TIS 1.2 TPM specification (TPM1.2) or the TCG PTP FIFO + specification (TPM2.0) say Yes and it will be accessible from + within Linux on Socionext SynQuacer platform. + To compile this driver as a module, choose M here; + the module will be called tpm_tis_synquacer. + config TCG_TIS_I2C_ATMEL tristate "TPM Interface Specification 1.2 Interface (I2C - Atmel)" depends on I2C diff --git a/drivers/char/tpm/Makefile b/drivers/char/tpm/Makefile index 9567e5197f74..84db4fb3a9c9 100644 --- a/drivers/char/tpm/Makefile +++ b/drivers/char/tpm/Makefile @@ -21,6 +21,7 @@ tpm-$(CONFIG_EFI) += eventlog/efi.o tpm-$(CONFIG_OF) += eventlog/of.o obj-$(CONFIG_TCG_TIS_CORE) += tpm_tis_core.o obj-$(CONFIG_TCG_TIS) += tpm_tis.o +obj-$(CONFIG_TCG_TIS_SYNQUACER) += tpm_tis_synquacer.o obj-$(CONFIG_TCG_TIS_SPI) += tpm_tis_spi.o tpm_tis_spi-y := tpm_tis_spi_main.o diff --git a/drivers/char/tpm/tpm_tis_synquacer.c b/drivers/char/tpm/tpm_tis_synquacer.c new file mode 100644 index 000000000000..e47bdd272704 --- /dev/null +++ b/drivers/char/tpm/tpm_tis_synquacer.c @@ -0,0 +1,208 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2020 Linaro Ltd. + * + * This device driver implements MMIO TPM on SynQuacer Platform. + */ +#include <linux/acpi.h> +#include <linux/init.h> +#include <linux/module.h> +#include <linux/slab.h> +#include <linux/of.h> +#include <linux/of_device.h> +#include <linux/kernel.h> +#include "tpm.h" +#include "tpm_tis_core.h" + +/* + * irq > 0 means: use irq $irq; + * irq = 0 means: autoprobe for an irq; + * irq = -1 means: no irq support + */ +struct tpm_tis_synquacer_info { + struct resource res; + int irq; +}; + +struct tpm_tis_synquacer_phy { + struct tpm_tis_data priv; + void __iomem *iobase; +}; + +static inline struct tpm_tis_synquacer_phy *to_tpm_tis_tcg_phy(struct tpm_tis_data *data) +{ + return container_of(data, struct tpm_tis_synquacer_phy, priv); +} + +static int tpm_tis_synquacer_read_bytes(struct tpm_tis_data *data, u32 addr, + u16 len, u8 *result) +{ + struct tpm_tis_synquacer_phy *phy = to_tpm_tis_tcg_phy(data); + + while (len--) + *result++ = ioread8(phy->iobase + addr); + + return 0; +} + +static int tpm_tis_synquacer_write_bytes(struct tpm_tis_data *data, u32 addr, + u16 len, const u8 *value) +{ + struct tpm_tis_synquacer_phy *phy = to_tpm_tis_tcg_phy(data); + + while (len--) + iowrite8(*value++, phy->iobase + addr); + + return 0; +} + +static int tpm_tis_synquacer_read16_bw(struct tpm_tis_data *data, + u32 addr, u16 *result) +{ + struct tpm_tis_synquacer_phy *phy = to_tpm_tis_tcg_phy(data); + + /* + * Due to the limitation of SPI controller on SynQuacer, + * 16/32 bits access must be done in byte-wise and descending order. + */ + *result = (ioread8(phy->iobase + addr + 1) << 8) | + (ioread8(phy->iobase + addr)); + + return 0; +} + +static int tpm_tis_synquacer_read32_bw(struct tpm_tis_data *data, + u32 addr, u32 *result) +{ + struct tpm_tis_synquacer_phy *phy = to_tpm_tis_tcg_phy(data); + + /* + * Due to the limitation of SPI controller on SynQuacer, + * 16/32 bits access must be done in byte-wise and descending order. + */ + *result = (ioread8(phy->iobase + addr + 3) << 24) | + (ioread8(phy->iobase + addr + 2) << 16) | + (ioread8(phy->iobase + addr + 1) << 8) | + (ioread8(phy->iobase + addr)); + + return 0; +} + +static int tpm_tis_synquacer_write32_bw(struct tpm_tis_data *data, + u32 addr, u32 value) +{ + struct tpm_tis_synquacer_phy *phy = to_tpm_tis_tcg_phy(data); + + /* + * Due to the limitation of SPI controller on SynQuacer, + * 16/32 bits access must be done in byte-wise and descending order. + */ + iowrite8(value >> 24, phy->iobase + addr + 3); + iowrite8(value >> 16, phy->iobase + addr + 2); + iowrite8(value >> 8, phy->iobase + addr + 1); + iowrite8(value, phy->iobase + addr); + + return 0; +} + +static const struct tpm_tis_phy_ops tpm_tcg_bw = { + .read_bytes = tpm_tis_synquacer_read_bytes, + .write_bytes = tpm_tis_synquacer_write_bytes, + .read16 = tpm_tis_synquacer_read16_bw, + .read32 = tpm_tis_synquacer_read32_bw, + .write32 = tpm_tis_synquacer_write32_bw, +}; + +static int tpm_tis_synquacer_init(struct device *dev, + struct tpm_tis_synquacer_info *tpm_info) +{ + struct tpm_tis_synquacer_phy *phy; + + phy = devm_kzalloc(dev, sizeof(struct tpm_tis_synquacer_phy), GFP_KERNEL); + if (phy == NULL) + return -ENOMEM; + + phy->iobase = devm_ioremap_resource(dev, &tpm_info->res); + if (IS_ERR(phy->iobase)) + return PTR_ERR(phy->iobase); + + return tpm_tis_core_init(dev, &phy->priv, tpm_info->irq, &tpm_tcg_bw, + ACPI_HANDLE(dev)); +} + +static SIMPLE_DEV_PM_OPS(tpm_tis_synquacer_pm, tpm_pm_suspend, tpm_tis_resume); + +static int tpm_tis_synquacer_probe(struct platform_device *pdev) +{ + struct tpm_tis_synquacer_info tpm_info = {}; + struct resource *res; + + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (res == NULL) { + dev_err(&pdev->dev, "no memory resource defined\n"); + return -ENODEV; + } + tpm_info.res = *res; + + tpm_info.irq = -1; + + return tpm_tis_synquacer_init(&pdev->dev, &tpm_info); +} + +static int tpm_tis_synquacer_remove(struct platform_device *pdev) +{ + struct tpm_chip *chip = dev_get_drvdata(&pdev->dev); + + tpm_chip_unregister(chip); + tpm_tis_remove(chip); + + return 0; +} + +#ifdef CONFIG_OF +static const struct of_device_id tis_synquacer_of_platform_match[] = { + {.compatible = "socionext,synquacer-tpm-mmio"}, + {}, +}; +MODULE_DEVICE_TABLE(of, tis_synquacer_of_platform_match); +#endif + +#ifdef CONFIG_ACPI +static const struct acpi_device_id tpm_synquacer_acpi_tbl[] = { + { "SCX0009" }, + {}, +}; +MODULE_DEVICE_TABLE(acpi, tpm_synquacer_acpi_tbl); +#endif + +static struct platform_driver tis_synquacer_drv = { + .probe = tpm_tis_synquacer_probe, + .remove = tpm_tis_synquacer_remove, + .driver = { + .name = "tpm_tis_synquacer", + .pm = &tpm_tis_synquacer_pm, + .of_match_table = of_match_ptr(tis_synquacer_of_platform_match), + .acpi_match_table = ACPI_PTR(tpm_synquacer_acpi_tbl), + }, +}; + +static int __init tpm_tis_synquacer_module_init(void) +{ + int rc; + + rc = platform_driver_register(&tis_synquacer_drv); + if (rc) + return rc; + + return 0; +} + +static void __exit tpm_tis_synquacer_module_exit(void) +{ + platform_driver_unregister(&tis_synquacer_drv); +} + +module_init(tpm_tis_synquacer_module_init); +module_exit(tpm_tis_synquacer_module_exit); +MODULE_DESCRIPTION("TPM MMIO Driver for Socionext SynQuacer platform"); +MODULE_LICENSE("GPL"); -- 2.20.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v5 1/2] tpm: tis: add support for MMIO TPM on SynQuacer 2020-07-28 3:14 ` [PATCH v5 1/2] tpm: tis: add support for MMIO TPM on SynQuacer Masahisa Kojima @ 2020-08-13 21:51 ` Jarkko Sakkinen 0 siblings, 0 replies; 8+ messages in thread From: Jarkko Sakkinen @ 2020-08-13 21:51 UTC (permalink / raw) To: Masahisa Kojima Cc: linux-kernel, linux-arm-kernel, ardb, devicetree, linux-integrity, peterhuewe, jgg On Tue, Jul 28, 2020 at 12:14:31PM +0900, Masahisa Kojima wrote: > When fitted, the SynQuacer platform exposes its SPI TPM via a MMIO > window that is backed by the SPI command sequencer in the SPI bus > controller. This arrangement has the limitation that only byte size > accesses are supported, and so we'll need to provide a separate module > that take this into account. > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org> > Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org> > --- > drivers/char/tpm/Kconfig | 12 ++ > drivers/char/tpm/Makefile | 1 + > drivers/char/tpm/tpm_tis_synquacer.c | 208 +++++++++++++++++++++++++++ > 3 files changed, 221 insertions(+) > create mode 100644 drivers/char/tpm/tpm_tis_synquacer.c > > diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig > index 58b4c573d176..a18c314da211 100644 > --- a/drivers/char/tpm/Kconfig > +++ b/drivers/char/tpm/Kconfig > @@ -74,6 +74,18 @@ config TCG_TIS_SPI_CR50 > If you have a H1 secure module running Cr50 firmware on SPI bus, > say Yes and it will be accessible from within Linux. > > +config TCG_TIS_SYNQUACER > + tristate "TPM Interface Specification 1.2 Interface / TPM 2.0 FIFO Interface (MMIO - SynQuacer)" > + depends on ARCH_SYNQUACER > + select TCG_TIS_CORE > + help > + If you have a TPM security chip that is compliant with the > + TCG TIS 1.2 TPM specification (TPM1.2) or the TCG PTP FIFO > + specification (TPM2.0) say Yes and it will be accessible from > + within Linux on Socionext SynQuacer platform. > + To compile this driver as a module, choose M here; > + the module will be called tpm_tis_synquacer. > + > config TCG_TIS_I2C_ATMEL > tristate "TPM Interface Specification 1.2 Interface (I2C - Atmel)" > depends on I2C > diff --git a/drivers/char/tpm/Makefile b/drivers/char/tpm/Makefile > index 9567e5197f74..84db4fb3a9c9 100644 > --- a/drivers/char/tpm/Makefile > +++ b/drivers/char/tpm/Makefile > @@ -21,6 +21,7 @@ tpm-$(CONFIG_EFI) += eventlog/efi.o > tpm-$(CONFIG_OF) += eventlog/of.o > obj-$(CONFIG_TCG_TIS_CORE) += tpm_tis_core.o > obj-$(CONFIG_TCG_TIS) += tpm_tis.o > +obj-$(CONFIG_TCG_TIS_SYNQUACER) += tpm_tis_synquacer.o > > obj-$(CONFIG_TCG_TIS_SPI) += tpm_tis_spi.o > tpm_tis_spi-y := tpm_tis_spi_main.o > diff --git a/drivers/char/tpm/tpm_tis_synquacer.c b/drivers/char/tpm/tpm_tis_synquacer.c > new file mode 100644 > index 000000000000..e47bdd272704 > --- /dev/null > +++ b/drivers/char/tpm/tpm_tis_synquacer.c > @@ -0,0 +1,208 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2020 Linaro Ltd. > + * > + * This device driver implements MMIO TPM on SynQuacer Platform. > + */ > +#include <linux/acpi.h> > +#include <linux/init.h> > +#include <linux/module.h> > +#include <linux/slab.h> > +#include <linux/of.h> > +#include <linux/of_device.h> > +#include <linux/kernel.h> > +#include "tpm.h" > +#include "tpm_tis_core.h" > + > +/* > + * irq > 0 means: use irq $irq; > + * irq = 0 means: autoprobe for an irq; > + * irq = -1 means: no irq support > + */ > +struct tpm_tis_synquacer_info { > + struct resource res; > + int irq; > +}; > + > +struct tpm_tis_synquacer_phy { > + struct tpm_tis_data priv; > + void __iomem *iobase; > +}; > + > +static inline struct tpm_tis_synquacer_phy *to_tpm_tis_tcg_phy(struct tpm_tis_data *data) > +{ > + return container_of(data, struct tpm_tis_synquacer_phy, priv); > +} > + > +static int tpm_tis_synquacer_read_bytes(struct tpm_tis_data *data, u32 addr, > + u16 len, u8 *result) > +{ > + struct tpm_tis_synquacer_phy *phy = to_tpm_tis_tcg_phy(data); > + > + while (len--) > + *result++ = ioread8(phy->iobase + addr); > + > + return 0; > +} > + > +static int tpm_tis_synquacer_write_bytes(struct tpm_tis_data *data, u32 addr, > + u16 len, const u8 *value) > +{ > + struct tpm_tis_synquacer_phy *phy = to_tpm_tis_tcg_phy(data); > + > + while (len--) > + iowrite8(*value++, phy->iobase + addr); > + > + return 0; > +} > + > +static int tpm_tis_synquacer_read16_bw(struct tpm_tis_data *data, > + u32 addr, u16 *result) > +{ > + struct tpm_tis_synquacer_phy *phy = to_tpm_tis_tcg_phy(data); > + > + /* > + * Due to the limitation of SPI controller on SynQuacer, > + * 16/32 bits access must be done in byte-wise and descending order. > + */ > + *result = (ioread8(phy->iobase + addr + 1) << 8) | > + (ioread8(phy->iobase + addr)); > + > + return 0; > +} > + > +static int tpm_tis_synquacer_read32_bw(struct tpm_tis_data *data, > + u32 addr, u32 *result) > +{ > + struct tpm_tis_synquacer_phy *phy = to_tpm_tis_tcg_phy(data); > + > + /* > + * Due to the limitation of SPI controller on SynQuacer, > + * 16/32 bits access must be done in byte-wise and descending order. > + */ > + *result = (ioread8(phy->iobase + addr + 3) << 24) | > + (ioread8(phy->iobase + addr + 2) << 16) | > + (ioread8(phy->iobase + addr + 1) << 8) | > + (ioread8(phy->iobase + addr)); > + > + return 0; > +} > + > +static int tpm_tis_synquacer_write32_bw(struct tpm_tis_data *data, > + u32 addr, u32 value) > +{ > + struct tpm_tis_synquacer_phy *phy = to_tpm_tis_tcg_phy(data); > + > + /* > + * Due to the limitation of SPI controller on SynQuacer, > + * 16/32 bits access must be done in byte-wise and descending order. > + */ > + iowrite8(value >> 24, phy->iobase + addr + 3); > + iowrite8(value >> 16, phy->iobase + addr + 2); > + iowrite8(value >> 8, phy->iobase + addr + 1); > + iowrite8(value, phy->iobase + addr); > + > + return 0; > +} > + > +static const struct tpm_tis_phy_ops tpm_tcg_bw = { > + .read_bytes = tpm_tis_synquacer_read_bytes, > + .write_bytes = tpm_tis_synquacer_write_bytes, > + .read16 = tpm_tis_synquacer_read16_bw, > + .read32 = tpm_tis_synquacer_read32_bw, > + .write32 = tpm_tis_synquacer_write32_bw, > +}; > + > +static int tpm_tis_synquacer_init(struct device *dev, > + struct tpm_tis_synquacer_info *tpm_info) > +{ > + struct tpm_tis_synquacer_phy *phy; > + > + phy = devm_kzalloc(dev, sizeof(struct tpm_tis_synquacer_phy), GFP_KERNEL); > + if (phy == NULL) > + return -ENOMEM; > + > + phy->iobase = devm_ioremap_resource(dev, &tpm_info->res); > + if (IS_ERR(phy->iobase)) > + return PTR_ERR(phy->iobase); > + > + return tpm_tis_core_init(dev, &phy->priv, tpm_info->irq, &tpm_tcg_bw, > + ACPI_HANDLE(dev)); > +} > + > +static SIMPLE_DEV_PM_OPS(tpm_tis_synquacer_pm, tpm_pm_suspend, tpm_tis_resume); > + > +static int tpm_tis_synquacer_probe(struct platform_device *pdev) > +{ > + struct tpm_tis_synquacer_info tpm_info = {}; > + struct resource *res; > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (res == NULL) { > + dev_err(&pdev->dev, "no memory resource defined\n"); > + return -ENODEV; > + } > + tpm_info.res = *res; > + > + tpm_info.irq = -1; > + > + return tpm_tis_synquacer_init(&pdev->dev, &tpm_info); > +} > + > +static int tpm_tis_synquacer_remove(struct platform_device *pdev) > +{ > + struct tpm_chip *chip = dev_get_drvdata(&pdev->dev); > + > + tpm_chip_unregister(chip); > + tpm_tis_remove(chip); > + > + return 0; > +} > + > +#ifdef CONFIG_OF > +static const struct of_device_id tis_synquacer_of_platform_match[] = { > + {.compatible = "socionext,synquacer-tpm-mmio"}, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, tis_synquacer_of_platform_match); > +#endif > + > +#ifdef CONFIG_ACPI > +static const struct acpi_device_id tpm_synquacer_acpi_tbl[] = { > + { "SCX0009" }, > + {}, > +}; > +MODULE_DEVICE_TABLE(acpi, tpm_synquacer_acpi_tbl); > +#endif > + > +static struct platform_driver tis_synquacer_drv = { > + .probe = tpm_tis_synquacer_probe, > + .remove = tpm_tis_synquacer_remove, > + .driver = { > + .name = "tpm_tis_synquacer", > + .pm = &tpm_tis_synquacer_pm, > + .of_match_table = of_match_ptr(tis_synquacer_of_platform_match), > + .acpi_match_table = ACPI_PTR(tpm_synquacer_acpi_tbl), > + }, > +}; > + > +static int __init tpm_tis_synquacer_module_init(void) > +{ > + int rc; > + > + rc = platform_driver_register(&tis_synquacer_drv); > + if (rc) > + return rc; > + > + return 0; > +} > + > +static void __exit tpm_tis_synquacer_module_exit(void) > +{ > + platform_driver_unregister(&tis_synquacer_drv); > +} > + > +module_init(tpm_tis_synquacer_module_init); > +module_exit(tpm_tis_synquacer_module_exit); > +MODULE_DESCRIPTION("TPM MMIO Driver for Socionext SynQuacer platform"); > +MODULE_LICENSE("GPL"); > -- > 2.20.1 > I find this appropriate now. I cannot test it in run-time but since it cannot break anything else in the TPM stack, it has no risk of causing issues to the Linux ecosystem at large. Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> /Jarkko ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v5 2/2] dt-bindings: Add SynQucer TPM MMIO as a trivial device 2020-07-28 3:14 [PATCH v5 0/2] synquacer: add TPM support Masahisa Kojima 2020-07-28 3:14 ` [PATCH v5 1/2] tpm: tis: add support for MMIO TPM on SynQuacer Masahisa Kojima @ 2020-07-28 3:14 ` Masahisa Kojima 2020-08-17 18:46 ` Jarkko Sakkinen 2020-08-17 21:14 ` Jarkko Sakkinen 1 sibling, 2 replies; 8+ messages in thread From: Masahisa Kojima @ 2020-07-28 3:14 UTC (permalink / raw) To: linux-kernel Cc: masahisa.kojima, jarkko.sakkinen, linux-arm-kernel, ardb, devicetree, linux-integrity, peterhuewe, jgg, Rob Herring, Rob Herring Add a compatible string for the SynQuacer TPM to the binding for a TPM exposed via a memory mapped TIS frame. The MMIO window behaves slightly differently on this hardware, so it requires its own identifier. Cc: Rob Herring <robh+dt@kernel.org> Cc: Ard Biesheuvel <ardb@kernel.org> Acked-by: Rob Herring <robh@kernel.org> Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org> --- Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index 4165352a590a..814148939e5a 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -328,6 +328,8 @@ properties: - silabs,si7020 # Skyworks SKY81452: Six-Channel White LED Driver with Touch Panel Bias Supply - skyworks,sky81452 + # Socionext SynQuacer TPM MMIO module + - socionext,synquacer-tpm-mmio # i2c serial eeprom (24cxx) - st,24c256 # Ambient Light Sensor with SMBUS/Two Wire Serial Interface -- 2.20.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v5 2/2] dt-bindings: Add SynQucer TPM MMIO as a trivial device 2020-07-28 3:14 ` [PATCH v5 2/2] dt-bindings: Add SynQucer TPM MMIO as a trivial device Masahisa Kojima @ 2020-08-17 18:46 ` Jarkko Sakkinen 2020-08-17 21:14 ` Jarkko Sakkinen 1 sibling, 0 replies; 8+ messages in thread From: Jarkko Sakkinen @ 2020-08-17 18:46 UTC (permalink / raw) To: Masahisa Kojima Cc: linux-kernel, linux-arm-kernel, ardb, devicetree, linux-integrity, peterhuewe, jgg, Rob Herring, Rob Herring On Tue, Jul 28, 2020 at 12:14:32PM +0900, Masahisa Kojima wrote: > Add a compatible string for the SynQuacer TPM to the binding for a > TPM exposed via a memory mapped TIS frame. The MMIO window behaves > slightly differently on this hardware, so it requires its own > identifier. > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Ard Biesheuvel <ardb@kernel.org> > Acked-by: Rob Herring <robh@kernel.org> > Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org> Acked-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> /Jarkko ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v5 2/2] dt-bindings: Add SynQucer TPM MMIO as a trivial device 2020-07-28 3:14 ` [PATCH v5 2/2] dt-bindings: Add SynQucer TPM MMIO as a trivial device Masahisa Kojima 2020-08-17 18:46 ` Jarkko Sakkinen @ 2020-08-17 21:14 ` Jarkko Sakkinen 2020-08-19 10:22 ` Ard Biesheuvel 1 sibling, 1 reply; 8+ messages in thread From: Jarkko Sakkinen @ 2020-08-17 21:14 UTC (permalink / raw) To: Masahisa Kojima Cc: linux-kernel, linux-arm-kernel, ardb, devicetree, linux-integrity, peterhuewe, jgg, Rob Herring, Rob Herring On Tue, Jul 28, 2020 at 12:14:32PM +0900, Masahisa Kojima wrote: > Add a compatible string for the SynQuacer TPM to the binding for a > TPM exposed via a memory mapped TIS frame. The MMIO window behaves > slightly differently on this hardware, so it requires its own > identifier. > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Ard Biesheuvel <ardb@kernel.org> > Acked-by: Rob Herring <robh@kernel.org> > Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org> I applied these patches: http://git.infradead.org/users/jjs/linux-tpmdd.git/log/refs/heads/master /Jarkko ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v5 2/2] dt-bindings: Add SynQucer TPM MMIO as a trivial device 2020-08-17 21:14 ` Jarkko Sakkinen @ 2020-08-19 10:22 ` Ard Biesheuvel 2020-08-19 21:09 ` Jarkko Sakkinen 0 siblings, 1 reply; 8+ messages in thread From: Ard Biesheuvel @ 2020-08-19 10:22 UTC (permalink / raw) To: Jarkko Sakkinen Cc: Masahisa Kojima, Linux Kernel Mailing List, Linux ARM, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, linux-integrity, Peter Huewe, Jason Gunthorpe, Rob Herring, Rob Herring On Mon, 17 Aug 2020 at 23:14, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> wrote: > > On Tue, Jul 28, 2020 at 12:14:32PM +0900, Masahisa Kojima wrote: > > Add a compatible string for the SynQuacer TPM to the binding for a > > TPM exposed via a memory mapped TIS frame. The MMIO window behaves > > slightly differently on this hardware, so it requires its own > > identifier. > > > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: Ard Biesheuvel <ardb@kernel.org> > > Acked-by: Rob Herring <robh@kernel.org> > > Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org> > > I applied these patches: > > http://git.infradead.org/users/jjs/linux-tpmdd.git/log/refs/heads/master > Thanks Jarkko ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v5 2/2] dt-bindings: Add SynQucer TPM MMIO as a trivial device 2020-08-19 10:22 ` Ard Biesheuvel @ 2020-08-19 21:09 ` Jarkko Sakkinen 0 siblings, 0 replies; 8+ messages in thread From: Jarkko Sakkinen @ 2020-08-19 21:09 UTC (permalink / raw) To: Ard Biesheuvel Cc: Masahisa Kojima, Linux Kernel Mailing List, Linux ARM, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, linux-integrity, Peter Huewe, Jason Gunthorpe, Rob Herring, Rob Herring On Wed, Aug 19, 2020 at 12:22:52PM +0200, Ard Biesheuvel wrote: > On Mon, 17 Aug 2020 at 23:14, Jarkko Sakkinen > <jarkko.sakkinen@linux.intel.com> wrote: > > > > On Tue, Jul 28, 2020 at 12:14:32PM +0900, Masahisa Kojima wrote: > > > Add a compatible string for the SynQuacer TPM to the binding for a > > > TPM exposed via a memory mapped TIS frame. The MMIO window behaves > > > slightly differently on this hardware, so it requires its own > > > identifier. > > > > > > Cc: Rob Herring <robh+dt@kernel.org> > > > Cc: Ard Biesheuvel <ardb@kernel.org> > > > Acked-by: Rob Herring <robh@kernel.org> > > > Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org> > > > > I applied these patches: > > > > http://git.infradead.org/users/jjs/linux-tpmdd.git/log/refs/heads/master > > > > Thanks Jarkko Yeah, sorry for taking this long. I was on vacation for couple of weeks. /Jarkko ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-08-19 21:09 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-07-28 3:14 [PATCH v5 0/2] synquacer: add TPM support Masahisa Kojima 2020-07-28 3:14 ` [PATCH v5 1/2] tpm: tis: add support for MMIO TPM on SynQuacer Masahisa Kojima 2020-08-13 21:51 ` Jarkko Sakkinen 2020-07-28 3:14 ` [PATCH v5 2/2] dt-bindings: Add SynQucer TPM MMIO as a trivial device Masahisa Kojima 2020-08-17 18:46 ` Jarkko Sakkinen 2020-08-17 21:14 ` Jarkko Sakkinen 2020-08-19 10:22 ` Ard Biesheuvel 2020-08-19 21:09 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).