* [PATCH v2 0/3] tpm: tsi-i2c: Add compatible strings
@ 2022-09-28 4:39 Joel Stanley
2022-09-28 4:39 ` [PATCH v2 1/3] dt-bindings: trivial-devices: Remove Infineon SLB9673 TPM Joel Stanley
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Joel Stanley @ 2022-09-28 4:39 UTC (permalink / raw)
To: Rob Herring, Peter Huewe, Jarkko Sakkinen
Cc: devicetree, linux-integrity, Jason Gunthorpe, Johannes Holland, eajames
v2 removes the string from trivial devices and changes some of the
strings in the bindings.
Joel Stanley (2):
dt-bindings: trivial-devices: Remove Infineon SLB9673 TPM
tpm: tis-i2c: Add more compatible strings
Johannes Holland (1):
dt-bindings: tpm: Add schema for TIS I2C devices
drivers/char/tpm/tpm_tis_i2c.c | 2 +
.../bindings/security/tpm/tpm-tis-i2c.yaml | 50 +++++++++++++++++++
.../devicetree/bindings/trivial-devices.yaml | 2 -
3 files changed, 52 insertions(+), 2 deletions(-)
create mode 100644 Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml
--
2.35.1
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2 1/3] dt-bindings: trivial-devices: Remove Infineon SLB9673 TPM
2022-09-28 4:39 [PATCH v2 0/3] tpm: tsi-i2c: Add compatible strings Joel Stanley
@ 2022-09-28 4:39 ` Joel Stanley
2022-09-30 14:44 ` Rob Herring
2022-09-28 4:39 ` [PATCH v2 2/3] dt-bindings: tpm: Add schema for TIS I2C devices Joel Stanley
2022-09-28 4:39 ` [PATCH v2 3/3] tpm: tis-i2c: Add more compatible strings Joel Stanley
2 siblings, 1 reply; 12+ messages in thread
From: Joel Stanley @ 2022-09-28 4:39 UTC (permalink / raw)
To: Rob Herring, Peter Huewe, Jarkko Sakkinen
Cc: devicetree, linux-integrity, Jason Gunthorpe, Johannes Holland, eajames
This reverts commit 2353673d8a025a6ba3b3aa3917a3a98944e64702.
It will be added to its own bindings document.
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
Documentation/devicetree/bindings/trivial-devices.yaml | 2 --
1 file changed, 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 61746755c107..7c62c2740330 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -139,8 +139,6 @@ properties:
- infineon,slb9635tt
# Infineon SLB9645 I2C TPM (new protocol, max 400khz)
- infineon,slb9645tt
- # Infineon SLB9673 I2C TPM 2.0
- - infineon,slb9673
# Infineon TLV493D-A1B6 I2C 3D Magnetic Sensor
- infineon,tlv493d-a1b6
# Infineon Multi-phase Digital VR Controller xdpe11280
--
2.35.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v2 2/3] dt-bindings: tpm: Add schema for TIS I2C devices
2022-09-28 4:39 [PATCH v2 0/3] tpm: tsi-i2c: Add compatible strings Joel Stanley
2022-09-28 4:39 ` [PATCH v2 1/3] dt-bindings: trivial-devices: Remove Infineon SLB9673 TPM Joel Stanley
@ 2022-09-28 4:39 ` Joel Stanley
2022-09-30 14:45 ` Rob Herring
2022-09-28 4:39 ` [PATCH v2 3/3] tpm: tis-i2c: Add more compatible strings Joel Stanley
2 siblings, 1 reply; 12+ messages in thread
From: Joel Stanley @ 2022-09-28 4:39 UTC (permalink / raw)
To: Rob Herring, Peter Huewe, Jarkko Sakkinen
Cc: Johannes Holland, devicetree, linux-integrity, Jason Gunthorpe, eajames
From: Johannes Holland <johannes.holland@infineon.com>
Add a dt schema to support device tree bindings for the generic I2C
physical layer. Refer to the TCG PC Client Platform TPM Profile (PTP)
Specification for TPM 2.0 v1.04 Revision 14.
This includes descriptions for the Nuvoton and Infineon devices.
Signed-off-by: Johannes Holland <johannes.holland@infineon.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
v2: String changes
---
.../bindings/security/tpm/tpm-tis-i2c.yaml | 50 +++++++++++++++++++
1 file changed, 50 insertions(+)
create mode 100644 Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml
diff --git a/Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml b/Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml
new file mode 100644
index 000000000000..de1e34065748
--- /dev/null
+++ b/Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/security/tpm/tpm-tis-i2c.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: I2C PTP based TPM Devices
+
+maintainers:
+ - Johannes Holland <johannes.holland@infineon.com>
+
+description:
+ Device Tree Bindings for I2C based Trusted Platform Module (TPM).
+
+properties:
+ $nodename:
+ pattern: "^tpm(@[0-9a-f]+)?$"
+
+ compatible:
+ oneOf:
+ - description: Infineon's Trusted Platform Module (TPM) (SLB9673).
+ items:
+ - const: infineon,slb9673
+ - const: tcg,tpm-tis-i2c
+ - description: Nuvoton's Trusted Platform Module (TPM) (NPCT75x).
+ items:
+ - const: nuvoton,npct75x
+ - const: tcg,tpm-tis-i2c
+ - const: tcg,tpm-tis-i2c
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ tpm@2e {
+ compatible = "nuvoton,npct75x", "tcg,tpm-tis-i2c";
+ reg = <0x2e>;
+ };
+ };
+...
--
2.35.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v2 3/3] tpm: tis-i2c: Add more compatible strings
2022-09-28 4:39 [PATCH v2 0/3] tpm: tsi-i2c: Add compatible strings Joel Stanley
2022-09-28 4:39 ` [PATCH v2 1/3] dt-bindings: trivial-devices: Remove Infineon SLB9673 TPM Joel Stanley
2022-09-28 4:39 ` [PATCH v2 2/3] dt-bindings: tpm: Add schema for TIS I2C devices Joel Stanley
@ 2022-09-28 4:39 ` Joel Stanley
2022-09-30 14:44 ` Rob Herring
` (2 more replies)
2 siblings, 3 replies; 12+ messages in thread
From: Joel Stanley @ 2022-09-28 4:39 UTC (permalink / raw)
To: Rob Herring, Peter Huewe, Jarkko Sakkinen
Cc: devicetree, linux-integrity, Jason Gunthorpe, Johannes Holland, eajames
The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface.
https://www.nuvoton.com/products/cloud-computing/security/trusted-platform-module-tpm/
Add a compatible string for it, and the generic compatible.
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
drivers/char/tpm/tpm_tis_i2c.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c
index 0692510dfcab..4af27b7ec5b1 100644
--- a/drivers/char/tpm/tpm_tis_i2c.c
+++ b/drivers/char/tpm/tpm_tis_i2c.c
@@ -368,6 +368,8 @@ MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_id);
#ifdef CONFIG_OF
static const struct of_device_id of_tis_i2c_match[] = {
{ .compatible = "infineon,slb9673", },
+ { .compatible = "nuvoton,npct75x", },
+ { .compatible = "tcg,tpm-tis-i2c", },
{}
};
MODULE_DEVICE_TABLE(of, of_tis_i2c_match);
--
2.35.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v2 3/3] tpm: tis-i2c: Add more compatible strings
2022-09-28 4:39 ` [PATCH v2 3/3] tpm: tis-i2c: Add more compatible strings Joel Stanley
@ 2022-09-30 14:44 ` Rob Herring
2022-10-05 2:28 ` Joel Stanley
2022-09-30 21:47 ` Jarkko Sakkinen
2023-12-12 6:40 ` Guenter Roeck
2 siblings, 1 reply; 12+ messages in thread
From: Rob Herring @ 2022-09-30 14:44 UTC (permalink / raw)
To: Joel Stanley
Cc: Peter Huewe, Jarkko Sakkinen, devicetree, linux-integrity,
Jason Gunthorpe, Johannes Holland, eajames
On Wed, Sep 28, 2022 at 02:09:57PM +0930, Joel Stanley wrote:
> The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface.
>
> https://www.nuvoton.com/products/cloud-computing/security/trusted-platform-module-tpm/
>
> Add a compatible string for it, and the generic compatible.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> drivers/char/tpm/tpm_tis_i2c.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c
> index 0692510dfcab..4af27b7ec5b1 100644
> --- a/drivers/char/tpm/tpm_tis_i2c.c
> +++ b/drivers/char/tpm/tpm_tis_i2c.c
> @@ -368,6 +368,8 @@ MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_id);
> #ifdef CONFIG_OF
> static const struct of_device_id of_tis_i2c_match[] = {
> { .compatible = "infineon,slb9673", },
> + { .compatible = "nuvoton,npct75x", },
> + { .compatible = "tcg,tpm-tis-i2c", },
If there is not currently any distinction that the kernel makes, you
only need to add "tcg,tpm-tis-i2c".
> {}
> };
> MODULE_DEVICE_TABLE(of, of_tis_i2c_match);
> --
> 2.35.1
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: trivial-devices: Remove Infineon SLB9673 TPM
2022-09-28 4:39 ` [PATCH v2 1/3] dt-bindings: trivial-devices: Remove Infineon SLB9673 TPM Joel Stanley
@ 2022-09-30 14:44 ` Rob Herring
0 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2022-09-30 14:44 UTC (permalink / raw)
To: Joel Stanley
Cc: Peter Huewe, eajames, Johannes Holland, linux-integrity,
Rob Herring, Jarkko Sakkinen, Jason Gunthorpe, devicetree
On Wed, 28 Sep 2022 14:09:55 +0930, Joel Stanley wrote:
> This reverts commit 2353673d8a025a6ba3b3aa3917a3a98944e64702.
>
> It will be added to its own bindings document.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: tpm: Add schema for TIS I2C devices
2022-09-28 4:39 ` [PATCH v2 2/3] dt-bindings: tpm: Add schema for TIS I2C devices Joel Stanley
@ 2022-09-30 14:45 ` Rob Herring
0 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2022-09-30 14:45 UTC (permalink / raw)
To: Joel Stanley
Cc: Johannes Holland, linux-integrity, eajames, Peter Huewe,
devicetree, Rob Herring, Jarkko Sakkinen, Jason Gunthorpe
On Wed, 28 Sep 2022 14:09:56 +0930, Joel Stanley wrote:
> From: Johannes Holland <johannes.holland@infineon.com>
>
> Add a dt schema to support device tree bindings for the generic I2C
> physical layer. Refer to the TCG PC Client Platform TPM Profile (PTP)
> Specification for TPM 2.0 v1.04 Revision 14.
>
> This includes descriptions for the Nuvoton and Infineon devices.
>
> Signed-off-by: Johannes Holland <johannes.holland@infineon.com>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> v2: String changes
> ---
> .../bindings/security/tpm/tpm-tis-i2c.yaml | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 3/3] tpm: tis-i2c: Add more compatible strings
2022-09-28 4:39 ` [PATCH v2 3/3] tpm: tis-i2c: Add more compatible strings Joel Stanley
2022-09-30 14:44 ` Rob Herring
@ 2022-09-30 21:47 ` Jarkko Sakkinen
2022-10-04 21:20 ` Rob Herring
2023-12-12 6:40 ` Guenter Roeck
2 siblings, 1 reply; 12+ messages in thread
From: Jarkko Sakkinen @ 2022-09-30 21:47 UTC (permalink / raw)
To: Joel Stanley
Cc: Rob Herring, Peter Huewe, devicetree, linux-integrity,
Jason Gunthorpe, Johannes Holland, eajames
On Wed, Sep 28, 2022 at 02:09:57PM +0930, Joel Stanley wrote:
> The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface.
>
> https://www.nuvoton.com/products/cloud-computing/security/trusted-platform-module-tpm/
>
> Add a compatible string for it, and the generic compatible.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> drivers/char/tpm/tpm_tis_i2c.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c
> index 0692510dfcab..4af27b7ec5b1 100644
> --- a/drivers/char/tpm/tpm_tis_i2c.c
> +++ b/drivers/char/tpm/tpm_tis_i2c.c
> @@ -368,6 +368,8 @@ MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_id);
> #ifdef CONFIG_OF
> static const struct of_device_id of_tis_i2c_match[] = {
> { .compatible = "infineon,slb9673", },
> + { .compatible = "nuvoton,npct75x", },
> + { .compatible = "tcg,tpm-tis-i2c", },
> {}
> };
> MODULE_DEVICE_TABLE(of, of_tis_i2c_match);
> --
> 2.35.1
>
Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
IMHO could be picked to the same tree with DT changes instead
of my tree.
BR, Jarkko
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 3/3] tpm: tis-i2c: Add more compatible strings
2022-09-30 21:47 ` Jarkko Sakkinen
@ 2022-10-04 21:20 ` Rob Herring
2022-10-04 23:10 ` Jarkko Sakkinen
0 siblings, 1 reply; 12+ messages in thread
From: Rob Herring @ 2022-10-04 21:20 UTC (permalink / raw)
To: Jarkko Sakkinen
Cc: Joel Stanley, Peter Huewe, devicetree, linux-integrity,
Jason Gunthorpe, Johannes Holland, eajames
On Fri, Sep 30, 2022 at 4:47 PM Jarkko Sakkinen <jarkko@kernel.org> wrote:
>
> On Wed, Sep 28, 2022 at 02:09:57PM +0930, Joel Stanley wrote:
> > The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface.
> >
> > https://www.nuvoton.com/products/cloud-computing/security/trusted-platform-module-tpm/
> >
> > Add a compatible string for it, and the generic compatible.
> >
> > Signed-off-by: Joel Stanley <joel@jms.id.au>
> > ---
> > drivers/char/tpm/tpm_tis_i2c.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c
> > index 0692510dfcab..4af27b7ec5b1 100644
> > --- a/drivers/char/tpm/tpm_tis_i2c.c
> > +++ b/drivers/char/tpm/tpm_tis_i2c.c
> > @@ -368,6 +368,8 @@ MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_id);
> > #ifdef CONFIG_OF
> > static const struct of_device_id of_tis_i2c_match[] = {
> > { .compatible = "infineon,slb9673", },
> > + { .compatible = "nuvoton,npct75x", },
> > + { .compatible = "tcg,tpm-tis-i2c", },
> > {}
> > };
> > MODULE_DEVICE_TABLE(of, of_tis_i2c_match);
> > --
> > 2.35.1
> >
>
> Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
>
> IMHO could be picked to the same tree with DT changes instead
> of my tree.
It's supposed to be the other way around. DT bindings go with drivers
via subsystem tree. I don't take drivers.
But it seems this first needs some coordination with this[1] series.
Rob
[1] https://lore.kernel.org/all/20220930165116.13329-1-Alexander.Steffen@infineon.com/
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 3/3] tpm: tis-i2c: Add more compatible strings
2022-10-04 21:20 ` Rob Herring
@ 2022-10-04 23:10 ` Jarkko Sakkinen
0 siblings, 0 replies; 12+ messages in thread
From: Jarkko Sakkinen @ 2022-10-04 23:10 UTC (permalink / raw)
To: Rob Herring
Cc: Joel Stanley, Peter Huewe, devicetree, linux-integrity,
Jason Gunthorpe, Johannes Holland, eajames
On Tue, Oct 04, 2022 at 04:20:56PM -0500, Rob Herring wrote:
> On Fri, Sep 30, 2022 at 4:47 PM Jarkko Sakkinen <jarkko@kernel.org> wrote:
> >
> > On Wed, Sep 28, 2022 at 02:09:57PM +0930, Joel Stanley wrote:
> > > The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface.
> > >
> > > https://www.nuvoton.com/products/cloud-computing/security/trusted-platform-module-tpm/
> > >
> > > Add a compatible string for it, and the generic compatible.
> > >
> > > Signed-off-by: Joel Stanley <joel@jms.id.au>
> > > ---
> > > drivers/char/tpm/tpm_tis_i2c.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c
> > > index 0692510dfcab..4af27b7ec5b1 100644
> > > --- a/drivers/char/tpm/tpm_tis_i2c.c
> > > +++ b/drivers/char/tpm/tpm_tis_i2c.c
> > > @@ -368,6 +368,8 @@ MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_id);
> > > #ifdef CONFIG_OF
> > > static const struct of_device_id of_tis_i2c_match[] = {
> > > { .compatible = "infineon,slb9673", },
> > > + { .compatible = "nuvoton,npct75x", },
> > > + { .compatible = "tcg,tpm-tis-i2c", },
> > > {}
> > > };
> > > MODULE_DEVICE_TABLE(of, of_tis_i2c_match);
> > > --
> > > 2.35.1
> > >
> >
> > Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
> >
> > IMHO could be picked to the same tree with DT changes instead
> > of my tree.
>
> It's supposed to be the other way around. DT bindings go with drivers
> via subsystem tree. I don't take drivers.
>
> But it seems this first needs some coordination with this[1] series.
>
> Rob
>
> [1] https://lore.kernel.org/all/20220930165116.13329-1-Alexander.Steffen@infineon.com/
WFM, I can pick it (once the issues are fixed).
BR, Jarkko
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 3/3] tpm: tis-i2c: Add more compatible strings
2022-09-30 14:44 ` Rob Herring
@ 2022-10-05 2:28 ` Joel Stanley
0 siblings, 0 replies; 12+ messages in thread
From: Joel Stanley @ 2022-10-05 2:28 UTC (permalink / raw)
To: Rob Herring
Cc: Peter Huewe, Jarkko Sakkinen, devicetree, linux-integrity,
Jason Gunthorpe, Johannes Holland, eajames
On Fri, 30 Sept 2022 at 14:44, Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Sep 28, 2022 at 02:09:57PM +0930, Joel Stanley wrote:
> > The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface.
> >
> > https://www.nuvoton.com/products/cloud-computing/security/trusted-platform-module-tpm/
> >
> > Add a compatible string for it, and the generic compatible.
> >
> > Signed-off-by: Joel Stanley <joel@jms.id.au>
> > ---
> > drivers/char/tpm/tpm_tis_i2c.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c
> > index 0692510dfcab..4af27b7ec5b1 100644
> > --- a/drivers/char/tpm/tpm_tis_i2c.c
> > +++ b/drivers/char/tpm/tpm_tis_i2c.c
> > @@ -368,6 +368,8 @@ MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_id);
> > #ifdef CONFIG_OF
> > static const struct of_device_id of_tis_i2c_match[] = {
> > { .compatible = "infineon,slb9673", },
> > + { .compatible = "nuvoton,npct75x", },
> > + { .compatible = "tcg,tpm-tis-i2c", },
>
> If there is not currently any distinction that the kernel makes, you
> only need to add "tcg,tpm-tis-i2c".
There are device trees that just have one or the other, so it makes
sense to list both.
>
> > {}
> > };
> > MODULE_DEVICE_TABLE(of, of_tis_i2c_match);
> > --
> > 2.35.1
> >
> >
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 3/3] tpm: tis-i2c: Add more compatible strings
2022-09-28 4:39 ` [PATCH v2 3/3] tpm: tis-i2c: Add more compatible strings Joel Stanley
2022-09-30 14:44 ` Rob Herring
2022-09-30 21:47 ` Jarkko Sakkinen
@ 2023-12-12 6:40 ` Guenter Roeck
2 siblings, 0 replies; 12+ messages in thread
From: Guenter Roeck @ 2023-12-12 6:40 UTC (permalink / raw)
To: Joel Stanley
Cc: Rob Herring, Peter Huewe, Jarkko Sakkinen, devicetree,
linux-integrity, Jason Gunthorpe, Johannes Holland, eajames
On Wed, Sep 28, 2022 at 02:09:57PM +0930, Joel Stanley wrote:
> The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface.
>
> https://www.nuvoton.com/products/cloud-computing/security/trusted-platform-module-tpm/
>
> Add a compatible string for it, and the generic compatible.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
Does anyone happen to know why this patch never made it upstream ?
Thanks,
Guenter
> ---
> drivers/char/tpm/tpm_tis_i2c.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c
> index 0692510dfcab..4af27b7ec5b1 100644
> --- a/drivers/char/tpm/tpm_tis_i2c.c
> +++ b/drivers/char/tpm/tpm_tis_i2c.c
> @@ -368,6 +368,8 @@ MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_id);
> #ifdef CONFIG_OF
> static const struct of_device_id of_tis_i2c_match[] = {
> { .compatible = "infineon,slb9673", },
> + { .compatible = "nuvoton,npct75x", },
> + { .compatible = "tcg,tpm-tis-i2c", },
> {}
> };
> MODULE_DEVICE_TABLE(of, of_tis_i2c_match);
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-12-12 6:40 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-28 4:39 [PATCH v2 0/3] tpm: tsi-i2c: Add compatible strings Joel Stanley
2022-09-28 4:39 ` [PATCH v2 1/3] dt-bindings: trivial-devices: Remove Infineon SLB9673 TPM Joel Stanley
2022-09-30 14:44 ` Rob Herring
2022-09-28 4:39 ` [PATCH v2 2/3] dt-bindings: tpm: Add schema for TIS I2C devices Joel Stanley
2022-09-30 14:45 ` Rob Herring
2022-09-28 4:39 ` [PATCH v2 3/3] tpm: tis-i2c: Add more compatible strings Joel Stanley
2022-09-30 14:44 ` Rob Herring
2022-10-05 2:28 ` Joel Stanley
2022-09-30 21:47 ` Jarkko Sakkinen
2022-10-04 21:20 ` Rob Herring
2022-10-04 23:10 ` Jarkko Sakkinen
2023-12-12 6:40 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).