From: Tushar Sugandhi <tusharsu@linux.microsoft.com>
To: Mimi Zohar <zohar@linux.ibm.com>,
joe@perches.com, skhan@linuxfoundation.org,
linux-integrity@vger.kernel.org
Cc: sashal@kernel.org, nramas@linux.microsoft.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/3] IMA: improve log messages
Date: Tue, 18 Feb 2020 11:15:13 -0800 [thread overview]
Message-ID: <3e479e25-ccf2-0e5b-3b78-3c63600245b8@linux.microsoft.com> (raw)
In-Reply-To: <1581856840.8515.168.camel@linux.ibm.com>
On 2020-02-16 4:40 a.m., Mimi Zohar wrote:
> On Fri, 2020-02-14 at 17:47 -0800, Tushar Sugandhi wrote:
>> The log messages from IMA subsystem should be consistent for better
>> diagnosability and discoverability.
>
> The change isn't limited to IMA. I would change "IMA" to "integrity"
> in the Subject line and in this patch description.
>
Will do.
>> This patch set improves the logging by removing duplicate log formatting
>> macros, adding a consistent prefix to the log messages, and adding new
>> log messages where necessary.
>
> Much better!
>
> thanks,
>
> Mimi
>
prev parent reply other threads:[~2020-02-18 19:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-15 1:47 [PATCH v4 0/3] IMA: improve log messages Tushar Sugandhi
2020-02-15 1:47 ` [PATCH v4 1/3] IMA: Update KBUILD_MODNAME for IMA files to ima Tushar Sugandhi
2020-02-18 19:25 ` Tushar Sugandhi
2020-02-18 19:37 ` Mimi Zohar
2020-02-15 1:47 ` [PATCH v4 2/3] IMA: Add log statements for failure conditions Tushar Sugandhi
2020-02-16 12:42 ` Mimi Zohar
2020-02-15 1:47 ` [PATCH v4 3/3] IMA: Remove duplicate pr_fmt definitions Tushar Sugandhi
2020-02-16 12:40 ` Mimi Zohar
2020-02-16 12:40 ` [PATCH v4 0/3] IMA: improve log messages Mimi Zohar
2020-02-18 19:15 ` Tushar Sugandhi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e479e25-ccf2-0e5b-3b78-3c63600245b8@linux.microsoft.com \
--to=tusharsu@linux.microsoft.com \
--cc=joe@perches.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nramas@linux.microsoft.com \
--cc=sashal@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).