From: David Howells <dhowells@redhat.com>
To: Vitaly Chikunov <vt@altlinux.org>
Cc: dhowells@redhat.com, Stefan Berger <stefanb@linux.vnet.ibm.com>,
keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, patrick@puiterwijk.org,
linux-integrity@vger.kernel.org,
Stefan Berger <stefanb@linux.ibm.com>,
Mimi Zohar <zohar@linux.ibm.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Subject: Re: [PATCH v5 4/4] ima: Support EC keys for signature verification
Date: Mon, 01 Feb 2021 13:19:58 +0000 [thread overview]
Message-ID: <4162571.1612185598@warthog.procyon.org.uk> (raw)
In-Reply-To: <20210129155529.brxbmgzzosvtwrzw@altlinux.org>
Vitaly Chikunov <vt@altlinux.org> wrote:
> > +static inline
> > +const struct public_key *asymmetric_key_public_key(const struct key *key)
> > +{
> > + return key->payload.data[asym_crypto];
> > +}
>
> I wonder why use this accessor which does nothing else, because in all
> other places payload.data[asym_crypto] accessed directly.
We should probably move to using wrappers rather than accessing directly for
type safety.
David
next prev parent reply other threads:[~2021-02-01 13:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210129155529.brxbmgzzosvtwrzw@altlinux.org>
[not found] ` <20210129150355.850093-1-stefanb@linux.vnet.ibm.com>
[not found] ` <20210129150355.850093-2-stefanb@linux.vnet.ibm.com>
2021-01-29 19:44 ` [PATCH v5 1/4] crypto: Add support for ECDSA signature verification Herbert Xu
[not found] ` <20210129150355.850093-5-stefanb@linux.vnet.ibm.com>
2021-02-01 13:19 ` David Howells [this message]
2021-02-01 13:23 ` [PATCH v5 2/4] x509: Detect sm2 keys by their parameters OID David Howells
2021-02-01 14:35 ` Stefan Berger
2021-02-01 14:54 ` Mimi Zohar
2021-02-01 15:07 ` David Howells
2021-02-02 3:56 ` Herbert Xu
2021-02-02 8:27 ` David Howells
2021-02-02 8:55 ` Herbert Xu
2021-02-02 9:33 ` David Howells
2021-02-02 9:42 ` Herbert Xu
2021-02-02 10:16 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4162571.1612185598@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@puiterwijk.org \
--cc=stefanb@linux.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
--cc=tianjia.zhang@linux.alibaba.com \
--cc=vt@altlinux.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).