From: Mimi Zohar <zohar@linux.ibm.com>
To: Stefan Berger <stefanb@linux.ibm.com>,
David Howells <dhowells@redhat.com>
Cc: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, patrick@puiterwijk.org,
linux-integrity@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
"davem@davemloft.net" <davem@davemloft.net>,
Mimi Zohar <zohar@linux.vnet.ibm.com>
Subject: Re: [PATCH v5 2/4] x509: Detect sm2 keys by their parameters OID
Date: Mon, 01 Feb 2021 09:54:43 -0500 [thread overview]
Message-ID: <58935b00f65e389e9ae3da2425d06bd88d280e43.camel@linux.ibm.com> (raw)
In-Reply-To: <71a77d10-e645-194f-5073-ebf180a8d70e@linux.ibm.com>
On Mon, 2021-02-01 at 09:35 -0500, Stefan Berger wrote:
> On 2/1/21 8:23 AM, David Howells wrote:
> > Stefan Berger <stefanb@linux.vnet.ibm.com> wrote:
> >
> >> From: Stefan Berger <stefanb@linux.ibm.com>
> >>
> >> Detect whether a key is an sm2 type of key by its OID in the parameters
> >> array rather than assuming that everything under OID_id_ecPublicKey
> >> is sm2, which is not the case.
> >>
> >> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> >> Cc: David Howells <dhowells@redhat.com>
> >> Cc: keyrings@vger.kernel.org
> > I presume these cc's are intentionally not on the first patch or the cover (if
> > there is one)?
>
> No, this is not intentional. I guess this is a case of wrong use of cc:
> versus mailing lists - my bad. I posted the whole series to
> linux-crypto, linux-integrity, keyrings and lkml.
>
> V6 is at least visible here now:
>
> - https://lkml.org/lkml/2021/1/31/323
>
> - https://marc.info/?l=linux-crypto-vger&m=161213604618722&w=2
>
> -
> https://lore.kernel.org/linux-integrity/20210131233301.1301787-1-stefanb@linux.ibm.com/T/#mbc9fae5facb4178f64c1145e2654258c0af8fa96
>
> - https://marc.info/?l=linux-keyrings&m=161213608818735&w=2
>
>
>
> >
> > Do you have a branch you want me to pull or did you want me to take just
> > patches 2-4?
>
> Please take it from the mailing list. If there are requests for more
> changes on the crypto level, I will send another series. I personally am
> waiting for some sort of verdict on the crypto level...
The entire patch set should be upstreamed as a single patch set, after
having each of the maintainer's Ack it. In addition, the v6 version is
missing some Reviewed-by tags. (Stefan will re-post a v7 patch set.)
David, I don't have problem with this patch set being upstreamed via
the keys subsystem, assuming it's been tested.
thanks,
Mimi
next prev parent reply other threads:[~2021-02-01 15:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210129155529.brxbmgzzosvtwrzw@altlinux.org>
[not found] ` <20210129150355.850093-1-stefanb@linux.vnet.ibm.com>
[not found] ` <20210129150355.850093-2-stefanb@linux.vnet.ibm.com>
2021-01-29 19:44 ` [PATCH v5 1/4] crypto: Add support for ECDSA signature verification Herbert Xu
[not found] ` <20210129150355.850093-5-stefanb@linux.vnet.ibm.com>
2021-02-01 13:19 ` [PATCH v5 4/4] ima: Support EC keys for " David Howells
2021-02-01 13:23 ` [PATCH v5 2/4] x509: Detect sm2 keys by their parameters OID David Howells
2021-02-01 14:35 ` Stefan Berger
2021-02-01 14:54 ` Mimi Zohar [this message]
2021-02-01 15:07 ` David Howells
2021-02-02 3:56 ` Herbert Xu
2021-02-02 8:27 ` David Howells
2021-02-02 8:55 ` Herbert Xu
2021-02-02 9:33 ` David Howells
2021-02-02 9:42 ` Herbert Xu
2021-02-02 10:16 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58935b00f65e389e9ae3da2425d06bd88d280e43.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@puiterwijk.org \
--cc=stefanb@linux.ibm.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).