From: prakhar srivastava <prsriva02@gmail.com>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: linux-integrity <linux-integrity@vger.kernel.org>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org,
Roberto Sassu <roberto.sassu@huawei.com>,
thiago Jung Bauermann <bauerman@linux.ibm.com>
Subject: Re: [PATCH V8 2/3] Define a new ima template field buf
Date: Fri, 14 Jun 2019 10:52:35 -0700 [thread overview]
Message-ID: <CAEFn8qL-Fumt82oZ6-J-dWA29ztLLraJ6iXc7+du=vNtyBQO4g@mail.gmail.com> (raw)
In-Reply-To: <1560521651.4072.7.camel@linux.ibm.com>
On Fri, Jun 14, 2019 at 7:14 AM Mimi Zohar <zohar@linux.ibm.com> wrote:
>
> > > > diff --git a/security/integrity/ima/ima_init.c b/security/integrity/ima/ima_init.c
> > > > index 993d0f1915ff..c8591406c0e2 100644
> > > > --- a/security/integrity/ima/ima_init.c
> > > > +++ b/security/integrity/ima/ima_init.c
> > > > @@ -50,7 +50,7 @@ static int __init ima_add_boot_aggregate(void)
> > > > struct ima_template_entry *entry;
> > > > struct integrity_iint_cache tmp_iint, *iint = &tmp_iint;
> > > > struct ima_event_data event_data = {iint, NULL, boot_aggregate_name,
> > > > - NULL, 0, NULL};
> > > > + NULL, 0, NULL, NULL, 0};
> > >
> > > here, don't belong in this patch. It belongs in "IMA: support for per
> > > policy rule template formats", in case it should ever be backported.
> > > Please post this as a separate patch, that will be squashed with
> > > "IMA: support for per policy rule template formats".
> >
> > My mistake. I should have picked up Thaigo's "ima: Use designated
> > initializers for struct ima_event_data". Please drop these changes
> > instead.
>
> Sorry for the confusion. I just pushed out Thiago's patch.
>
Just to clarify:
- no split up of patch is needed.
- only formatting needs to cleaned up.
Apologies for the formatting issues, my editor switches back to
tab as 4 chars.
Thanks,
Prakhar Srivastava
> thanks,
>
> Mimi
>
next prev parent reply other threads:[~2019-06-14 17:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 22:15 [PATCH V8 0/3] Add support for measuring the boot command line during kexec_file_load Prakhar Srivastava
2019-06-12 22:15 ` [PATCH V8 1/3] Define a new IMA hook to measure the boot command line arguments Prakhar Srivastava
2019-06-13 19:10 ` James Morris
2019-06-13 19:22 ` Mimi Zohar
2019-06-14 17:48 ` prakhar srivastava
2019-06-12 22:15 ` [PATCH V8 2/3] Define a new ima template field buf Prakhar Srivastava
2019-06-13 19:15 ` James Morris
2019-06-13 19:59 ` Mimi Zohar
2019-06-14 10:57 ` Mimi Zohar
2019-06-14 14:14 ` Mimi Zohar
2019-06-14 17:52 ` prakhar srivastava [this message]
2019-06-12 22:15 ` [PATCH V8 3/3] Call ima_kexec_cmdline to measure the cmdline args Prakhar Srivastava
2019-06-12 22:31 ` Mimi Zohar
2019-06-13 8:26 ` Dave Young
2019-06-13 20:07 ` Mimi Zohar
2019-06-13 19:16 ` James Morris
2019-06-13 20:20 ` Mimi Zohar
2019-06-13 20:48 ` [PATCH V8 0/3] Add support for measuring the boot command line during kexec_file_load Mimi Zohar
2019-06-14 17:39 ` prakhar srivastava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEFn8qL-Fumt82oZ6-J-dWA29ztLLraJ6iXc7+du=vNtyBQO4g@mail.gmail.com' \
--to=prsriva02@gmail.com \
--cc=bauerman@linux.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=roberto.sassu@huawei.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).