linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] integrity: use KERNEL_DS instead of get_ds()
@ 2019-03-01 20:10 Jann Horn
  2019-03-05  0:25 ` Jann Horn
  0 siblings, 1 reply; 2+ messages in thread
From: Jann Horn @ 2019-03-01 20:10 UTC (permalink / raw)
  To: Mimi Zohar, Dmitry Kasatkin, jannh
  Cc: linux-integrity, linux-fsdevel, linux-kernel

get_ds() is a legacy name for KERNEL_DS; all architectures #define it to
KERNEL_DS, and almost every user of set_fs() uses the name KERNEL_DS.

Let the integrity subsystem also use KERNEL_DS so that we can get rid of
get_ds() at some point.

Signed-off-by: Jann Horn <jannh@google.com>
---
 security/integrity/iint.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/integrity/iint.c b/security/integrity/iint.c
index 88f04b3380d4..423876fca8b4 100644
--- a/security/integrity/iint.c
+++ b/security/integrity/iint.c
@@ -200,7 +200,7 @@ int integrity_kernel_read(struct file *file, loff_t offset,
 		return -EBADF;
 
 	old_fs = get_fs();
-	set_fs(get_ds());
+	set_fs(KERNEL_DS);
 	ret = __vfs_read(file, buf, count, &offset);
 	set_fs(old_fs);
 
-- 
2.21.0.352.gf09ad66450-goog


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] integrity: use KERNEL_DS instead of get_ds()
  2019-03-01 20:10 [PATCH] integrity: use KERNEL_DS instead of get_ds() Jann Horn
@ 2019-03-05  0:25 ` Jann Horn
  0 siblings, 0 replies; 2+ messages in thread
From: Jann Horn @ 2019-03-05  0:25 UTC (permalink / raw)
  To: Mimi Zohar, Dmitry Kasatkin, Jann Horn
  Cc: linux-integrity, linux-fsdevel, kernel list

On Fri, Mar 1, 2019 at 9:10 PM Jann Horn <jannh@google.com> wrote:
>
> get_ds() is a legacy name for KERNEL_DS; all architectures #define it to
> KERNEL_DS, and almost every user of set_fs() uses the name KERNEL_DS.
>
> Let the integrity subsystem also use KERNEL_DS so that we can get rid of
> get_ds() at some point.

Nevermind, Linus just did this across the tree in
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=736706bee3298208343a76096370e4f6a5c55915
.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-05  0:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-01 20:10 [PATCH] integrity: use KERNEL_DS instead of get_ds() Jann Horn
2019-03-05  0:25 ` Jann Horn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).