From: Greg KH <gregkh@linuxfoundation.org> To: Roberto Sassu <roberto.sassu@huawei.com> Cc: "zohar@linux.ibm.com" <zohar@linux.ibm.com>, "linux-integrity@vger.kernel.org" <linux-integrity@vger.kernel.org>, "linux-security-module@vger.kernel.org" <linux-security-module@vger.kernel.org>, "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>, "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [RFC][PATCH 04/12] digest_lists: Objects Date: Mon, 28 Jun 2021 10:47:13 +0200 [thread overview] Message-ID: <YNmMkUwaPj0Xgh2r@kroah.com> (raw) In-Reply-To: <22fff08f1a70460da814d3f21b497f8b@huawei.com> On Mon, Jun 28, 2021 at 08:14:41AM +0000, Roberto Sassu wrote: > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > Sent: Sunday, June 27, 2021 12:56 PM > > On Fri, Jun 25, 2021 at 06:56:06PM +0200, Roberto Sassu wrote: > > > +++ b/security/integrity/digest_lists/digest_lists.h > > > @@ -0,0 +1,117 @@ > > > +/* SPDX-License-Identifier: GPL-2.0 */ > > > +/* > > > + * Copyright (C) 2005,2006,2007,2008 IBM Corporation > > > + * Copyright (C) 2017-2021 Huawei Technologies Duesseldorf GmbH > > > + * > > > + * Author: Roberto Sassu <roberto.sassu@huawei.com> > > > + * > > > + * This program is free software; you can redistribute it and/or > > > + * modify it under the terms of the GNU General Public License as > > > + * published by the Free Software Foundation, version 2 of the > > > + * License. > > > + * > > > + * File: digest_lists.h > > > + * Unexported definitions for digest lists. > > > > Unexported to whom? > > Hi Greg > > I meant not placed in include/linux. That's obvious based on the location of the file :) > > > + > > > +static inline struct compact_list_hdr *get_hdr( > > > + struct digest_list_item *digest_list, > > > + loff_t hdr_offset) > > > +{ > > > + return (struct compact_list_hdr *)(digest_list->buf + hdr_offset); > > > +} > > > > pointer math feels rough, are you shure you want to do this this way? > > Maybe, I could change digest_list_item_ref to: > > struct digest_list_item_ref { > struct digest_list_item *digest_list; > u8 *digest; > struct compact_list_hdr *hdr; > }; > > where digest and hdr are calculated in the same way. That works better, no need to do pointer math if you do not have to. thanks, greg k-h
next prev parent reply other threads:[~2021-06-28 8:47 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-25 16:56 [RFC][PATCH 00/12] Huawei Digest Lists Roberto Sassu 2021-06-25 16:56 ` [RFC][PATCH 01/12] ima: Add digest, algo, measured parameters to ima_measure_critical_data() Roberto Sassu 2021-06-25 18:26 ` Mimi Zohar 2021-06-25 16:56 ` [RFC][PATCH 02/12] digest_lists: Overview Roberto Sassu 2021-06-25 16:56 ` [RFC][PATCH 03/12] digest_lists: Basic definitions Roberto Sassu 2021-06-27 10:53 ` Greg KH 2021-06-27 15:23 ` Matthew Wilcox 2021-06-27 15:35 ` Greg KH 2021-06-28 8:30 ` Roberto Sassu 2021-06-28 8:46 ` Greg KH 2021-06-28 9:27 ` Roberto Sassu 2021-06-28 9:32 ` Greg KH 2021-06-28 9:51 ` Roberto Sassu 2021-06-25 16:56 ` [RFC][PATCH 04/12] digest_lists: Objects Roberto Sassu 2021-06-27 10:56 ` Greg KH 2021-06-28 8:14 ` Roberto Sassu 2021-06-28 8:47 ` Greg KH [this message] 2021-06-25 16:56 ` [RFC][PATCH 05/12] digest_lists: Methods Roberto Sassu 2021-06-25 16:56 ` [RFC][PATCH 06/12] digest_lists: Parser Roberto Sassu 2021-06-25 16:56 ` [RFC][PATCH 07/12] digest_lists: Interfaces - digest_list_add, digest_list_del Roberto Sassu 2021-06-25 16:56 ` [RFC][PATCH 08/12] digest_lists: Interfaces - digest_lists_loaded Roberto Sassu 2021-06-25 16:56 ` [RFC][PATCH 09/12] digest_lists: Interfaces - digest_label Roberto Sassu 2021-06-25 16:56 ` [RFC][PATCH 10/12] digest_lists: Interfaces - digest_query Roberto Sassu 2021-06-25 16:56 ` [RFC][PATCH 11/12] digest_lists: Interfaces - digests_count Roberto Sassu 2021-06-25 16:56 ` [RFC][PATCH 12/12] digest_lists: Tests Roberto Sassu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YNmMkUwaPj0Xgh2r@kroah.com \ --to=gregkh@linuxfoundation.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-integrity@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=roberto.sassu@huawei.com \ --cc=zohar@linux.ibm.com \ --subject='Re: [RFC][PATCH 04/12] digest_lists: Objects' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).