From: Steffen Maier <maier@linux.ibm.com>
To: Joe Perches <joe@perches.com>,
LKML <linux-kernel@vger.kernel.org>,
Jiri Kosina <trivial@kernel.org>,
Benjamin Block <bblock@linux.ibm.com>
Cc: linux-wireless@vger.kernel.org, linux-fbdev@vger.kernel.org,
oss-drivers@netronome.com, nouveau@lists.freedesktop.org,
alsa-devel <alsa-devel@alsa-project.org>,
dri-devel@lists.freedesktop.org, linux-ide@vger.kernel.org,
dm-devel@redhat.com, linux-mtd@lists.infradead.org,
linux-i2c@vger.kernel.org, sparclinux@vger.kernel.org,
kvmarm@lists.cs.columbia.edu, linux-rtc@vger.kernel.org,
linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org,
dccp@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-atm-general@lists.sourceforge.net,
linux-afs@lists.infradead.org, coreteam@netfilter.org,
intel-wired-lan@lists.osuosl.org, linux-serial@vger.kernel.org,
linux-input@vger.kernel.org, linux-mmc@vger.kernel.org,
Kees Cook <kees.cook@canonical.com>,
linux-media@vger.kernel.org, linux-pm@vger.kernel.org,
intel-gfx@lists.freedesktop.org, linux-sctp@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-nvme@lists.infradead.org, storagedev@microchip.com,
ceph-devel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-nfs@vger.kernel.org, linux-parisc@vger.kernel.org,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>,
linux-mips@vger.kernel.org, iommu@lists.linux-foundation.org,
netfilter-devel@vger.kernel.org, linux-crypto@vger.kernel.org,
bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;
Date: Thu, 10 Sep 2020 11:18:29 +0200 [thread overview]
Message-ID: <0c66fbe5-c48b-7dc1-f7fe-1498da9cc1a3@linux.ibm.com> (raw)
In-Reply-To: <e6387578c75736d61b2fe70d9783d91329a97eb4.camel@perches.com>
On 9/9/20 10:06 PM, Joe Perches wrote:
> fallthrough to a separate case/default label break; isn't very readable.
>
> Convert pseudo-keyword fallthrough; statements to a simple break; when
> the next label is case or default and the only statement in the next
> label block is break;
>
> Found using:
>
> $ grep-2.5.4 -rP --include=*.[ch] -n "fallthrough;(\s*(case\s+\w+|default)\s*:\s*){1,7}break;" *
>
> Miscellanea:
>
> o Move or coalesce a couple label blocks above a default: block.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>
> Compiled allyesconfig x86-64 only.
> A few files for other arches were not compiled.
> drivers/s390/scsi/zfcp_fsf.c | 2 +-
> 82 files changed, 109 insertions(+), 112 deletions(-)
> diff --git a/drivers/s390/scsi/zfcp_fsf.c b/drivers/s390/scsi/zfcp_fsf.c
> index 140186fe1d1e..2741a07df692 100644
> --- a/drivers/s390/scsi/zfcp_fsf.c
> +++ b/drivers/s390/scsi/zfcp_fsf.c
> @@ -2105,7 +2105,7 @@ static void zfcp_fsf_open_lun_handler(struct zfcp_fsf_req *req)
>
> case FSF_PORT_HANDLE_NOT_VALID:
> zfcp_erp_adapter_reopen(adapter, 0, "fsouh_1");
> - fallthrough;
> + break;
> case FSF_LUN_ALREADY_OPEN:
> break;
> case FSF_PORT_BOXED:
Acked-by: Steffen Maier <maier@linux.ibm.com> # for zfcp
--
Mit freundlichen Gruessen / Kind regards
Steffen Maier
Linux on IBM Z Development
https://www.ibm.com/privacy/us/en/
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Matthias Hartmann
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-09-10 10:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 20:06 [trivial PATCH] treewide: Convert switch/case fallthrough; to break; Joe Perches
2020-09-09 20:38 ` Gustavo A. R. Silva
2020-09-09 20:55 ` Keith Busch
2020-09-17 19:40 ` Jacob Keller
2020-09-09 22:36 ` Jason Gunthorpe
2020-09-09 22:47 ` Joe Perches
2020-09-10 6:28 ` Mauro Carvalho Chehab
2020-09-10 6:53 ` Wolfram Sang
2020-09-10 8:24 ` Nicolas.Ferre--- via iommu
2020-09-10 8:47 ` Felipe Balbi
2020-09-10 9:18 ` Steffen Maier [this message]
2020-09-10 9:24 ` Ilya Dryomov
2020-09-10 10:16 ` Matthias Brugger
2020-09-10 14:21 ` Robin Murphy
2020-09-11 4:19 ` Joe Perches
2020-09-15 9:06 ` [Intel-gfx] " Jani Nikula
2020-09-15 9:19 ` Miquel Raynal
2020-09-17 8:03 ` [oss-drivers] " Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c66fbe5-c48b-7dc1-f7fe-1498da9cc1a3@linux.ibm.com \
--to=maier@linux.ibm.com \
--cc=alsa-devel@alsa-project.org \
--cc=bblock@linux.ibm.com \
--cc=bpf@vger.kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=coreteam@netfilter.org \
--cc=dccp@vger.kernel.org \
--cc=dm-devel@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joe@perches.com \
--cc=kees.cook@canonical.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-afs@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=oss-drivers@netronome.com \
--cc=sparclinux@vger.kernel.org \
--cc=storagedev@microchip.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).