* [PATCH] dma/coherent: remove unused dma_get_device_base()
@ 2019-09-17 13:00 Qian Cai
2019-09-25 20:54 ` Qian Cai
2019-10-30 18:13 ` Christoph Hellwig
0 siblings, 2 replies; 4+ messages in thread
From: Qian Cai @ 2019-09-17 13:00 UTC (permalink / raw)
To: hch; +Cc: vladimir.murzin, linux-kernel, iommu, robin.murphy
dma_get_device_base() was first introduced in the commit c41f9ea998f3
("drivers: dma-coherent: Account dma_pfn_offset when used with device
tree"). Later, it was removed by the commit 43fc509c3efb ("dma-coherent:
introduce interface for default DMA pool")
Found by the -Wunused-function compilation warning.
Signed-off-by: Qian Cai <cai@lca.pw>
---
kernel/dma/coherent.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/kernel/dma/coherent.c b/kernel/dma/coherent.c
index 29fd6590dc1e..909b38e1c29b 100644
--- a/kernel/dma/coherent.c
+++ b/kernel/dma/coherent.c
@@ -28,15 +28,6 @@ static inline struct dma_coherent_mem *dev_get_coherent_memory(struct device *de
return NULL;
}
-static inline dma_addr_t dma_get_device_base(struct device *dev,
- struct dma_coherent_mem * mem)
-{
- if (mem->use_dev_dma_pfn_offset)
- return (mem->pfn_base - dev->dma_pfn_offset) << PAGE_SHIFT;
- else
- return mem->device_base;
-}
-
static int dma_init_coherent_memory(phys_addr_t phys_addr,
dma_addr_t device_addr, size_t size,
struct dma_coherent_mem **mem)
--
1.8.3.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dma/coherent: remove unused dma_get_device_base()
2019-09-17 13:00 [PATCH] dma/coherent: remove unused dma_get_device_base() Qian Cai
@ 2019-09-25 20:54 ` Qian Cai
2019-10-01 6:43 ` Christoph Hellwig
2019-10-30 18:13 ` Christoph Hellwig
1 sibling, 1 reply; 4+ messages in thread
From: Qian Cai @ 2019-09-25 20:54 UTC (permalink / raw)
To: hch; +Cc: iommu, vladimir.murzin, robin.murphy, linux-kernel
Ping. Please take a look at this trivial patch.
On Tue, 2019-09-17 at 09:00 -0400, Qian Cai wrote:
> dma_get_device_base() was first introduced in the commit c41f9ea998f3
> ("drivers: dma-coherent: Account dma_pfn_offset when used with device
> tree"). Later, it was removed by the commit 43fc509c3efb ("dma-coherent:
> introduce interface for default DMA pool")
>
> Found by the -Wunused-function compilation warning.
>
> Signed-off-by: Qian Cai <cai@lca.pw>
> ---
> kernel/dma/coherent.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/kernel/dma/coherent.c b/kernel/dma/coherent.c
> index 29fd6590dc1e..909b38e1c29b 100644
> --- a/kernel/dma/coherent.c
> +++ b/kernel/dma/coherent.c
> @@ -28,15 +28,6 @@ static inline struct dma_coherent_mem *dev_get_coherent_memory(struct device *de
> return NULL;
> }
>
> -static inline dma_addr_t dma_get_device_base(struct device *dev,
> - struct dma_coherent_mem * mem)
> -{
> - if (mem->use_dev_dma_pfn_offset)
> - return (mem->pfn_base - dev->dma_pfn_offset) << PAGE_SHIFT;
> - else
> - return mem->device_base;
> -}
> -
> static int dma_init_coherent_memory(phys_addr_t phys_addr,
> dma_addr_t device_addr, size_t size,
> struct dma_coherent_mem **mem)
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dma/coherent: remove unused dma_get_device_base()
2019-09-17 13:00 [PATCH] dma/coherent: remove unused dma_get_device_base() Qian Cai
2019-09-25 20:54 ` Qian Cai
@ 2019-10-30 18:13 ` Christoph Hellwig
1 sibling, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2019-10-30 18:13 UTC (permalink / raw)
To: Qian Cai; +Cc: vladimir.murzin, linux-kernel, iommu, robin.murphy, hch
So it turns out the user now showed up, so I'm skipping this patch.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-30 18:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-17 13:00 [PATCH] dma/coherent: remove unused dma_get_device_base() Qian Cai
2019-09-25 20:54 ` Qian Cai
2019-10-01 6:43 ` Christoph Hellwig
2019-10-30 18:13 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).