From: John Garry <john.garry@huawei.com>
To: <lorenzo.pieralisi@arm.com>, <guohanjun@huawei.com>,
<sudeep.holla@arm.com>, <robin.murphy@arm.com>,
<mark.rutland@arm.com>, <will@kernel.org>
Cc: nleeder@codeaurora.org, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org, linuxarm@huawei.com,
iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org, lenb@kernel.org
Subject: [RFC PATCH 1/6] ACPI/IORT: Set PMCG device parent
Date: Mon, 30 Sep 2019 22:33:46 +0800 [thread overview]
Message-ID: <1569854031-237636-2-git-send-email-john.garry@huawei.com> (raw)
In-Reply-To: <1569854031-237636-1-git-send-email-john.garry@huawei.com>
In the IORT, a PMCG node includes a node reference to its associated
device.
Set the PMCG platform device parent device for future referencing.
For now, we only consider setting for when the associated component is an
SMMUv3.
Signed-off-by: John Garry <john.garry@huawei.com>
---
drivers/acpi/arm64/iort.c | 34 ++++++++++++++++++++++++++++++++--
1 file changed, 32 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
index 8569b79e8b58..0b687520c3e7 100644
--- a/drivers/acpi/arm64/iort.c
+++ b/drivers/acpi/arm64/iort.c
@@ -1455,7 +1455,7 @@ static __init const struct iort_dev_config *iort_get_dev_cfg(
* Returns: 0 on success, <0 failure
*/
static int __init iort_add_platform_device(struct acpi_iort_node *node,
- const struct iort_dev_config *ops)
+ const struct iort_dev_config *ops, struct device *parent)
{
struct fwnode_handle *fwnode;
struct platform_device *pdev;
@@ -1466,6 +1466,8 @@ static int __init iort_add_platform_device(struct acpi_iort_node *node,
if (!pdev)
return -ENOMEM;
+ pdev->dev.parent = parent;
+
if (ops->dev_set_proximity) {
ret = ops->dev_set_proximity(&pdev->dev, node);
if (ret)
@@ -1573,6 +1575,11 @@ static void __init iort_enable_acs(struct acpi_iort_node *iort_node)
static inline void iort_enable_acs(struct acpi_iort_node *iort_node) { }
#endif
+static int iort_fwnode_match(struct device *dev, const void *fwnode)
+{
+ return dev->fwnode == fwnode;
+}
+
static void __init iort_init_platform_devices(void)
{
struct acpi_iort_node *iort_node, *iort_end;
@@ -1594,11 +1601,34 @@ static void __init iort_init_platform_devices(void)
iort_table->length);
for (i = 0; i < iort->node_count; i++) {
+ struct device *parent = NULL;
+
if (iort_node >= iort_end) {
pr_err("iort node pointer overflows, bad table\n");
return;
}
+ /* Fixme: handle parent declared in IORT after PMCG */
+ if (iort_node->type == ACPI_IORT_NODE_PMCG) {
+ struct acpi_iort_node *iort_assoc_node;
+ struct acpi_iort_pmcg *pmcg;
+ u32 node_reference;
+
+ pmcg = (struct acpi_iort_pmcg *)iort_node->node_data;
+
+ node_reference = pmcg->node_reference;
+ iort_assoc_node = ACPI_ADD_PTR(struct acpi_iort_node, iort,
+ node_reference);
+
+ if (iort_assoc_node->type == ACPI_IORT_NODE_SMMU_V3) {
+ struct fwnode_handle *assoc_fwnode;
+
+ assoc_fwnode = iort_get_fwnode(iort_assoc_node);
+
+ parent = bus_find_device(&platform_bus_type, NULL,
+ assoc_fwnode, iort_fwnode_match);
+ }
+ }
iort_enable_acs(iort_node);
ops = iort_get_dev_cfg(iort_node);
@@ -1609,7 +1639,7 @@ static void __init iort_init_platform_devices(void)
iort_set_fwnode(iort_node, fwnode);
- ret = iort_add_platform_device(iort_node, ops);
+ ret = iort_add_platform_device(iort_node, ops, parent);
if (ret) {
iort_delete_fwnode(iort_node);
acpi_free_fwnode_static(fwnode);
--
2.17.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-09-30 14:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 14:33 [RFC PATCH 0/6] SMMUv3 PMCG IMP DEF event support John Garry
2019-09-30 14:33 ` John Garry [this message]
2019-10-15 2:35 ` [RFC PATCH 1/6] ACPI/IORT: Set PMCG device parent Hanjun Guo
2019-10-15 9:07 ` John Garry
2019-09-30 14:33 ` [RFC PATCH 2/6] iommu/arm-smmu-v3: Record IIDR in arm_smmu_device structure John Garry
2019-09-30 14:33 ` [RFC PATCH 3/6] perf/smmuv3: Retrieve parent SMMUv3 IIDR John Garry
2019-09-30 14:33 ` [RFC PATCH 4/6] perf/smmuv3: Support HiSilicon hip08 (hi1620) IMP DEF events John Garry
2019-09-30 14:33 ` [RFC PATCH 5/6] perf/smmuv3: Match implementation options based on parent SMMU IIDR John Garry
2019-09-30 14:33 ` [RFC PATCH 6/6] ACPI/IORT: Drop code to set the PMCG software-defined model John Garry
2019-10-15 3:06 ` Hanjun Guo
2019-10-15 8:47 ` John Garry
2019-10-15 18:00 ` [RFC PATCH 0/6] SMMUv3 PMCG IMP DEF event support Robin Murphy
2019-10-16 8:47 ` John Garry
2019-10-16 10:51 ` Robin Murphy
2019-10-16 12:07 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1569854031-237636-2-git-send-email-john.garry@huawei.com \
--to=john.garry@huawei.com \
--cc=guohanjun@huawei.com \
--cc=iommu@lists.linux-foundation.org \
--cc=lenb@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=nleeder@codeaurora.org \
--cc=rjw@rjwysocki.net \
--cc=robin.murphy@arm.com \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).