* [PATCH RESEND] iommu/amd: Remove duplicate check of devid
@ 2021-04-09 3:30 Shaokun Zhang
2021-04-15 13:40 ` Joerg Roedel
0 siblings, 1 reply; 2+ messages in thread
From: Shaokun Zhang @ 2021-04-09 3:30 UTC (permalink / raw)
To: iommu; +Cc: Shaokun Zhang, Will Deacon
'devid' has been checked in function check_device, no need to double
check and clean up this.
Cc: Joerg Roedel <joro@8bytes.org>
Cc: Will Deacon <will@kernel.org>
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
---
drivers/iommu/amd/iommu.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
index b4fa94a97446..cd1a85ff2cf4 100644
--- a/drivers/iommu/amd/iommu.c
+++ b/drivers/iommu/amd/iommu.c
@@ -1677,9 +1677,6 @@ static struct iommu_device *amd_iommu_probe_device(struct device *dev)
return ERR_PTR(-ENODEV);
devid = get_device_id(dev);
- if (devid < 0)
- return ERR_PTR(devid);
-
iommu = amd_iommu_rlookup_table[devid];
if (dev_iommu_priv_get(dev))
@@ -1961,16 +1958,12 @@ static void amd_iommu_detach_device(struct iommu_domain *dom,
struct device *dev)
{
struct iommu_dev_data *dev_data = dev_iommu_priv_get(dev);
+ int devid = get_device_id(dev);
struct amd_iommu *iommu;
- int devid;
if (!check_device(dev))
return;
- devid = get_device_id(dev);
- if (devid < 0)
- return;
-
if (dev_data->domain != NULL)
detach_device(dev);
--
2.7.4
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] iommu/amd: Remove duplicate check of devid
2021-04-09 3:30 [PATCH RESEND] iommu/amd: Remove duplicate check of devid Shaokun Zhang
@ 2021-04-15 13:40 ` Joerg Roedel
0 siblings, 0 replies; 2+ messages in thread
From: Joerg Roedel @ 2021-04-15 13:40 UTC (permalink / raw)
To: Shaokun Zhang; +Cc: iommu, Will Deacon
On Fri, Apr 09, 2021 at 11:30:40AM +0800, Shaokun Zhang wrote:
> drivers/iommu/amd/iommu.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
Applied, thanks.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-15 13:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 3:30 [PATCH RESEND] iommu/amd: Remove duplicate check of devid Shaokun Zhang
2021-04-15 13:40 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).