From: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
To: Jean-Philippe Brucker
<jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org>
Cc: zhongmiao-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
okaya-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org,
linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
sudeep.holla-5wv7dgnIgG8@public.gmane.org,
robin.murphy-5wv7dgnIgG8@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH v2 0/7] Add PCI ATS support to Arm SMMUv3
Date: Mon, 15 Apr 2019 14:20:54 +0100 [thread overview]
Message-ID: <20190415132054.GA15023@fuggles.cambridge.arm.com> (raw)
In-Reply-To: <20190409165245.26500-1-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org>
Hi Jean-Philippe,
On Tue, Apr 09, 2019 at 05:52:38PM +0100, Jean-Philippe Brucker wrote:
> This series enables PCI ATS in SMMUv3. Changes since v1 [1]:
>
> * Simplify the SMMU structures (patches 2-4 are new).
>
> * Don't enable ATS for devices that are attached to a bypass domain,
> because in that case a translation request would cause F_BAD_ATS_TREQ.
> Translation requests in that case cause F_BAD_ATS_TREQ. Enable ATS in
> attach_dev() rather than add_device().
>
> * Enable ATS for stage-1 and stage-2 STEs alike. There is no benefit to
> disabling ATS for stage-2 domains.
>
> [1] https://www.spinics.net/lists/arm-kernel/msg714628.html
>
> Jean-Philippe Brucker (7):
> ACPI/IORT: Check ATS capability in root complex nodes
> iommu/arm-smmu-v3: Rename arm_smmu_master_data to arm_smmu_master
> iommu/arm-smmu-v3: Store SteamIDs in master
> iommu/arm-smmu-v3: Add a master->domain pointer
> iommu/arm-smmu-v3: Link domains and devices
> iommu/arm-smmu-v3: Add support for PCI ATS
> iommu/arm-smmu-v3: Disable tagged pointers
Patches 2, 3, 4, 5 and 7 look fine to me. I've left some comments on the
other two.
Cheers,
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
Cc: zhongmiao@hisilicon.com, okaya@kernel.org, rjw@rjwysocki.net,
linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org,
sudeep.holla@arm.com, robin.murphy@arm.com,
linux-arm-kernel@lists.infradead.org, lenb@kernel.org
Subject: Re: [PATCH v2 0/7] Add PCI ATS support to Arm SMMUv3
Date: Mon, 15 Apr 2019 14:20:54 +0100 [thread overview]
Message-ID: <20190415132054.GA15023@fuggles.cambridge.arm.com> (raw)
Message-ID: <20190415132054.Maz6-zKQOY0vOAkEmMataRIWq3JOClDRbBTjOEcXCws@z> (raw)
In-Reply-To: <20190409165245.26500-1-jean-philippe.brucker@arm.com>
Hi Jean-Philippe,
On Tue, Apr 09, 2019 at 05:52:38PM +0100, Jean-Philippe Brucker wrote:
> This series enables PCI ATS in SMMUv3. Changes since v1 [1]:
>
> * Simplify the SMMU structures (patches 2-4 are new).
>
> * Don't enable ATS for devices that are attached to a bypass domain,
> because in that case a translation request would cause F_BAD_ATS_TREQ.
> Translation requests in that case cause F_BAD_ATS_TREQ. Enable ATS in
> attach_dev() rather than add_device().
>
> * Enable ATS for stage-1 and stage-2 STEs alike. There is no benefit to
> disabling ATS for stage-2 domains.
>
> [1] https://www.spinics.net/lists/arm-kernel/msg714628.html
>
> Jean-Philippe Brucker (7):
> ACPI/IORT: Check ATS capability in root complex nodes
> iommu/arm-smmu-v3: Rename arm_smmu_master_data to arm_smmu_master
> iommu/arm-smmu-v3: Store SteamIDs in master
> iommu/arm-smmu-v3: Add a master->domain pointer
> iommu/arm-smmu-v3: Link domains and devices
> iommu/arm-smmu-v3: Add support for PCI ATS
> iommu/arm-smmu-v3: Disable tagged pointers
Patches 2, 3, 4, 5 and 7 look fine to me. I've left some comments on the
other two.
Cheers,
Will
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-04-15 13:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 16:52 [PATCH v2 0/7] Add PCI ATS support to Arm SMMUv3 Jean-Philippe Brucker
2019-04-09 16:52 ` Jean-Philippe Brucker
[not found] ` <20190409165245.26500-1-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org>
2019-04-09 16:52 ` [PATCH v2 1/7] ACPI/IORT: Check ATS capability in root complex nodes Jean-Philippe Brucker
2019-04-09 16:52 ` Jean-Philippe Brucker
[not found] ` <20190409165245.26500-2-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org>
2019-04-15 13:21 ` Will Deacon
2019-04-15 13:21 ` Will Deacon
[not found] ` <20190415132108.GB15023-UDVVEH7NWB15pKCnmE3YQBJ8xKzm50AiAL8bYrjMMd8@public.gmane.org>
2019-04-15 18:00 ` Jean-Philippe Brucker
2019-04-15 18:00 ` Jean-Philippe Brucker
2019-04-15 18:31 ` Robin Murphy
2019-04-15 18:31 ` Robin Murphy
[not found] ` <c10c7adb-c7f6-f8c6-05cc-f4f143427a2d-5wv7dgnIgG8@public.gmane.org>
2019-04-16 16:27 ` Jean-Philippe Brucker
2019-04-16 16:27 ` Jean-Philippe Brucker
2019-04-09 16:52 ` [PATCH v2 2/7] iommu/arm-smmu-v3: Rename arm_smmu_master_data to arm_smmu_master Jean-Philippe Brucker
2019-04-09 16:52 ` Jean-Philippe Brucker
2019-04-09 16:52 ` [PATCH v2 3/7] iommu/arm-smmu-v3: Store SteamIDs in master Jean-Philippe Brucker
2019-04-09 16:52 ` Jean-Philippe Brucker
2019-04-09 16:52 ` [PATCH v2 4/7] iommu/arm-smmu-v3: Add a master->domain pointer Jean-Philippe Brucker
2019-04-09 16:52 ` Jean-Philippe Brucker
2019-04-09 16:52 ` [PATCH v2 5/7] iommu/arm-smmu-v3: Link domains and devices Jean-Philippe Brucker
2019-04-09 16:52 ` Jean-Philippe Brucker
2019-04-09 16:52 ` [PATCH v2 6/7] iommu/arm-smmu-v3: Add support for PCI ATS Jean-Philippe Brucker
2019-04-09 16:52 ` Jean-Philippe Brucker
[not found] ` <20190409165245.26500-7-jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org>
2019-04-15 13:21 ` Will Deacon
2019-04-15 13:21 ` Will Deacon
[not found] ` <20190415132121.GC15023-UDVVEH7NWB15pKCnmE3YQBJ8xKzm50AiAL8bYrjMMd8@public.gmane.org>
2019-04-15 18:00 ` Jean-Philippe Brucker
2019-04-15 18:00 ` Jean-Philippe Brucker
[not found] ` <0b9b600f-60e0-0740-e1db-6b684bf5a195-5wv7dgnIgG8@public.gmane.org>
2019-04-16 10:00 ` Will Deacon
2019-04-16 10:00 ` Will Deacon
2019-04-09 16:52 ` [PATCH v2 7/7] iommu/arm-smmu-v3: Disable tagged pointers Jean-Philippe Brucker
2019-04-09 16:52 ` Jean-Philippe Brucker
2019-04-15 13:20 ` Will Deacon [this message]
2019-04-15 13:20 ` [PATCH v2 0/7] Add PCI ATS support to Arm SMMUv3 Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415132054.GA15023@fuggles.cambridge.arm.com \
--to=will.deacon-5wv7dgnigg8@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org \
--cc=lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=okaya-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org \
--cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \
--cc=sudeep.holla-5wv7dgnIgG8@public.gmane.org \
--cc=zhongmiao-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).