* [PATCH v3 0/8] Replace strncmp with str_has_prefix
@ 2019-08-05 12:22 Chuhong Yuan
0 siblings, 0 replies; only message in thread
From: Chuhong Yuan @ 2019-08-05 12:22 UTC (permalink / raw)
Cc: Len Brown, Petr Mladek, Peter Zijlstra, Chuhong Yuan, linux-pm,
Rafael J . Wysocki, linux-kernel, Steven Rostedt,
Sergey Senozhatsky, iommu, Ingo Molnar, Pavel Machek, Jessica Yu,
Joe Perches, Robin Murphy, Christoph Hellwig
The commit 72921427d46b
("string.h: Add str_has_prefix() helper function")
introduced str_has_prefix() to substitute error-prone
strncmp(str, const, len).
strncmp(str, const, len) is easy to have error in len
because of counting error or sizeof(const) without - 1.
These patches replace such pattern with str_has_prefix()
to avoid hard coded constant length and sizeof.
Besides, str_has_prefix() returns the length of prefix
when the comparison returns true.
We can use this return value to substitute some hard-coding.
Changelog:
v1 -> v2:
- Revise the description.
- Use the return value of str_has_prefix() to eliminate
hard coding.
- Remove possible false positives and add newly detected
one in upstream.
v2 -> v3:
- Revise the description.
- Remove else uses in printk.c.
Chuhong Yuan (8):
dma: debug: Replace strncmp with str_has_prefix
module: Replace strncmp with str_has_prefix
PM/sleep: Replace strncmp with str_has_prefix
printk: Replace strncmp with str_has_prefix
reboot: Replace strncmp with str_has_prefix
sched: Replace strncmp with str_has_prefix
userns: Replace strncmp with str_has_prefix
watchdog: Replace strncmp with str_has_prefix
kernel/dma/debug.c | 2 +-
kernel/module.c | 2 +-
kernel/power/main.c | 2 +-
kernel/printk/braille.c | 10 ++++++----
kernel/printk/printk.c | 19 +++++++++++++------
kernel/reboot.c | 6 ++++--
kernel/sched/debug.c | 5 +++--
kernel/sched/isolation.c | 9 +++++----
kernel/user_namespace.c | 10 +++++-----
kernel/watchdog.c | 8 ++++----
10 files changed, 43 insertions(+), 30 deletions(-)
--
2.20.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-08-05 12:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-05 12:22 [PATCH v3 0/8] Replace strncmp with str_has_prefix Chuhong Yuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).