From: Will Deacon <will@kernel.org>
To: Qian Cai <cai@lca.pw>
Cc: iommu@lists.linux-foundation.org, Joerg Roedel <jroedel@suse.de>,
Robin Murphy <robin.murphy@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: "Rework enabling/disabling of ATS for PCI masters" failed to compile on arm64
Date: Tue, 3 Sep 2019 07:40:51 +0100 [thread overview]
Message-ID: <20190903064050.zsmaum4gajqjdivv@willie-the-truck> (raw)
In-Reply-To: <63FF6963-E1D9-4C65-AD2E-0E4938D08584@lca.pw>
On Mon, Sep 02, 2019 at 10:10:30PM -0400, Qian Cai wrote:
> The linux-next commit “iommu/arm-smmu-v3: Rework enabling/disabling of ATS for PCI masters” [1] causes a compilation error when PCI_ATS=n on arm64.
>
> [1] https://lore.kernel.org/linux-iommu/20190820154549.17018-3-will@kernel.org/
>
> drivers/iommu/arm-smmu-v3.c:2325:35: error: no member named 'ats_cap' in 'struct pci_dev'
> return !pdev->untrusted && pdev->ats_cap;
> ~~~~ ^
>
> For example,
>
> Symbol: PCI_ATS [=n]
> │ Type : bool
> │ Defined at drivers/pci/Kconfig:118
> │ Depends on: PCI [=y]
> │ Selected by [n]:
> │ - PCI_IOV [=n] && PCI [=y]
> │ - PCI_PRI [=n] && PCI [=y]│
> │ - PCI_PASID [=n] && PCI [=y] │
> │ - AMD_IOMMU [=n] && IOMMU_SUPPORT [=y] && X86_64 && PCI [=y] && ACPI [=y]
https://lkml.kernel.org/r/20190903063028.6ryuk5dmaohi2fqa@willie-the-truck
Will
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
prev parent reply other threads:[~2019-09-03 6:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 2:10 "Rework enabling/disabling of ATS for PCI masters" failed to compile on arm64 Qian Cai
2019-09-03 6:40 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903064050.zsmaum4gajqjdivv@willie-the-truck \
--to=will@kernel.org \
--cc=cai@lca.pw \
--cc=iommu@lists.linux-foundation.org \
--cc=jroedel@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).