* [PATCH] iommu/ipmmu-vmsa: Only call platform_get_irq() when interrupt is mandatory
@ 2019-10-01 18:06 Geert Uytterhoeven
2019-10-02 4:49 ` Yoshihiro Shimoda
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2019-10-01 18:06 UTC (permalink / raw)
To: Joerg Roedel
Cc: Geert Uytterhoeven, Greg Kroah-Hartman, linux-kernel,
Stephen Boyd, linux-renesas-soc, iommu
As platform_get_irq() now prints an error when the interrupt does not
exist, calling it gratuitously causes scary messages like:
ipmmu-vmsa e6740000.mmu: IRQ index 0 not found
Fix this by moving the call to platform_get_irq() down, where the
existence of the interrupt is mandatory.
Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to platform_get_irq*()")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
This is a fix for v5.4-rc1.
---
drivers/iommu/ipmmu-vmsa.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c
index 9da8309f71708f21..237103465b824c51 100644
--- a/drivers/iommu/ipmmu-vmsa.c
+++ b/drivers/iommu/ipmmu-vmsa.c
@@ -1086,8 +1086,6 @@ static int ipmmu_probe(struct platform_device *pdev)
mmu->num_ctx = min(IPMMU_CTX_MAX, mmu->features->number_of_contexts);
- irq = platform_get_irq(pdev, 0);
-
/*
* Determine if this IPMMU instance is a root device by checking for
* the lack of has_cache_leaf_nodes flag or renesas,ipmmu-main property.
@@ -1106,6 +1104,7 @@ static int ipmmu_probe(struct platform_device *pdev)
/* Root devices have mandatory IRQs */
if (ipmmu_is_root(mmu)) {
+ irq = platform_get_irq(pdev, 0);
if (irq < 0) {
dev_err(&pdev->dev, "no IRQ found\n");
return irq;
--
2.17.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] iommu/ipmmu-vmsa: Only call platform_get_irq() when interrupt is mandatory
2019-10-01 18:06 [PATCH] iommu/ipmmu-vmsa: Only call platform_get_irq() when interrupt is mandatory Geert Uytterhoeven
@ 2019-10-02 4:49 ` Yoshihiro Shimoda
2019-10-03 16:11 ` Stephen Boyd
2019-10-15 11:02 ` Joerg Roedel
2 siblings, 0 replies; 4+ messages in thread
From: Yoshihiro Shimoda @ 2019-10-02 4:49 UTC (permalink / raw)
To: Geert Uytterhoeven, Joerg Roedel
Cc: linux-renesas-soc, Greg Kroah-Hartman, iommu, linux-kernel, Stephen Boyd
Hi Geert-san,
> From: Geert Uytterhoeven, Sent: Wednesday, October 2, 2019 3:06 AM
>
> As platform_get_irq() now prints an error when the interrupt does not
> exist, calling it gratuitously causes scary messages like:
>
> ipmmu-vmsa e6740000.mmu: IRQ index 0 not found
>
> Fix this by moving the call to platform_get_irq() down, where the
> existence of the interrupt is mandatory.
>
> Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to platform_get_irq*()")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> This is a fix for v5.4-rc1.
> ---
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
And, I tested this patch on R-Car H3. So,
Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iommu/ipmmu-vmsa: Only call platform_get_irq() when interrupt is mandatory
2019-10-01 18:06 [PATCH] iommu/ipmmu-vmsa: Only call platform_get_irq() when interrupt is mandatory Geert Uytterhoeven
2019-10-02 4:49 ` Yoshihiro Shimoda
@ 2019-10-03 16:11 ` Stephen Boyd
2019-10-15 11:02 ` Joerg Roedel
2 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2019-10-03 16:11 UTC (permalink / raw)
To: Geert Uytterhoeven, Joerg Roedel
Cc: linux-renesas-soc, Greg Kroah-Hartman, iommu, linux-kernel,
Geert Uytterhoeven
Quoting Geert Uytterhoeven (2019-10-01 11:06:22)
> As platform_get_irq() now prints an error when the interrupt does not
> exist, calling it gratuitously causes scary messages like:
>
> ipmmu-vmsa e6740000.mmu: IRQ index 0 not found
>
> Fix this by moving the call to platform_get_irq() down, where the
> existence of the interrupt is mandatory.
>
> Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to platform_get_irq*()")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iommu/ipmmu-vmsa: Only call platform_get_irq() when interrupt is mandatory
2019-10-01 18:06 [PATCH] iommu/ipmmu-vmsa: Only call platform_get_irq() when interrupt is mandatory Geert Uytterhoeven
2019-10-02 4:49 ` Yoshihiro Shimoda
2019-10-03 16:11 ` Stephen Boyd
@ 2019-10-15 11:02 ` Joerg Roedel
2 siblings, 0 replies; 4+ messages in thread
From: Joerg Roedel @ 2019-10-15 11:02 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: linux-renesas-soc, Greg Kroah-Hartman, iommu, linux-kernel, Stephen Boyd
On Tue, Oct 01, 2019 at 08:06:22PM +0200, Geert Uytterhoeven wrote:
> As platform_get_irq() now prints an error when the interrupt does not
> exist, calling it gratuitously causes scary messages like:
>
> ipmmu-vmsa e6740000.mmu: IRQ index 0 not found
>
> Fix this by moving the call to platform_get_irq() down, where the
> existence of the interrupt is mandatory.
>
> Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to platform_get_irq*()")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> This is a fix for v5.4-rc1.
> ---
> drivers/iommu/ipmmu-vmsa.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied for v5.4
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-15 11:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-01 18:06 [PATCH] iommu/ipmmu-vmsa: Only call platform_get_irq() when interrupt is mandatory Geert Uytterhoeven
2019-10-02 4:49 ` Yoshihiro Shimoda
2019-10-03 16:11 ` Stephen Boyd
2019-10-15 11:02 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).