IOMMU Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] iommu/omap: Add registration for DT fwnode pointer
@ 2020-04-24 14:58 Tero Kristo via iommu
  2020-05-18 12:11 ` Tero Kristo via iommu
  2020-05-18 13:40 ` Joerg Roedel
  0 siblings, 2 replies; 3+ messages in thread
From: Tero Kristo via iommu @ 2020-04-24 14:58 UTC (permalink / raw)
  To: iommu, joro

The fwnode pointer must be passed to the iommu core, so that the core
can map the IOMMU towards device requests properly. Without this, some
IOMMU clients like OMAP remoteproc will fail the iommu configuration
multiple times with -EPROBE_DEFER, which will eventually be ignored with
a kernel warning banner.

Signed-off-by: Tero Kristo <t-kristo@ti.com>
---
 drivers/iommu/omap-iommu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
index 887fefcb03b4..934726e20b72 100644
--- a/drivers/iommu/omap-iommu.c
+++ b/drivers/iommu/omap-iommu.c
@@ -1248,6 +1248,7 @@ static int omap_iommu_probe(struct platform_device *pdev)
 			goto out_group;
 
 		iommu_device_set_ops(&obj->iommu, &omap_iommu_ops);
+		iommu_device_set_fwnode(&obj->iommu, &of->fwnode);
 
 		err = iommu_device_register(&obj->iommu);
 		if (err)
-- 
2.17.1

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iommu/omap: Add registration for DT fwnode pointer
  2020-04-24 14:58 [PATCH] iommu/omap: Add registration for DT fwnode pointer Tero Kristo via iommu
@ 2020-05-18 12:11 ` Tero Kristo via iommu
  2020-05-18 13:40 ` Joerg Roedel
  1 sibling, 0 replies; 3+ messages in thread
From: Tero Kristo via iommu @ 2020-05-18 12:11 UTC (permalink / raw)
  To: Tero Kristo, iommu, joro

On 24/04/2020 17:58, Tero Kristo via iommu wrote:
> The fwnode pointer must be passed to the iommu core, so that the core
> can map the IOMMU towards device requests properly. Without this, some
> IOMMU clients like OMAP remoteproc will fail the iommu configuration
> multiple times with -EPROBE_DEFER, which will eventually be ignored with
> a kernel warning banner.
> 
> Signed-off-by: Tero Kristo <t-kristo@ti.com>

Hi Joerg,

I noticed this is still missing from next but there are some other OMAP 
iommu patches queued up (see the bug fix I just posted against -next.)

Whats the plan with this one?

-Tero

> ---
>   drivers/iommu/omap-iommu.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
> index 887fefcb03b4..934726e20b72 100644
> --- a/drivers/iommu/omap-iommu.c
> +++ b/drivers/iommu/omap-iommu.c
> @@ -1248,6 +1248,7 @@ static int omap_iommu_probe(struct platform_device *pdev)
>   			goto out_group;
>   
>   		iommu_device_set_ops(&obj->iommu, &omap_iommu_ops);
> +		iommu_device_set_fwnode(&obj->iommu, &of->fwnode);
>   
>   		err = iommu_device_register(&obj->iommu);
>   		if (err)
> 

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iommu/omap: Add registration for DT fwnode pointer
  2020-04-24 14:58 [PATCH] iommu/omap: Add registration for DT fwnode pointer Tero Kristo via iommu
  2020-05-18 12:11 ` Tero Kristo via iommu
@ 2020-05-18 13:40 ` Joerg Roedel
  1 sibling, 0 replies; 3+ messages in thread
From: Joerg Roedel @ 2020-05-18 13:40 UTC (permalink / raw)
  To: Tero Kristo; +Cc: iommu

On Fri, Apr 24, 2020 at 05:58:28PM +0300, Tero Kristo wrote:
> The fwnode pointer must be passed to the iommu core, so that the core
> can map the IOMMU towards device requests properly. Without this, some
> IOMMU clients like OMAP remoteproc will fail the iommu configuration
> multiple times with -EPROBE_DEFER, which will eventually be ignored with
> a kernel warning banner.
> 
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> ---
>  drivers/iommu/omap-iommu.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-24 14:58 [PATCH] iommu/omap: Add registration for DT fwnode pointer Tero Kristo via iommu
2020-05-18 12:11 ` Tero Kristo via iommu
2020-05-18 13:40 ` Joerg Roedel

IOMMU Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iommu/0 linux-iommu/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iommu linux-iommu/ https://lore.kernel.org/linux-iommu \
		iommu@lists.linux-foundation.org
	public-inbox-index linux-iommu

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linux-foundation.lists.iommu


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git