From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux IOMMU <iommu@lists.linux-foundation.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
David Rientjes <rientjes@google.com>,
Christoph Hellwig <hch@lst.de>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v2] dma-pool: Fix too large DMA pools on medium systems
Date: Mon, 22 Jun 2020 19:31:46 +0200 [thread overview]
Message-ID: <20200622173146.GA15796@lst.de> (raw)
In-Reply-To: <1287bffd-3363-0764-0309-32222b2b8c9a@arm.com>
On Mon, Jun 22, 2020 at 05:07:55PM +0100, Robin Murphy wrote:
> Another angle, though, is to question why this driver is making such a
> large allocation with GFP_ATOMIC in the first place. At a glance it looks
> like there's no reason at all other than that it's still using the legacy
> pci_alloc_consistent() API, since every path to that appears to have
> CAN_SLEEP passed as its flag - modernising that would arguably be an even
> better long-term win.
Maybe we can just try that for now? If other problems show up we
can still increase the initial pool size later in this cycle.
I'll try to cook up a patch.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-06-22 17:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 13:22 [PATCH v2] dma-pool: Fix too large DMA pools on medium systems Geert Uytterhoeven
2020-06-08 21:04 ` David Rientjes via iommu
2020-06-09 13:26 ` Christoph Hellwig
2020-06-20 20:09 ` Guenter Roeck
2020-06-21 8:35 ` Geert Uytterhoeven
2020-06-21 13:11 ` Guenter Roeck
2020-06-21 20:20 ` David Rientjes via iommu
2020-06-22 16:07 ` Robin Murphy
2020-06-22 17:31 ` Christoph Hellwig [this message]
2020-06-24 7:38 ` Christoph Hellwig
2020-06-24 16:20 ` Guenter Roeck
2020-06-27 16:13 ` Marion & Christophe JAILLET
2020-06-29 8:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622173146.GA15796@lst.de \
--to=hch@lst.de \
--cc=geert@linux-m68k.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rientjes@google.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).