iommu.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Amit Pundir <amit.pundir@linaro.org>
Cc: jeremy.linton@arm.com, iommu@lists.linux-foundation.org,
	linux-rpi-kernel@lists.infradead.org,
	David Rientjes <rientjes@google.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: dma-pool fixes
Date: Tue, 28 Jul 2020 14:07:16 +0200	[thread overview]
Message-ID: <20200728120716.GA2507@lst.de> (raw)
In-Reply-To: <CAMi1Hd3=6ZZykF1yx_CChqx71k6T-wj12TzJiz_uJZbwrEtTXw@mail.gmail.com>

On Tue, Jul 28, 2020 at 05:32:56PM +0530, Amit Pundir wrote:
> > can you try these two patches?  The first one makes sure we don't apply
> > physical address based checks for IOMMU allocations, and the second one
> > is a slightly tweaked version of the patch from Nicolas to allow dipping
> > into the CMA areas for allocations to expand the atomic pools.
> 
> Sorry, verified a couple of times but these two patches are not working
> for me. I'm stuck at the bootloader splash screen on my phone.

Thanks for testing.  The only intended functional change compared to
Fridays patch was the issue Nicolas pointed out.  Can you try this hack
on top?


diff --git a/kernel/dma/pool.c b/kernel/dma/pool.c
index 83fda10394937b..88e40a022b6bfd 100644
--- a/kernel/dma/pool.c
+++ b/kernel/dma/pool.c
@@ -70,13 +70,14 @@ static bool cma_in_zone(gfp_t gfp)
 	size = cma_get_size(cma);
 	if (!size)
 		return false;
-
+#if 0
 	/* CMA can't cross zone boundaries, see cma_activate_area() */
 	end = cma_get_base(cma) - memblock_start_of_DRAM() + size - 1;
 	if (IS_ENABLED(CONFIG_ZONE_DMA) && (gfp & GFP_DMA))
 		return end <= DMA_BIT_MASK(zone_dma_bits);
 	if (IS_ENABLED(CONFIG_ZONE_DMA32) && (gfp & GFP_DMA32))
 		return end <= DMA_BIT_MASK(32);
+#endif
 	return true;
 }
 
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

  reply	other threads:[~2020-07-28 12:07 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-28 10:47 dma-pool fixes Christoph Hellwig
2020-07-28 10:47 ` [PATCH 1/2] dma-pool: fix coherent pool allocations for IOMMU mappings Christoph Hellwig
2020-07-28 14:56   ` Nicolas Saenz Julienne
2020-07-28 15:28     ` Christoph Hellwig
2020-07-28 10:47 ` [PATCH 2/2] dma-pool: Only allocate from CMA when in same memory zone Christoph Hellwig
2020-07-28 12:02 ` dma-pool fixes Amit Pundir
2020-07-28 12:07   ` Christoph Hellwig [this message]
2020-07-28 12:25     ` Amit Pundir
2020-07-28 12:41       ` Christoph Hellwig
2020-07-28 12:48         ` Amit Pundir
2020-07-28 15:30           ` Christoph Hellwig
2020-07-29 10:45             ` Nicolas Saenz Julienne
2020-07-29 12:22               ` Amit Pundir
2020-07-31  7:46                 ` Amit Pundir
2020-07-31 13:09                   ` Christoph Hellwig
2020-07-31 14:15                     ` Amit Pundir
2020-07-31 19:04                     ` David Rientjes via iommu
2020-08-01  8:20                       ` David Rientjes via iommu
2020-08-01  8:57                         ` revert scope for 5.8, was " Christoph Hellwig
2020-08-01 11:57                           ` Amit Pundir
2020-08-01 16:59                             ` Nicolas Saenz Julienne
2020-08-01 17:39                             ` Christoph Hellwig
2020-08-02  4:46                               ` Amit Pundir
2020-08-02 15:04                                 ` Amit Pundir
2020-08-03  4:14                                   ` David Rientjes via iommu
2020-08-03  6:44                                     ` Christoph Hellwig
2020-08-03 18:30                                       ` David Rientjes via iommu
2020-08-01 18:28                             ` Linus Torvalds
2020-08-02  4:35                               ` Amit Pundir
2020-08-01  8:29                       ` Christoph Hellwig
2020-07-31 10:47                 ` Nicolas Saenz Julienne
2020-07-31 11:17                   ` Amit Pundir
2020-07-31 14:15                     ` Nicolas Saenz Julienne
2020-07-31 14:20                       ` Amit Pundir
2020-08-01  7:34                         ` Amit Pundir

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200728120716.GA2507@lst.de \
    --to=hch@lst.de \
    --cc=amit.pundir@linaro.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jeremy.linton@arm.com \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=rientjes@google.com \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).