* [RESEND PATCH 2/5] iommu: amd: Add missing function prototypes to fix -Wmissing-prototypes
2020-08-19 17:53 [RESEND PATCH 1/5] iommu: mtk: Drop of_match_ptr to fix -Wunused-const-variable Krzysztof Kozlowski
@ 2020-08-19 17:53 ` Krzysztof Kozlowski
2020-08-19 17:53 ` [RESEND PATCH 3/5] iommu: amd: Fix kerneldoc Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-19 17:53 UTC (permalink / raw)
To: Joerg Roedel, Will Deacon, Robin Murphy, David Woodhouse,
Lu Baolu, Matthias Brugger, Bjorn Andersson, Gustavo A. R. Silva,
Krzysztof Kozlowski, iommu, linux-kernel, linux-arm-kernel,
linux-mediatek
Few exported functions from AMD IOMMU driver are missing prototypes.
They have declaration in arch/x86/events/amd/iommu.h but this file
cannot be included in the driver. Add prototypes to fix W=1 warnings
like:
drivers/iommu/amd/init.c:3066:19: warning:
no previous prototype for 'get_amd_iommu' [-Wmissing-prototypes]
3066 | struct amd_iommu *get_amd_iommu(unsigned int idx)
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/iommu/amd/amd_iommu.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/iommu/amd/amd_iommu.h b/drivers/iommu/amd/amd_iommu.h
index 57309716fd18..0781b7112467 100644
--- a/drivers/iommu/amd/amd_iommu.h
+++ b/drivers/iommu/amd/amd_iommu.h
@@ -41,6 +41,15 @@ extern int amd_iommu_guest_ir;
struct iommu_domain;
extern bool amd_iommu_v2_supported(void);
+extern struct amd_iommu *get_amd_iommu(unsigned int idx);
+extern u8 amd_iommu_pc_get_max_banks(unsigned int idx);
+extern bool amd_iommu_pc_supported(void);
+extern u8 amd_iommu_pc_get_max_counters(unsigned int idx);
+extern int amd_iommu_pc_get_reg(struct amd_iommu *iommu, u8 bank, u8 cntr,
+ u8 fxn, u64 *value);
+extern int amd_iommu_pc_set_reg(struct amd_iommu *iommu, u8 bank, u8 cntr,
+ u8 fxn, u64 *value);
+
extern int amd_iommu_register_ppr_notifier(struct notifier_block *nb);
extern int amd_iommu_unregister_ppr_notifier(struct notifier_block *nb);
extern void amd_iommu_domain_direct_map(struct iommu_domain *dom);
--
2.17.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 6+ messages in thread* [RESEND PATCH 3/5] iommu: amd: Fix kerneldoc
2020-08-19 17:53 [RESEND PATCH 1/5] iommu: mtk: Drop of_match_ptr to fix -Wunused-const-variable Krzysztof Kozlowski
2020-08-19 17:53 ` [RESEND PATCH 2/5] iommu: amd: Add missing function prototypes to fix -Wmissing-prototypes Krzysztof Kozlowski
@ 2020-08-19 17:53 ` Krzysztof Kozlowski
2020-08-19 17:53 ` [RESEND PATCH 4/5] iommu: intel: Drop kerneldoc marker from regular comment Krzysztof Kozlowski
2020-08-19 17:53 ` [RESEND PATCH 5/5] iommu: qcom: Drop of_match_ptr to fix -Wunused-const-variable Krzysztof Kozlowski
3 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-19 17:53 UTC (permalink / raw)
To: Joerg Roedel, Will Deacon, Robin Murphy, David Woodhouse,
Lu Baolu, Matthias Brugger, Bjorn Andersson, Gustavo A. R. Silva,
Krzysztof Kozlowski, iommu, linux-kernel, linux-arm-kernel,
linux-mediatek
Fix W=1 compile warnings (invalid kerneldoc):
drivers/iommu/amd/init.c:1586: warning: Function parameter or member 'ivrs' not described in 'get_highest_supported_ivhd_type'
drivers/iommu/amd/init.c:1938: warning: Function parameter or member 'iommu' not described in 'iommu_update_intcapxt'
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/iommu/amd/init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
index c652f16eb702..908d8e89764c 100644
--- a/drivers/iommu/amd/init.c
+++ b/drivers/iommu/amd/init.c
@@ -1578,7 +1578,7 @@ static int __init init_iommu_one(struct amd_iommu *iommu, struct ivhd_header *h)
/**
* get_highest_supported_ivhd_type - Look up the appropriate IVHD type
- * @ivrs Pointer to the IVRS header
+ * @ivrs: Pointer to the IVRS header
*
* This function search through all IVDB of the maximum supported IVHD
*/
@@ -1929,7 +1929,7 @@ static int iommu_setup_msi(struct amd_iommu *iommu)
#define XT_INT_VEC(x) (((x) & 0xFFULL) << 32)
#define XT_INT_DEST_HI(x) ((((x) >> 24) & 0xFFULL) << 56)
-/**
+/*
* Setup the IntCapXT registers with interrupt routing information
* based on the PCI MSI capability block registers, accessed via
* MMIO MSI address low/hi and MSI data registers.
--
2.17.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 6+ messages in thread* [RESEND PATCH 4/5] iommu: intel: Drop kerneldoc marker from regular comment
2020-08-19 17:53 [RESEND PATCH 1/5] iommu: mtk: Drop of_match_ptr to fix -Wunused-const-variable Krzysztof Kozlowski
2020-08-19 17:53 ` [RESEND PATCH 2/5] iommu: amd: Add missing function prototypes to fix -Wmissing-prototypes Krzysztof Kozlowski
2020-08-19 17:53 ` [RESEND PATCH 3/5] iommu: amd: Fix kerneldoc Krzysztof Kozlowski
@ 2020-08-19 17:53 ` Krzysztof Kozlowski
2020-08-24 2:43 ` Lu Baolu
2020-08-19 17:53 ` [RESEND PATCH 5/5] iommu: qcom: Drop of_match_ptr to fix -Wunused-const-variable Krzysztof Kozlowski
3 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-19 17:53 UTC (permalink / raw)
To: Joerg Roedel, Will Deacon, Robin Murphy, David Woodhouse,
Lu Baolu, Matthias Brugger, Bjorn Andersson, Gustavo A. R. Silva,
Krzysztof Kozlowski, iommu, linux-kernel, linux-arm-kernel,
linux-mediatek
Fix W=1 compile warnings (invalid kerneldoc):
drivers/iommu/intel/dmar.c:389: warning: Function parameter or member 'header' not described in 'dmar_parse_one_drhd'
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/iommu/intel/dmar.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/intel/dmar.c b/drivers/iommu/intel/dmar.c
index 93e6345f3414..ba47edf03941 100644
--- a/drivers/iommu/intel/dmar.c
+++ b/drivers/iommu/intel/dmar.c
@@ -380,7 +380,7 @@ dmar_find_dmaru(struct acpi_dmar_hardware_unit *drhd)
return NULL;
}
-/**
+/*
* dmar_parse_one_drhd - parses exactly one DMA remapping hardware definition
* structure which uniquely represent one DMA remapping hardware unit
* present in the platform
--
2.17.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [RESEND PATCH 4/5] iommu: intel: Drop kerneldoc marker from regular comment
2020-08-19 17:53 ` [RESEND PATCH 4/5] iommu: intel: Drop kerneldoc marker from regular comment Krzysztof Kozlowski
@ 2020-08-24 2:43 ` Lu Baolu
0 siblings, 0 replies; 6+ messages in thread
From: Lu Baolu @ 2020-08-24 2:43 UTC (permalink / raw)
To: Krzysztof Kozlowski, Joerg Roedel, Will Deacon, Robin Murphy,
David Woodhouse, Matthias Brugger, Bjorn Andersson,
Gustavo A. R. Silva, iommu, linux-kernel, linux-arm-kernel,
linux-mediatek
Hi,
On 8/20/20 1:53 AM, Krzysztof Kozlowski wrote:
> Fix W=1 compile warnings (invalid kerneldoc):
>
> drivers/iommu/intel/dmar.c:389: warning: Function parameter or member 'header' not described in 'dmar_parse_one_drhd'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Adjust the commit title to "iommu/vt-d: Drop kerneldoc marker from
regular comment",
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Best regards,
baolu
> ---
> drivers/iommu/intel/dmar.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/intel/dmar.c b/drivers/iommu/intel/dmar.c
> index 93e6345f3414..ba47edf03941 100644
> --- a/drivers/iommu/intel/dmar.c
> +++ b/drivers/iommu/intel/dmar.c
> @@ -380,7 +380,7 @@ dmar_find_dmaru(struct acpi_dmar_hardware_unit *drhd)
> return NULL;
> }
>
> -/**
> +/*
> * dmar_parse_one_drhd - parses exactly one DMA remapping hardware definition
> * structure which uniquely represent one DMA remapping hardware unit
> * present in the platform
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RESEND PATCH 5/5] iommu: qcom: Drop of_match_ptr to fix -Wunused-const-variable
2020-08-19 17:53 [RESEND PATCH 1/5] iommu: mtk: Drop of_match_ptr to fix -Wunused-const-variable Krzysztof Kozlowski
` (2 preceding siblings ...)
2020-08-19 17:53 ` [RESEND PATCH 4/5] iommu: intel: Drop kerneldoc marker from regular comment Krzysztof Kozlowski
@ 2020-08-19 17:53 ` Krzysztof Kozlowski
3 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-08-19 17:53 UTC (permalink / raw)
To: Joerg Roedel, Will Deacon, Robin Murphy, David Woodhouse,
Lu Baolu, Matthias Brugger, Bjorn Andersson, Gustavo A. R. Silva,
Krzysztof Kozlowski, iommu, linux-kernel, linux-arm-kernel,
linux-mediatek
The of_device_id is included unconditionally by of.h header and used
in the driver as well. Remove of_match_ptr to fix W=1 compile test
warning with !CONFIG_OF:
drivers/iommu/qcom_iommu.c:910:34: warning: 'qcom_iommu_of_match' defined but not used [-Wunused-const-variable=]
910 | static const struct of_device_id qcom_iommu_of_match[] = {
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/iommu/arm/arm-smmu/qcom_iommu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iommu/arm/arm-smmu/qcom_iommu.c b/drivers/iommu/arm/arm-smmu/qcom_iommu.c
index af6bec3ace00..9535a6af7553 100644
--- a/drivers/iommu/arm/arm-smmu/qcom_iommu.c
+++ b/drivers/iommu/arm/arm-smmu/qcom_iommu.c
@@ -752,7 +752,7 @@ static const struct of_device_id ctx_of_match[] = {
static struct platform_driver qcom_iommu_ctx_driver = {
.driver = {
.name = "qcom-iommu-ctx",
- .of_match_table = of_match_ptr(ctx_of_match),
+ .of_match_table = ctx_of_match,
},
.probe = qcom_iommu_ctx_probe,
.remove = qcom_iommu_ctx_remove,
@@ -915,7 +915,7 @@ static const struct of_device_id qcom_iommu_of_match[] = {
static struct platform_driver qcom_iommu_driver = {
.driver = {
.name = "qcom-iommu",
- .of_match_table = of_match_ptr(qcom_iommu_of_match),
+ .of_match_table = qcom_iommu_of_match,
.pm = &qcom_iommu_pm_ops,
},
.probe = qcom_iommu_device_probe,
--
2.17.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 6+ messages in thread