From: Baolu Lu <baolu.lu@linux.intel.com> To: "Tian, Kevin" <kevin.tian@intel.com>, Joerg Roedel <joro@8bytes.org>, Jason Gunthorpe <jgg@nvidia.com>, Christoph Hellwig <hch@infradead.org>, "Raj, Ashok" <ashok.raj@intel.com>, Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, Jean-Philippe Brucker <jean-philippe@linaro.com>, "Jiang, Dave" <dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org> Cc: "iommu@lists.linux.dev" <iommu@lists.linux.dev>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>, "Pan, Jacob jun" <jacob.jun.pan@intel.com> Subject: Re: [PATCH v9 07/11] iommu/sva: Refactoring iommu_sva_bind/unbind_device() Date: Tue, 28 Jun 2022 13:53:35 +0800 [thread overview] Message-ID: <543603e3-9d08-59ee-01f2-8dd6e7c73a15@linux.intel.com> (raw) In-Reply-To: <BN9PR11MB5276297FAEB8C9774AABAD208CB99@BN9PR11MB5276.namprd11.prod.outlook.com> On 2022/6/27 18:14, Tian, Kevin wrote: >> From: Lu Baolu <baolu.lu@linux.intel.com> >> Sent: Tuesday, June 21, 2022 10:44 PM >> +struct iommu_sva *iommu_sva_bind_device(struct device *dev, struct >> mm_struct *mm) >> +{ >> + struct iommu_domain *domain; >> + ioasid_t max_pasids; >> + int ret = -EINVAL; >> + >> + /* Allocate mm->pasid if necessary. */ > > this comment is for iommu_sva_alloc_pasid() Updated. > >> + max_pasids = dev->iommu->max_pasids; >> + if (!max_pasids) >> + return ERR_PTR(-EOPNOTSUPP); >> + >> + ret = iommu_sva_alloc_pasid(mm, 1, max_pasids - 1); >> + if (ret) >> + return ERR_PTR(ret); >> + > > > ... >> +void iommu_sva_unbind_device(struct iommu_sva *handle) >> +{ >> + struct device *dev = handle->dev; >> + struct iommu_domain *domain = >> + container_of(handle, struct iommu_domain, bond); >> + ioasid_t pasid = iommu_sva_get_pasid(handle); >> + >> + mutex_lock(&iommu_sva_lock); >> + if (refcount_dec_and_test(&domain->bond.users)) { >> + iommu_detach_device_pasid(domain, dev, pasid); >> + iommu_domain_free(domain); >> + } >> + mutex_unlock(&iommu_sva_lock); >> +} >> +EXPORT_SYMBOL_GPL(iommu_sva_unbind_device); >> + >> +u32 iommu_sva_get_pasid(struct iommu_sva *handle) >> +{ >> + struct iommu_domain *domain = >> + container_of(handle, struct iommu_domain, bond); >> + >> + return domain->mm->pasid; >> +} >> +EXPORT_SYMBOL_GPL(iommu_sva_get_pasid); > > Looks this is only used by unbind_device. Just open code it. It's part of current IOMMU/SVA interfaces for the device drivers, and has been used in various drivers. $ git grep iommu_sva_get_pasid drivers/dma/idxd/cdev.c: pasid = iommu_sva_get_pasid(sva); drivers/iommu/iommu-sva-lib.c: ioasid_t pasid = iommu_sva_get_pasid(handle); drivers/iommu/iommu-sva-lib.c:u32 iommu_sva_get_pasid(struct iommu_sva *handle) drivers/iommu/iommu-sva-lib.c:EXPORT_SYMBOL_GPL(iommu_sva_get_pasid); drivers/misc/uacce/uacce.c: pasid = iommu_sva_get_pasid(handle); include/linux/iommu.h:u32 iommu_sva_get_pasid(struct iommu_sva *handle); include/linux/iommu.h:static inline u32 iommu_sva_get_pasid(struct iommu_sva *handle) Or, I missed anything? Best regards, baolu _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Baolu Lu <baolu.lu@linux.intel.com> To: "Tian, Kevin" <kevin.tian@intel.com>, Joerg Roedel <joro@8bytes.org>, Jason Gunthorpe <jgg@nvidia.com>, Christoph Hellwig <hch@infradead.org>, "Raj, Ashok" <ashok.raj@intel.com>, Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, Jean-Philippe Brucker <jean-philippe@linaro.com>, "Jiang, Dave" <dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org> Cc: baolu.lu@linux.intel.com, Eric Auger <eric.auger@redhat.com>, "Liu, Yi L" <yi.l.liu@intel.com>, "Pan, Jacob jun" <jacob.jun.pan@intel.com>, "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>, "iommu@lists.linux.dev" <iommu@lists.linux.dev>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v9 07/11] iommu/sva: Refactoring iommu_sva_bind/unbind_device() Date: Tue, 28 Jun 2022 13:53:35 +0800 [thread overview] Message-ID: <543603e3-9d08-59ee-01f2-8dd6e7c73a15@linux.intel.com> (raw) Message-ID: <20220628055335.SPvas9ZTerIPZXkrwAqGV0RLz3TcywQ_tXuOXuVYMK8@z> (raw) In-Reply-To: <BN9PR11MB5276297FAEB8C9774AABAD208CB99@BN9PR11MB5276.namprd11.prod.outlook.com> On 2022/6/27 18:14, Tian, Kevin wrote: >> From: Lu Baolu <baolu.lu@linux.intel.com> >> Sent: Tuesday, June 21, 2022 10:44 PM >> +struct iommu_sva *iommu_sva_bind_device(struct device *dev, struct >> mm_struct *mm) >> +{ >> + struct iommu_domain *domain; >> + ioasid_t max_pasids; >> + int ret = -EINVAL; >> + >> + /* Allocate mm->pasid if necessary. */ > > this comment is for iommu_sva_alloc_pasid() Updated. > >> + max_pasids = dev->iommu->max_pasids; >> + if (!max_pasids) >> + return ERR_PTR(-EOPNOTSUPP); >> + >> + ret = iommu_sva_alloc_pasid(mm, 1, max_pasids - 1); >> + if (ret) >> + return ERR_PTR(ret); >> + > > > ... >> +void iommu_sva_unbind_device(struct iommu_sva *handle) >> +{ >> + struct device *dev = handle->dev; >> + struct iommu_domain *domain = >> + container_of(handle, struct iommu_domain, bond); >> + ioasid_t pasid = iommu_sva_get_pasid(handle); >> + >> + mutex_lock(&iommu_sva_lock); >> + if (refcount_dec_and_test(&domain->bond.users)) { >> + iommu_detach_device_pasid(domain, dev, pasid); >> + iommu_domain_free(domain); >> + } >> + mutex_unlock(&iommu_sva_lock); >> +} >> +EXPORT_SYMBOL_GPL(iommu_sva_unbind_device); >> + >> +u32 iommu_sva_get_pasid(struct iommu_sva *handle) >> +{ >> + struct iommu_domain *domain = >> + container_of(handle, struct iommu_domain, bond); >> + >> + return domain->mm->pasid; >> +} >> +EXPORT_SYMBOL_GPL(iommu_sva_get_pasid); > > Looks this is only used by unbind_device. Just open code it. It's part of current IOMMU/SVA interfaces for the device drivers, and has been used in various drivers. $ git grep iommu_sva_get_pasid drivers/dma/idxd/cdev.c: pasid = iommu_sva_get_pasid(sva); drivers/iommu/iommu-sva-lib.c: ioasid_t pasid = iommu_sva_get_pasid(handle); drivers/iommu/iommu-sva-lib.c:u32 iommu_sva_get_pasid(struct iommu_sva *handle) drivers/iommu/iommu-sva-lib.c:EXPORT_SYMBOL_GPL(iommu_sva_get_pasid); drivers/misc/uacce/uacce.c: pasid = iommu_sva_get_pasid(handle); include/linux/iommu.h:u32 iommu_sva_get_pasid(struct iommu_sva *handle); include/linux/iommu.h:static inline u32 iommu_sva_get_pasid(struct iommu_sva *handle) Or, I missed anything? Best regards, baolu
next prev parent reply other threads:[~2022-06-28 5:57 UTC|newest] Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-21 14:43 [PATCH v9 00/11] iommu: SVA and IOPF refactoring Lu Baolu 2022-06-21 14:43 ` Lu Baolu 2022-06-21 14:43 ` [PATCH v9 01/11] iommu: Add max_pasids field in struct iommu_device Lu Baolu 2022-06-21 14:43 ` Lu Baolu 2022-06-27 8:05 ` Tian, Kevin 2022-06-27 8:05 ` Tian, Kevin 2022-06-21 14:43 ` [PATCH v9 02/11] iommu: Add max_pasids field in struct dev_iommu Lu Baolu 2022-06-21 14:43 ` Lu Baolu 2022-06-27 8:06 ` Tian, Kevin 2022-06-27 8:06 ` Tian, Kevin 2022-06-21 14:43 ` [PATCH v9 03/11] iommu: Remove SVM_FLAG_SUPERVISOR_MODE support Lu Baolu 2022-06-21 14:43 ` Lu Baolu 2022-06-21 14:43 ` [PATCH v9 04/11] iommu: Add sva iommu_domain support Lu Baolu 2022-06-21 14:43 ` Lu Baolu 2022-06-27 8:29 ` Tian, Kevin 2022-06-27 8:29 ` Tian, Kevin 2022-06-28 5:41 ` Baolu Lu 2022-06-28 5:41 ` Baolu Lu 2022-06-28 8:50 ` Tian, Kevin 2022-06-28 8:50 ` Tian, Kevin 2022-06-28 11:33 ` Baolu Lu 2022-06-28 11:33 ` Baolu Lu 2022-06-29 1:54 ` Tian, Kevin 2022-06-29 1:54 ` Tian, Kevin 2022-06-29 4:44 ` Baolu Lu 2022-06-29 4:44 ` Baolu Lu 2022-06-28 11:41 ` Baolu Lu 2022-06-28 11:41 ` Baolu Lu 2022-06-21 14:43 ` [PATCH v9 05/11] iommu/vt-d: Add SVA domain support Lu Baolu 2022-06-21 14:43 ` Lu Baolu 2022-06-27 8:32 ` Tian, Kevin 2022-06-27 8:32 ` Tian, Kevin 2022-06-21 14:43 ` [PATCH v9 06/11] arm-smmu-v3/sva: " Lu Baolu 2022-06-21 14:43 ` Lu Baolu 2022-06-27 11:50 ` Zhangfei Gao 2022-06-27 11:50 ` Zhangfei Gao 2022-06-28 5:46 ` Baolu Lu 2022-06-28 5:46 ` Baolu Lu 2022-06-28 6:13 ` Baolu Lu 2022-06-28 6:13 ` Baolu Lu 2022-06-28 6:17 ` Zhu, Tony 2022-06-28 6:17 ` Zhu, Tony 2022-06-21 14:43 ` [PATCH v9 07/11] iommu/sva: Refactoring iommu_sva_bind/unbind_device() Lu Baolu 2022-06-21 14:43 ` Lu Baolu 2022-06-27 10:14 ` Tian, Kevin 2022-06-27 10:14 ` Tian, Kevin 2022-06-28 5:53 ` Baolu Lu [this message] 2022-06-28 5:53 ` Baolu Lu 2022-06-28 8:52 ` Tian, Kevin 2022-06-28 8:52 ` Tian, Kevin 2022-06-21 14:43 ` [PATCH v9 08/11] iommu: Remove SVA related callbacks from iommu ops Lu Baolu 2022-06-21 14:43 ` Lu Baolu 2022-06-21 14:43 ` [PATCH v9 09/11] iommu: Prepare IOMMU domain for IOPF Lu Baolu 2022-06-21 14:43 ` Lu Baolu 2022-06-28 8:29 ` Tian, Kevin 2022-06-28 8:29 ` Tian, Kevin 2022-06-28 10:49 ` Baolu Lu 2022-06-28 10:49 ` Baolu Lu 2022-06-21 14:43 ` [PATCH v9 10/11] iommu: Per-domain I/O page fault handling Lu Baolu 2022-06-21 14:43 ` Lu Baolu 2022-06-27 13:03 ` Ethan Zhao 2022-06-27 13:03 ` Ethan Zhao 2022-06-28 6:28 ` Baolu Lu 2022-06-28 6:28 ` Baolu Lu 2022-06-28 9:10 ` Ethan Zhao 2022-06-28 9:10 ` Ethan Zhao 2022-06-28 11:53 ` Baolu Lu 2022-06-28 11:53 ` Baolu Lu 2022-06-28 14:20 ` Jean-Philippe Brucker 2022-06-28 14:20 ` Jean-Philippe Brucker 2022-06-29 0:24 ` Baolu Lu 2022-06-29 0:24 ` Baolu Lu 2022-06-29 6:15 ` Ethan Zhao 2022-06-29 6:15 ` Ethan Zhao 2022-06-28 8:39 ` Tian, Kevin 2022-06-28 8:39 ` Tian, Kevin 2022-06-28 9:44 ` Jean-Philippe Brucker 2022-06-28 9:44 ` Jean-Philippe Brucker 2022-06-28 10:02 ` Tian, Kevin 2022-06-28 10:02 ` Tian, Kevin 2022-06-28 12:18 ` Baolu Lu 2022-06-28 12:18 ` Baolu Lu 2022-06-28 11:02 ` Baolu Lu 2022-06-28 11:02 ` Baolu Lu 2022-06-21 14:43 ` [PATCH v9 11/11] iommu: Rename iommu-sva-lib.{c,h} Lu Baolu 2022-06-21 14:43 ` Lu Baolu 2022-06-28 8:40 ` Tian, Kevin 2022-06-28 8:40 ` Tian, Kevin 2022-06-26 1:15 ` [PATCH v9 00/11] iommu: SVA and IOPF refactoring Baolu Lu 2022-06-26 1:15 ` Baolu Lu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=543603e3-9d08-59ee-01f2-8dd6e7c73a15@linux.intel.com \ --to=baolu.lu@linux.intel.com \ --cc=ashok.raj@intel.com \ --cc=dave.jiang@intel.com \ --cc=hch@infradead.org \ --cc=iommu@lists.linux-foundation.org \ --cc=iommu@lists.linux.dev \ --cc=jacob.jun.pan@intel.com \ --cc=jean-philippe@linaro.com \ --cc=jgg@nvidia.com \ --cc=joro@8bytes.org \ --cc=kevin.tian@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=robin.murphy@arm.com \ --cc=vkoul@kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).