From: Markus Elfring <Markus.Elfring@web.de>
To: Hillf Danton <hdanton@sina.com>,
Alex Williamson <alex.williamson@redhat.com>,
iommu@lists.linux-foundation.org
Cc: Kevin Tian <kevin.tian@intel.com>,
Yan Zhao <yan.y.zhao@intel.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [RFC PATCH] vfio: type1: fix kthread use case
Date: Mon, 6 Jul 2020 15:33:58 +0200 [thread overview]
Message-ID: <7ed25c44-bb51-2d8d-82d9-f11272f56424@web.de> (raw)
In-Reply-To: <20200706124241.4392-1-hdanton@sina.com>
>> Can it be helpful to convert initialisations for these variables
>> into later assignments?
>
> Perhaps. Then it looks like the below.
…
> +++ b/drivers/vfio/vfio_iommu_type1.c
> @@ -2798,9 +2798,12 @@ static int vfio_iommu_type1_dma_rw_chunk
…
> - bool kthread = current->mm == NULL;
> + bool kthread;
> + bool use_mm;
I would prefer the following variable declarations then.
+ bool kthread, use_mm;
> size_t offset;
>
> + kthread = current->flags & PF_KTHREAD;
> + use_mm = current->mm == NULL;
I propose to move such assignments directly before the corresponding check.
…
> if (!mm)
> return -EPERM;
+ kthread = current->flags & PF_KTHREAD;
+ use_mm = !current->mm;
> - if (kthread)
> + if (kthread && use_mm)
> kthread_use_mm(mm);
…
Regards,
Markus
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-07-06 13:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 10:49 [RFC PATCH] vfio: type1: fix kthread use case Hillf Danton
2020-07-06 11:32 ` Markus Elfring
2020-07-06 12:42 ` Hillf Danton
2020-07-06 13:33 ` Markus Elfring [this message]
2020-07-06 14:08 ` Hillf Danton
2020-07-06 14:04 ` Markus Elfring
2020-07-07 1:14 ` Hillf Danton
2020-07-07 6:04 ` Markus Elfring
2020-07-07 0:31 ` Yan Zhao
2020-07-07 2:00 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ed25c44-bb51-2d8d-82d9-f11272f56424@web.de \
--to=markus.elfring@web.de \
--cc=alex.williamson@redhat.com \
--cc=hch@lst.de \
--cc=hdanton@sina.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).