From: Eric Anholt <eric@anholt.net>
To: Jordan Crouse <jcrouse@codeaurora.org>
Cc: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
David Airlie <airlied@linux.ie>,
Akhil P Oommen <akhilpo@codeaurora.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
AngeloGioacchino Del Regno <kholk11@gmail.com>,
will@kernel.org, Wen Yang <wen.yang99@zte.com.cn>,
Sam Ravnborg <sam@ravnborg.org>,
Ben Dooks <ben.dooks@codethink.co.uk>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Brian Masney <masneyb@onstation.org>,
linux-arm-msm@vger.kernel.org,
Sharat Masetty <smasetty@codeaurora.org>,
Robin Murphy <robin.murphy@arm.com>,
Alexios Zavras <alexios.zavras@intel.com>,
Thomas Gleixner <tglx@linutronix.de>, Sean Paul <sean@poorly.run>,
Allison Randal <allison@lohutok.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
zhengbin <zhengbin13@huawei.com>,
iommu@lists.linux-foundation.org,
tongtiangen <tongtiangen@huawei.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Drew Davenport <ddavenport@chromium.org>,
Wambui Karuga <wambui.karugax@gmail.com>,
freedreno@lists.freedesktop.org,
Georgi Djakov <georgi.djakov@linaro.org>
Subject: Re: [PATCH v6 4/5] drm/msm: Refactor address space initialization
Date: Wed, 17 Jun 2020 13:16:06 -0700 [thread overview]
Message-ID: <CADaigPWJDEwPZyUyEO9H3=+zzdEX=h+gSa-w1ppNpM9ryY0LZA@mail.gmail.com> (raw)
In-Reply-To: <20200409233350.6343-5-jcrouse@codeaurora.org>
On Thu, Apr 9, 2020 at 4:34 PM Jordan Crouse <jcrouse@codeaurora.org> wrote:
>
> Refactor how address space initialization works. Instead of having the
> address space function create the MMU object (and thus require separate but
> equal functions for gpummu and iommu) use a single function and pass the
> MMU struct in. Make the generic code cleaner by using target specific
> functions to create the address space so a2xx can do its own thing in its
> own space. For all the other targets use a generic helper to initialize
> IOMMU but leave the door open for newer targets to use customization
> if they need it.
I'm seeing regressions in dEQP-VK.memory.allocation.random.* on cheza
after this commit. The symptom is that large allocations fail with
-ENOSPC from MSM_GEM_INFO(IOVA).
Possibly relevant change from having stuffed some debug info in:
before:
[ 3.791436] [drm:msm_gem_address_space_create] *ERROR* msmgem
address space create: 0x1000000 + 0xfeffffff
[ 3.801672] platform 506a000.gmu: Adding to iommu group 6
[ 3.807359] [drm:msm_gem_address_space_create] *ERROR* msmgem
address space create: 0x0 + 0x7fffffff
[ 3.817140] msm ae00000.mdss: bound 5000000.gpu (ops a3xx_ops)
[ 3.823212] msm_dpu ae01000.mdp: [drm:msm_ioremap] *ERROR* failed
to get memory resource: vbif_nrt
[ 3.832429] msm_dpu ae01000.mdp: [drm:msm_ioremap] *ERROR* failed
to get memory resource: regdma
[ 3.841478] [drm:dpu_kms_hw_init:878] dpu hardware revision:0x40000000
[ 3.848193] [drm:msm_gem_address_space_create] *ERROR* msmgem
address space create: 0x1000 + 0xffffefff
after:
[ 3.798707] [drm:msm_gem_address_space_create] *ERROR* msmgem
address space create: 0x1000000 + 0xfffffff
[ 3.808731] platform 506a000.gmu: Adding to iommu group 6
[ 3.814440] [drm:msm_gem_address_space_create] *ERROR* msmgem
address space create: 0x0 + 0x7fffffff
[ 3.820494] hub 2-1:1.0: USB hub found
[ 3.824108] msm ae00000.mdss: bound 5000000.gpu (ops a3xx_ops)
[ 3.828554] hub 2-1:1.0: 4 ports detected
[ 3.833756] msm_dpu ae01000.mdp: [drm:msm_ioremap] *ERROR* failed
to get memory resource: vbif_nrt
[ 3.847038] msm_dpu ae01000.mdp: [drm:msm_ioremap] *ERROR* failed
to get memory resource: regdma
[ 3.856095] [drm:dpu_kms_hw_init:878] dpu hardware revision:0x40000000
[ 3.862840] [drm:msm_gem_address_space_create] *ERROR* msmgem
address space create: 0x1000 + 0xfffffff
256MB for GMU address space?
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-06-17 20:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 23:33 [PATCH v6 0/5] iommu/arm-smmu: Split pagetable support for arm-smmu-v2 Jordan Crouse
2020-04-09 23:33 ` [PATCH v6 1/5] iommu: Add DOMAIN_ATTR_SPLIT_TABLES Jordan Crouse
2020-04-09 23:33 ` [PATCH v6 2/5] iommu/arm-smmu: Add support for TTBR1 Jordan Crouse
2020-05-18 14:59 ` Will Deacon
2020-05-20 1:53 ` Jordan Crouse
2020-05-20 12:29 ` Will Deacon
2020-04-09 23:33 ` [PATCH v6 3/5] drm/msm: Attach the IOMMU device during initialization Jordan Crouse
2020-04-09 23:33 ` [PATCH v6 4/5] drm/msm: Refactor address space initialization Jordan Crouse
2020-06-17 20:16 ` Eric Anholt [this message]
2020-06-17 20:37 ` Eric Anholt
2020-04-09 23:33 ` [PATCH v6 5/5] drm/msm/a6xx: Support split pagetables Jordan Crouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADaigPWJDEwPZyUyEO9H3=+zzdEX=h+gSa-w1ppNpM9ryY0LZA@mail.gmail.com' \
--to=eric@anholt.net \
--cc=airlied@linux.ie \
--cc=akhilpo@codeaurora.org \
--cc=alexios.zavras@intel.com \
--cc=allison@lohutok.net \
--cc=ben.dooks@codethink.co.uk \
--cc=bjorn.andersson@linaro.org \
--cc=ddavenport@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=georgi.djakov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jcrouse@codeaurora.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=kholk11@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=robin.murphy@arm.com \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
--cc=smasetty@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=tongtiangen@huawei.com \
--cc=tzimmermann@suse.de \
--cc=wambui.karugax@gmail.com \
--cc=wen.yang99@zte.com.cn \
--cc=will@kernel.org \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).