* [PATCH] dma-mapping: DMA_COHERENT_POOL should select GENERIC_ALLOCATOR
@ 2020-06-18 15:25 Christoph Hellwig
2020-06-18 17:49 ` David Rientjes via iommu
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2020-06-18 15:25 UTC (permalink / raw)
To: rientjes; +Cc: iommu, linux-kernel, kernel test robot
The dma coherent pool code needs genalloc. Move the select over
from DMA_REMAP, which doesn't actually need it.
Fixes: dbed452a078d ("dma-pool: decouple DMA_REMAP from DMA_COHERENT_POOL")
Reported-by: kernel test robot <lkp@intel.com>
---
kernel/dma/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig
index a0ce3c1494fdd2..6ad16b7c96526c 100644
--- a/kernel/dma/Kconfig
+++ b/kernel/dma/Kconfig
@@ -74,12 +74,12 @@ config DMA_NONCOHERENT_MMAP
bool
config DMA_COHERENT_POOL
+ select GENERIC_ALLOCATOR
bool
config DMA_REMAP
bool
depends on MMU
- select GENERIC_ALLOCATOR
select DMA_NONCOHERENT_MMAP
config DMA_DIRECT_REMAP
--
2.26.2
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dma-mapping: DMA_COHERENT_POOL should select GENERIC_ALLOCATOR
2020-06-18 15:25 [PATCH] dma-mapping: DMA_COHERENT_POOL should select GENERIC_ALLOCATOR Christoph Hellwig
@ 2020-06-18 17:49 ` David Rientjes via iommu
0 siblings, 0 replies; 2+ messages in thread
From: David Rientjes via iommu @ 2020-06-18 17:49 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: iommu, linux-kernel, kernel test robot
On Thu, 18 Jun 2020, Christoph Hellwig wrote:
> The dma coherent pool code needs genalloc. Move the select over
> from DMA_REMAP, which doesn't actually need it.
>
> Fixes: dbed452a078d ("dma-pool: decouple DMA_REMAP from DMA_COHERENT_POOL")
> Reported-by: kernel test robot <lkp@intel.com>
Acked-by: David Rientjes <rientjes@google.com>
Thanks Christoph. In the initial bug report from Alex Xu, his .config set
CONFIG_GENERIC_ALLOCATOR already so I think there is very little risk with
this patch.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-18 17:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-18 15:25 [PATCH] dma-mapping: DMA_COHERENT_POOL should select GENERIC_ALLOCATOR Christoph Hellwig
2020-06-18 17:49 ` David Rientjes via iommu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).