From: Mark Kettenis <email@example.com> To: Arnd Bergmann <firstname.lastname@example.org> Cc: email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: Re: [PATCH 0/3] Apple M1 DART IOMMU driver Date: Fri, 26 Mar 2021 18:26:14 +0100 (CET) [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <CAK8P3a2b7k6JkxecW=yu-NF+fkNCxJ3Ja36nQ7LK8hsuOfirstname.lastname@example.org> (message from Arnd Bergmann on Fri, 26 Mar 2021 17:38:24 +0100) > From: Arnd Bergmann <email@example.com> > Date: Fri, 26 Mar 2021 17:38:24 +0100 > > On Fri, Mar 26, 2021 at 5:10 PM Sven Peter <firstname.lastname@example.org> wrote: > > On Fri, Mar 26, 2021, at 16:59, Mark Kettenis wrote: > > > Some of the DARTs provide a bypass facility. That code make using the > > > standard "dma-ranges" property tricky. That property would need to > > > contain the bypass address range. But that would mean that if the > > > DART driver needs to look at that property to figure out the address > > > range that supports translation it will need to be able to distinguish > > > between the translatable address range and the bypass address range. > > > > Do we understand if and why we even need to bypass certain streams? > > My guess is that this is a performance optimization. > > There are generally three reasons to want an iommu in the first place: > - Pass a device down to a guest or user process without giving > access to all of memory > - Avoid problems with limitations in the device, typically when it > only supports > 32-bit bus addressing, but the installed memory is larger than 4GB > - Protect kernel memory from broken drivers > > If you care about none of the above, but you do care about data transfer > speed, you are better off just leaving the IOMMU in bypass mode. > I don't think we have to support it if the IOMMU works reliably, but it's > something that users might want. Another reason might be that a device needs access to large amounts of physical memory at the same time and the 32-bit address space that the DART provides is too tight. In U-Boot I might want to use bypass where it works since there is no proper IOMMU support in U-Boot. Generally speaking, the goal is to keep the code size down in U-Boot. In OpenBSD I'll probably avoid bypass mode if I can. I haven't figured out how the bypass stuff really works. Corellium added support for it in their codebase when they added support for Thunderbolt, and some of the DARTs that seem to be related to Thunderbolt do indeed have a "bypass" property. But it is unclear to me how the different puzzle pieces fit together for Thunderbolt. Anyway, from my viewpoint having the information about the IOVA address space sit on the devices makes little sense. This information is needed by the DART driver, and there is no direct cnnection from the DART to the individual devices in the devicetree. The "iommus" property makes a connection in the opposite direction. Cheers, Mark _______________________________________________ iommu mailing list email@example.com https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-03-26 17:26 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-20 15:19 Sven Peter via iommu 2021-03-20 15:19 ` [PATCH 1/3] iommu: io-pgtable: add DART pagetable format Sven Peter via iommu 2021-03-24 16:37 ` Robin Murphy 2021-03-25 20:47 ` Sven Peter via iommu 2021-03-20 15:20 ` [PATCH 2/3] dt-bindings: iommu: add DART iommu bindings Sven Peter via iommu 2021-03-22 0:15 ` Rob Herring 2021-03-22 18:16 ` Sven Peter via iommu 2021-03-21 16:00 ` [PATCH 0/3] Apple M1 DART IOMMU driver Mark Kettenis 2021-03-21 17:22 ` Sven Peter via iommu 2021-03-21 18:35 ` Mark Kettenis 2021-03-22 22:17 ` Sven Peter via iommu 2021-03-23 20:00 ` Mark Kettenis 2021-03-23 21:03 ` Sven Peter via iommu 2021-03-21 17:28 ` Sven Peter via iommu 2021-03-23 20:53 ` Rob Herring 2021-03-23 22:33 ` Mark Kettenis 2021-03-25 7:53 ` Sven Peter via iommu 2021-03-25 11:50 ` Robin Murphy 2021-03-25 20:49 ` Sven Peter via iommu 2021-03-27 15:33 ` Sven Peter via iommu 2021-03-25 21:41 ` Arnd Bergmann 2021-03-26 15:59 ` Mark Kettenis 2021-03-26 16:09 ` Arnd Bergmann 2021-03-26 16:10 ` Sven Peter via iommu 2021-03-26 16:38 ` Arnd Bergmann 2021-03-26 17:06 ` Sven Peter via iommu 2021-03-26 17:26 ` Mark Kettenis [this message] 2021-03-26 17:34 ` Robin Murphy 2021-03-26 17:51 ` Sven Peter via iommu 2021-03-26 19:59 ` Arnd Bergmann 2021-03-26 21:16 ` Mark Kettenis 2021-03-27 15:30 ` Sven Peter via iommu 2021-03-26 20:03 ` Arnd Bergmann 2021-03-26 21:13 ` Mark Kettenis 2021-03-24 15:29 ` Robin Murphy 2021-03-25 7:58 ` Sven Peter via iommu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 0/3] Apple M1 DART IOMMU driver' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).