IOMMU Archive on lore.kernel.org
 help / color / Atom feed
* Re: next/master bisection: baseline.login on panda
       [not found] <5ec4eb8e.1c69fb81.19b63.0b07@mx.google.com>
@ 2020-05-20  9:54 ` Guillaume Tucker
  2020-05-25 11:51   ` Joerg Roedel
  0 siblings, 1 reply; 2+ messages in thread
From: Guillaume Tucker @ 2020-05-20  9:54 UTC (permalink / raw)
  To: Joerg Roedel, Marek Szyprowski; +Cc: iommu, linux-next, linux-kernel

Please see the bisection report below about a boot failure.

Reports aren't automatically sent to the public while we're
trialing new bisection features on kernelci.org but this one
looks valid.

Unfortunately there isn't anything in the kernel log, it's
probably crashing very early on.  The bisection was run on
omap4-panda, and there seems to be the same issue on
omap3-beagle-xm as it's also failing to boot.

Please let us know if anyone is able to debug the issue or if we
need to rerun the KernelCI job with earlyprintk enabled or any
debug config option.

Thanks,
Guillaume

On 20/05/2020 09:34, kernelci.org bot wrote:
> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
> * This automated bisection report was sent to you on the basis  *
> * that you may be involved with the breaking commit it has      *
> * found.  No manual investigation has been done to verify it,   *
> * and the root cause of the problem may be somewhere else.      *
> *                                                               *
> * If you do send a fix, please include this trailer:            *
> *   Reported-by: "kernelci.org bot" <bot@kernelci.org>          *
> *                                                               *
> * Hope this helps!                                              *
> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
> 
> next/master bisection: baseline.login on panda
> 
> Summary:
>   Start:      fb57b1fabcb28 Add linux-next specific files for 20200519
>   Plain log:  https://storage.kernelci.org/next/master/next-20200519/arm/omap2plus_defconfig/gcc-8/lab-baylibre/baseline-omap4-panda.txt
>   HTML log:   https://storage.kernelci.org/next/master/next-20200519/arm/omap2plus_defconfig/gcc-8/lab-baylibre/baseline-omap4-panda.html
>   Result:     ce574c27ae275 iommu: Move iommu_group_create_direct_mappings() out of iommu_group_add_device()
> 
> Checks:
>   revert:     PASS
>   verify:     PASS
> 
> Parameters:
>   Tree:       next
>   URL:        https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>   Branch:     master
>   Target:     panda
>   CPU arch:   arm
>   Lab:        lab-baylibre
>   Compiler:   gcc-8
>   Config:     omap2plus_defconfig
>   Test case:  baseline.login
> 
> Breaking commit found:
> 
> -------------------------------------------------------------------------------
> commit ce574c27ae275bc51b6437883fc9cd1c46b498e5
> Author: Joerg Roedel <jroedel@suse.de>
> Date:   Wed Apr 29 15:36:50 2020 +0200
> 
>     iommu: Move iommu_group_create_direct_mappings() out of iommu_group_add_device()
>     
>     After the previous changes the iommu group may not have a default
>     domain when iommu_group_add_device() is called. With no default domain
>     iommu_group_create_direct_mappings() will do nothing and no direct
>     mappings will be created.
>     
>     Rename iommu_group_create_direct_mappings() to
>     iommu_create_device_direct_mappings() to better reflect that the
>     function creates direct mappings only for one device and not for all
>     devices in the group. Then move the call to the places where a default
>     domain actually exists.
>     
>     Signed-off-by: Joerg Roedel <jroedel@suse.de>
>     Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
>     Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
>     Link: https://lore.kernel.org/r/20200429133712.31431-13-joro@8bytes.org
>     Signed-off-by: Joerg Roedel <jroedel@suse.de>
> 
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index 7de0e29db3338..834a45da0ed0f 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -89,6 +89,8 @@ static int __iommu_attach_group(struct iommu_domain *domain,
>  				struct iommu_group *group);
>  static void __iommu_detach_group(struct iommu_domain *domain,
>  				 struct iommu_group *group);
> +static int iommu_create_device_direct_mappings(struct iommu_group *group,
> +					       struct device *dev);
>  
>  #define IOMMU_GROUP_ATTR(_name, _mode, _show, _store)		\
>  struct iommu_group_attribute iommu_group_attr_##_name =		\
> @@ -243,6 +245,8 @@ static int __iommu_probe_device_helper(struct device *dev)
>  	if (group->default_domain)
>  		ret = __iommu_attach_device(group->default_domain, dev);
>  
> +	iommu_create_device_direct_mappings(group, dev);
> +
>  	iommu_group_put(group);
>  
>  	if (ret)
> @@ -263,6 +267,7 @@ static int __iommu_probe_device_helper(struct device *dev)
>  int iommu_probe_device(struct device *dev)
>  {
>  	const struct iommu_ops *ops = dev->bus->iommu_ops;
> +	struct iommu_group *group;
>  	int ret;
>  
>  	WARN_ON(dev->iommu_group);
> @@ -285,6 +290,10 @@ int iommu_probe_device(struct device *dev)
>  	if (ret)
>  		goto err_module_put;
>  
> +	group = iommu_group_get(dev);
> +	iommu_create_device_direct_mappings(group, dev);
> +	iommu_group_put(group);
> +
>  	if (ops->probe_finalize)
>  		ops->probe_finalize(dev);
>  
> @@ -736,8 +745,8 @@ int iommu_group_set_name(struct iommu_group *group, const char *name)
>  }
>  EXPORT_SYMBOL_GPL(iommu_group_set_name);
>  
> -static int iommu_group_create_direct_mappings(struct iommu_group *group,
> -					      struct device *dev)
> +static int iommu_create_device_direct_mappings(struct iommu_group *group,
> +					       struct device *dev)
>  {
>  	struct iommu_domain *domain = group->default_domain;
>  	struct iommu_resv_region *entry;
> @@ -841,8 +850,6 @@ int iommu_group_add_device(struct iommu_group *group, struct device *dev)
>  
>  	dev->iommu_group = group;
>  
> -	iommu_group_create_direct_mappings(group, dev);
> -
>  	mutex_lock(&group->mutex);
>  	list_add_tail(&device->list, &group->devices);
>  	if (group->domain)
> @@ -1736,6 +1743,7 @@ static void probe_alloc_default_domain(struct bus_type *bus,
>  		gtype.type = iommu_def_domain_type;
>  
>  	iommu_group_alloc_default_domain(bus, group, gtype.type);
> +
>  }
>  
>  static int iommu_group_do_dma_attach(struct device *dev, void *data)
> @@ -1760,6 +1768,21 @@ static int __iommu_group_dma_attach(struct iommu_group *group)
>  					  iommu_group_do_dma_attach);
>  }
>  
> +static int iommu_do_create_direct_mappings(struct device *dev, void *data)
> +{
> +	struct iommu_group *group = data;
> +
> +	iommu_create_device_direct_mappings(group, dev);
> +
> +	return 0;
> +}
> +
> +static int iommu_group_create_direct_mappings(struct iommu_group *group)
> +{
> +	return __iommu_group_for_each_dev(group, group,
> +					  iommu_do_create_direct_mappings);
> +}
> +
>  static int bus_iommu_probe(struct bus_type *bus)
>  {
>  	const struct iommu_ops *ops = bus->iommu_ops;
> @@ -1792,6 +1815,8 @@ static int bus_iommu_probe(struct bus_type *bus)
>  				continue;
>  			}
>  
> +			iommu_group_create_direct_mappings(group);
> +
>  			ret = __iommu_group_dma_attach(group);
>  
>  			mutex_unlock(&group->mutex);
> @@ -2632,7 +2657,7 @@ request_default_domain_for_dev(struct device *dev, unsigned long type)
>  		iommu_domain_free(group->default_domain);
>  	group->default_domain = domain;
>  
> -	iommu_group_create_direct_mappings(group, dev);
> +	iommu_create_device_direct_mappings(group, dev);
>  
>  	dev_info(dev, "Using iommu %s mapping\n",
>  		 type == IOMMU_DOMAIN_DMA ? "dma" : "direct");
> -------------------------------------------------------------------------------
> 
> 
> Git bisection log:
> 
> -------------------------------------------------------------------------------
> git bisect start
> # good: [642b151f45dd54809ea00ecd3976a56c1ec9b53d] Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity
> git bisect good 642b151f45dd54809ea00ecd3976a56c1ec9b53d
> # bad: [fb57b1fabcb28f358901b2df90abd2b48abc1ca8] Add linux-next specific files for 20200519
> git bisect bad fb57b1fabcb28f358901b2df90abd2b48abc1ca8
> # good: [8b3dd8b61115d665572dcac44bc6b3e95c8f34f2] Merge remote-tracking branch 'crypto/master'
> git bisect good 8b3dd8b61115d665572dcac44bc6b3e95c8f34f2
> # bad: [144c0fb86d53982ba156b518e7b3fbee71f56655] Merge remote-tracking branch 'spi/for-next'
> git bisect bad 144c0fb86d53982ba156b518e7b3fbee71f56655
> # good: [1a90af6b9ad8a56d9929e69a28b21aa1132fc42c] Merge remote-tracking branch 'amdgpu/drm-next'
> git bisect good 1a90af6b9ad8a56d9929e69a28b21aa1132fc42c
> # good: [a27ba83aed2e6a01f16fd56dd322839c9c179c38] Merge remote-tracking branch 'block/for-next'
> git bisect good a27ba83aed2e6a01f16fd56dd322839c9c179c38
> # good: [7f58fc25a6c6c9ac84701be427c477d4a09f197e] Merge remote-tracking branch 'integrity/next-integrity'
> git bisect good 7f58fc25a6c6c9ac84701be427c477d4a09f197e
> # good: [59ffe4ed0725de96f4710013c34de387fbeac90c] dt-bindings: ehci/ohci: Allow iommus property
> git bisect good 59ffe4ed0725de96f4710013c34de387fbeac90c
> # bad: [f74794b89196349ad42fce396d3537672b4db157] Merge remote-tracking branch 'iommu/next'
> git bisect bad f74794b89196349ad42fce396d3537672b4db157
> # bad: [14b3526d5909f01e1d1baa05f50952788bb7418e] iommu/vt-d: Allow PCI sub-hierarchy to use DMA domain
> git bisect bad 14b3526d5909f01e1d1baa05f50952788bb7418e
> # bad: [21acf6599cfb4407e9745b36f69c93cf99a3d189] iommu/virtio: Convert to probe/release_device() call-backs
> git bisect bad 21acf6599cfb4407e9745b36f69c93cf99a3d189
> # good: [cf193888bfbd3d57e03a511e49d26f7d9c6f76df] iommu: Move new probe_device path to separate function
> git bisect good cf193888bfbd3d57e03a511e49d26f7d9c6f76df
> # bad: [dce8d6964ebdb333383bacf5e7ab8c27df151218] iommu/amd: Convert to probe/release_device() call-backs
> git bisect bad dce8d6964ebdb333383bacf5e7ab8c27df151218
> # bad: [ce574c27ae275bc51b6437883fc9cd1c46b498e5] iommu: Move iommu_group_create_direct_mappings() out of iommu_group_add_device()
> git bisect bad ce574c27ae275bc51b6437883fc9cd1c46b498e5
> # good: [deac0b3bed26bb5d04486696b1071d8ec3851100] iommu: Split off default domain allocation from group assignment
> git bisect good deac0b3bed26bb5d04486696b1071d8ec3851100
> # first bad commit: [ce574c27ae275bc51b6437883fc9cd1c46b498e5] iommu: Move iommu_group_create_direct_mappings() out of iommu_group_add_device()
> -------------------------------------------------------------------------------
> 

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: next/master bisection: baseline.login on panda
  2020-05-20  9:54 ` next/master bisection: baseline.login on panda Guillaume Tucker
@ 2020-05-25 11:51   ` Joerg Roedel
  0 siblings, 0 replies; 2+ messages in thread
From: Joerg Roedel @ 2020-05-25 11:51 UTC (permalink / raw)
  To: Guillaume Tucker; +Cc: iommu, linux-next, linux-kernel

Hi Guillaume,

On Wed, May 20, 2020 at 10:54:44AM +0100, Guillaume Tucker wrote:
> Please see the bisection report below about a boot failure.
> 
> Reports aren't automatically sent to the public while we're
> trialing new bisection features on kernelci.org but this one
> looks valid.
> 
> Unfortunately there isn't anything in the kernel log, it's
> probably crashing very early on.  The bisection was run on
> omap4-panda, and there seems to be the same issue on
> omap3-beagle-xm as it's also failing to boot.

The issue is likely a deadlock fixed by:

	https://lore.kernel.org/r/20200519132824.15163-1-joro@8bytes.org

The patch is already in the iommu-tree and should show up in linux-next
soon.

Regards,

	Joerg

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <5ec4eb8e.1c69fb81.19b63.0b07@mx.google.com>
2020-05-20  9:54 ` next/master bisection: baseline.login on panda Guillaume Tucker
2020-05-25 11:51   ` Joerg Roedel

IOMMU Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iommu/0 linux-iommu/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iommu linux-iommu/ https://lore.kernel.org/linux-iommu \
		iommu@lists.linux-foundation.org
	public-inbox-index linux-iommu

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linux-foundation.lists.iommu


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git