From: Paolo Bonzini <pbonzini@redhat.com>
To: Arnd Bergmann <arnd@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org
Cc: linux-hyperv@vger.kernel.org,
Stephen Hemminger <sthemmin@microsoft.com>,
kvm@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Haiyang Zhang <haiyangz@microsoft.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
xen-devel@lists.xenproject.org, iommu@lists.linux-foundation.org,
"H. Peter Anvin" <hpa@zytor.com>,
Wanpeng Li <wanpengli@tencent.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Jim Mattson <jmattson@google.com>
Subject: Re: [PATCH] [v2] x86: apic: avoid -Wshadow warning in header
Date: Thu, 29 Oct 2020 08:04:31 +0100 [thread overview]
Message-ID: <ea34f1d3-ed54-a2de-79d9-5cc8decc0ab3@redhat.com> (raw)
In-Reply-To: <20201028212417.3715575-1-arnd@kernel.org>
On 28/10/20 22:20, Arnd Bergmann wrote:
> Avoid this by renaming the global 'apic' variable to the more descriptive
> 'x86_system_apic'. It was originally called 'genapic', but both that
> and the current 'apic' seem to be a little overly generic for a global
> variable.
The 'apic' affects only the current CPU, so one of 'x86_local_apic',
'x86_lapic' or 'x86_apic' is probably preferrable.
I don't have huge objections to renaming 'apic' variables and arguments
in KVM to 'lapic'. I do agree with Sean however that it's going to
break again very soon.
Paolo
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-10-29 7:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 21:20 [PATCH] [v2] x86: apic: avoid -Wshadow warning in header Arnd Bergmann
2020-10-29 7:04 ` Paolo Bonzini [this message]
2020-10-29 9:51 ` Arnd Bergmann
2020-10-29 16:30 ` David Laight
2020-10-29 16:52 ` Thomas Gleixner
2020-10-29 15:05 ` David Laight
2020-10-29 16:56 ` Arvind Sankar
2020-10-29 16:59 ` Paolo Bonzini
2020-10-29 17:20 ` Arvind Sankar
2020-10-29 20:41 ` Thomas Gleixner
2020-10-29 21:35 ` Arvind Sankar
2020-10-29 22:12 ` David Laight
2020-10-30 18:16 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea34f1d3-ed54-a2de-79d9-5cc8decc0ab3@redhat.com \
--to=pbonzini@redhat.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bp@alien8.de \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).