* RE: getconf options
[not found] <dbf8b816-e1f7-f835-dd32-6b517e87cbc4@foxmail.com>
@ 2017-10-20 4:14 ` yamada.masahiro
2017-10-20 5:47 ` Uwe Kleine-König
0 siblings, 1 reply; 5+ messages in thread
From: yamada.masahiro @ 2017-10-20 4:14 UTC (permalink / raw)
To: puck.chen, u.kleine-koenig, ben, linux-kbuild
Hi Uwe, Ben,
> Hi Uwe,
>
> With commit d7f14c66c273b00aaa626f419d3155773a88d460, I got the follow
> warning on macos.
>
> getconf: no such configuration parameter `LFS_CFLAGS'
> getconf: no such configuration parameter `LFS_LDFLAGS'
> getconf: no such configuration parameter `LFS_LIBS'
> scripts/kconfig/mconf Kconfig
>
> $ getconf LFS_CFLAGS
> getconf: no such configuration parameter `LFS_CFLAGS'
>
>
> Do you have some idea about this? Are these paremeters default to getconf?
>
> -Feng
>
Do you have a clue?
Does it make sense to suppress warnings like this?
HOST_LFS_CFLAGS := $(shell getconf LFS_CFLAGS 2>/dev/null)
HOST_LFS_LDFLAGS := $(shell getconf LFS_LDFLAGS 2>/dev/null)
HOST_LFS_LIBS := $(shell getconf LFS_LIBS 2>/dev/null)
Or, hard-code
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
as Ben originally suggested?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: getconf options
2017-10-20 4:14 ` getconf options yamada.masahiro
@ 2017-10-20 5:47 ` Uwe Kleine-König
2017-10-20 13:20 ` Ben Hutchings
0 siblings, 1 reply; 5+ messages in thread
From: Uwe Kleine-König @ 2017-10-20 5:47 UTC (permalink / raw)
To: yamada.masahiro; +Cc: puck.chen, ben, linux-kbuild
Hello,
On Fri, Oct 20, 2017 at 04:14:44AM +0000, yamada.masahiro@socionext.com wrote:
> > With commit d7f14c66c273b00aaa626f419d3155773a88d460, I got the follow
> > warning on macos.
> >
> > getconf: no such configuration parameter `LFS_CFLAGS'
> > getconf: no such configuration parameter `LFS_LDFLAGS'
> > getconf: no such configuration parameter `LFS_LIBS'
> > scripts/kconfig/mconf Kconfig
> >
> > $ getconf LFS_CFLAGS
> > getconf: no such configuration parameter `LFS_CFLAGS'
> >
> >
> > Do you have some idea about this? Are these paremeters default to getconf?
> >
> > -Feng
> >
>
>
> Do you have a clue?
>
>
> Does it make sense to suppress warnings like this?
>
> HOST_LFS_CFLAGS := $(shell getconf LFS_CFLAGS 2>/dev/null)
> HOST_LFS_LDFLAGS := $(shell getconf LFS_LDFLAGS 2>/dev/null)
> HOST_LFS_LIBS := $(shell getconf LFS_LIBS 2>/dev/null)
>
>
> Or, hard-code
> -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
> as Ben originally suggested?
I'm not a fan of hardcoding these. On 64 bit arch (and I think also a
few 32 bit archs (x32?)) they are not needed and so IMHO shouldn't be
added.
I think 2>/dev/null is fine.
Having said that, I wonder if/how LFS works on MacOS.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: getconf options
2017-10-20 5:47 ` Uwe Kleine-König
@ 2017-10-20 13:20 ` Ben Hutchings
2017-10-24 4:27 ` Masahiro Yamada
0 siblings, 1 reply; 5+ messages in thread
From: Ben Hutchings @ 2017-10-20 13:20 UTC (permalink / raw)
To: Uwe Kleine-König, yamada.masahiro; +Cc: puck.chen, linux-kbuild
[-- Attachment #1: Type: text/plain, Size: 1522 bytes --]
On Fri, 2017-10-20 at 07:47 +0200, Uwe Kleine-König wrote:
> Hello,
>
> On Fri, Oct 20, 2017 at 04:14:44AM +0000, yamada.masahiro@socionext.com wrote:
> > > With commit d7f14c66c273b00aaa626f419d3155773a88d460, I got the follow
> > > warning on macos.
> > >
> > > getconf: no such configuration parameter `LFS_CFLAGS'
> > > getconf: no such configuration parameter `LFS_LDFLAGS'
> > > getconf: no such configuration parameter `LFS_LIBS'
> > > scripts/kconfig/mconf Kconfig
> > >
> > > $ getconf LFS_CFLAGS
> > > getconf: no such configuration parameter `LFS_CFLAGS'
> > >
> > >
> > > Do you have some idea about this? Are these paremeters default to getconf?
> > >
> > > -Feng
> > >
> >
> >
> > Do you have a clue?
> >
> >
> > Does it make sense to suppress warnings like this?
> >
> > HOST_LFS_CFLAGS := $(shell getconf LFS_CFLAGS 2>/dev/null)
> > HOST_LFS_LDFLAGS := $(shell getconf LFS_LDFLAGS 2>/dev/null)
> > HOST_LFS_LIBS := $(shell getconf LFS_LIBS 2>/dev/null)
> >
> >
> > Or, hard-code
> > -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
> > as Ben originally suggested?
>
> I'm not a fan of hardcoding these. On 64 bit arch (and I think also a
> few 32 bit archs (x32?)) they are not needed and so IMHO shouldn't be
> added.
What harm would they do?
Ben.
> I think 2>/dev/null is fine.
>
> Having said that, I wonder if/how LFS works on MacOS.
--
Ben Hutchings
Make three consecutive correct guesses and you will be considered an
expert.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: getconf options
2017-10-20 13:20 ` Ben Hutchings
@ 2017-10-24 4:27 ` Masahiro Yamada
2017-10-24 7:06 ` Uwe Kleine-König
0 siblings, 1 reply; 5+ messages in thread
From: Masahiro Yamada @ 2017-10-24 4:27 UTC (permalink / raw)
To: Ben Hutchings, Uwe Kleine-König; +Cc: puck.chen, Linux Kbuild mailing list
2017-10-20 22:20 GMT+09:00 Ben Hutchings <ben@decadent.org.uk>:
> On Fri, 2017-10-20 at 07:47 +0200, Uwe Kleine-König wrote:
>> Hello,
>>
>> On Fri, Oct 20, 2017 at 04:14:44AM +0000, yamada.masahiro@socionext.com wrote:
>> > > With commit d7f14c66c273b00aaa626f419d3155773a88d460, I got the follow
>> > > warning on macos.
>> > >
>> > > getconf: no such configuration parameter `LFS_CFLAGS'
>> > > getconf: no such configuration parameter `LFS_LDFLAGS'
>> > > getconf: no such configuration parameter `LFS_LIBS'
>> > > scripts/kconfig/mconf Kconfig
>> > >
>> > > $ getconf LFS_CFLAGS
>> > > getconf: no such configuration parameter `LFS_CFLAGS'
>> > >
>> > >
>> > > Do you have some idea about this? Are these paremeters default to getconf?
>> > >
>> > > -Feng
>> > >
>> >
>> >
>> > Do you have a clue?
>> >
>> >
>> > Does it make sense to suppress warnings like this?
>> >
>> > HOST_LFS_CFLAGS := $(shell getconf LFS_CFLAGS 2>/dev/null)
>> > HOST_LFS_LDFLAGS := $(shell getconf LFS_LDFLAGS 2>/dev/null)
>> > HOST_LFS_LIBS := $(shell getconf LFS_LIBS 2>/dev/null)
>> >
>> >
>> > Or, hard-code
>> > -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
>> > as Ben originally suggested?
>>
>> I'm not a fan of hardcoding these. On 64 bit arch (and I think also a
>> few 32 bit archs (x32?)) they are not needed and so IMHO shouldn't be
>> added.
>
> What harm would they do?
>
> Ben.
>
>> I think 2>/dev/null is fine.
If your machine does not recognize "getconf LFS_CFLAGS",
but needs LFS flags, it is a problem.
Hard-coding the flags seem more stable to me.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: getconf options
2017-10-24 4:27 ` Masahiro Yamada
@ 2017-10-24 7:06 ` Uwe Kleine-König
0 siblings, 0 replies; 5+ messages in thread
From: Uwe Kleine-König @ 2017-10-24 7:06 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Ben Hutchings, puck.chen, Linux Kbuild mailing list
On Tue, Oct 24, 2017 at 01:27:37PM +0900, Masahiro Yamada wrote:
> 2017-10-20 22:20 GMT+09:00 Ben Hutchings <ben@decadent.org.uk>:
> > On Fri, 2017-10-20 at 07:47 +0200, Uwe Kleine-König wrote:
> >> Hello,
> >>
> >> On Fri, Oct 20, 2017 at 04:14:44AM +0000, yamada.masahiro@socionext.com wrote:
> >> > > With commit d7f14c66c273b00aaa626f419d3155773a88d460, I got the follow
> >> > > warning on macos.
> >> > >
> >> > > getconf: no such configuration parameter `LFS_CFLAGS'
> >> > > getconf: no such configuration parameter `LFS_LDFLAGS'
> >> > > getconf: no such configuration parameter `LFS_LIBS'
> >> > > scripts/kconfig/mconf Kconfig
> >> > >
> >> > > $ getconf LFS_CFLAGS
> >> > > getconf: no such configuration parameter `LFS_CFLAGS'
> >> > >
> >> > >
> >> > > Do you have some idea about this? Are these paremeters default to getconf?
> >> > >
> >> > > -Feng
> >> > >
> >> >
> >> >
> >> > Do you have a clue?
> >> >
> >> >
> >> > Does it make sense to suppress warnings like this?
> >> >
> >> > HOST_LFS_CFLAGS := $(shell getconf LFS_CFLAGS 2>/dev/null)
> >> > HOST_LFS_LDFLAGS := $(shell getconf LFS_LDFLAGS 2>/dev/null)
> >> > HOST_LFS_LIBS := $(shell getconf LFS_LIBS 2>/dev/null)
> >> >
> >> >
> >> > Or, hard-code
> >> > -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
> >> > as Ben originally suggested?
> >>
> >> I'm not a fan of hardcoding these. On 64 bit arch (and I think also a
> >> few 32 bit archs (x32?)) they are not needed and so IMHO shouldn't be
> >> added.
> >
> > What harm would they do?
> >
> > Ben.
> >
> >> I think 2>/dev/null is fine.
>
>
> If your machine does not recognize "getconf LFS_CFLAGS",
> but needs LFS flags, it is a problem.
>
> Hard-coding the flags seem more stable to me.
Don't know how real the danger is that $(getconf LFS_CFLAGS) returns
something that is neither "" nor "-D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64". Are there platforms that knowingly depend on
sizeof(off_t) = 4 which break when -D_FILE_OFFSET_BITS=64 is passed?
When will we depend on -D_FILE_OFFSET_BITS=128? Probably all these are
not relevant now, still it feels more right to go the 2>/dev/null way
for me.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-24 7:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <dbf8b816-e1f7-f835-dd32-6b517e87cbc4@foxmail.com>
2017-10-20 4:14 ` getconf options yamada.masahiro
2017-10-20 5:47 ` Uwe Kleine-König
2017-10-20 13:20 ` Ben Hutchings
2017-10-24 4:27 ` Masahiro Yamada
2017-10-24 7:06 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).