linux-kbuild.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Michal Marek <mmarek@suse.cz>
Cc: Ingo Molnar <mingo@elte.hu>, Borislav Petkov <bp@alien8.de>,
	Arnd Bergmann <arnd@arndb.de>,
	torvalds@linux-foundation.org, x86@kernel.org,
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	bp@amd64.org
Subject: Re: [PATCH -v5] kbuild: Add extra gcc checks
Date: Thu, 10 Mar 2011 11:25:11 +0100	[thread overview]
Message-ID: <20110310102511.GA30886@merkur.ravnborg.org> (raw)
In-Reply-To: <4D78971C.6090107@suse.cz>

> One way without extending the current rules could be:
> 
> ifdef CONFIG_CC_WERROR
> Werror := -Werror
> endif
> 
> CFLAGS_sched.o := $(Werror)
> CFLAGS_another.o := $(Werror)
> 
> What do you think?

We could extend kbuild to support something like this:

    ccflags-<filename>-y := -Werror

Sample:

    ccflags-sched.o-$(CONFIG_WERROR) := -Werror

The above is a nice counterpart to the existing ccflags-y.
And we could then deprecate CLFAGS_<filename> as we have today.

To remove options we could use:

ccflags-<filename>-remove-y := -pg

This is a replacement of the undocumented CFLAGS_REMOVE_<filename> variant.

Today:
    ifdef CONFIG_FUNCTION_TRACER
    CFLAGS_REMOVE_lockdep.o = -pg
    endif

Could be replaced with:

   ccflags-lockdep.o-remove-$(CONFIG_FUNCTION_TRACER) := -pg

The ifdef often cover more than one file so we save less lines in
reality than the example says.


All looks rather trivial to implement.
But it is maybe a bit too cryptic?

	Sam

  reply	other threads:[~2011-03-10 10:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-01  8:35 [PATCH -v5] kbuild: Add extra gcc checks Borislav Petkov
2011-03-09 14:45 ` Michal Marek
2011-03-09 15:06   ` Borislav Petkov
2011-03-09 15:11   ` Ingo Molnar
2011-03-09 17:56     ` Sam Ravnborg
2011-03-10  9:04       ` Ingo Molnar
2011-03-10  9:17         ` Michal Marek
2011-03-10 10:25           ` Sam Ravnborg [this message]
2011-03-10  9:20         ` Borislav Petkov
2011-03-10 11:56         ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110310102511.GA30886@merkur.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=arnd@arndb.de \
    --cc=bp@alien8.de \
    --cc=bp@amd64.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mmarek@suse.cz \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).