* [PATCH v3] kbuild: kselftest - new make target to build and run kernel selftests
@ 2014-08-07 19:07 Shuah Khan
2014-08-07 20:11 ` Michal Marek
2014-08-07 20:18 ` Sam Ravnborg
0 siblings, 2 replies; 3+ messages in thread
From: Shuah Khan @ 2014-08-07 19:07 UTC (permalink / raw)
To: mmarek, gregkh, sam; +Cc: Shuah Khan, linux-kbuild, linux-kernel
Add a new make target "kselftest" to enable kernel testing. This
new target builds and runs kernel selftests. Running as root is
recommended for a complete test run as some tests don't run when
run by non-root user. Build, install, and boot kernel before
running kselftest on it.
Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
---
Makefile | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Makefile b/Makefile
index d0901b4..574e8da 100644
--- a/Makefile
+++ b/Makefile
@@ -1036,6 +1036,13 @@ headers_check: headers_install
$(Q)$(MAKE) $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) HDRCHECK=1
# ---------------------------------------------------------------------------
+# Kernel selftest
+
+PHONY += kselftest
+kselftest:
+ $(Q)$(MAKE) -C tools/testing/selftests run_tests
+
+# ---------------------------------------------------------------------------
# Modules
ifdef CONFIG_MODULES
@@ -1238,6 +1245,11 @@ help:
@echo ' headerdep - Detect inclusion cycles in headers'
@$(MAKE) -f $(srctree)/scripts/Makefile.help checker-help
@echo ''
+ @echo 'Kernel selftest'
+ @echo ' kselftest - Build and run kernel selftest (run as root)'
+ @echo ' Build, install, and boot kernel before'
+ @echo ' running kselftest on it'
+ @echo ''
@echo 'Kernel packaging:'
@$(MAKE) $(build)=$(package-dir) help
@echo ''
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] kbuild: kselftest - new make target to build and run kernel selftests
2014-08-07 19:07 [PATCH v3] kbuild: kselftest - new make target to build and run kernel selftests Shuah Khan
@ 2014-08-07 20:11 ` Michal Marek
2014-08-07 20:18 ` Sam Ravnborg
1 sibling, 0 replies; 3+ messages in thread
From: Michal Marek @ 2014-08-07 20:11 UTC (permalink / raw)
To: Shuah Khan; +Cc: gregkh, sam, linux-kbuild, linux-kernel
On Thu, Aug 07, 2014 at 01:07:46PM -0600, Shuah Khan wrote:
> Add a new make target "kselftest" to enable kernel testing. This
> new target builds and runs kernel selftests. Running as root is
> recommended for a complete test run as some tests don't run when
> run by non-root user. Build, install, and boot kernel before
> running kselftest on it.
>
> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
When sending updated versions of patches, plese include a short revision
history in the email, to make it obvious what has changed in each version.
Anyway, v3 looks good, I applied it to kbuild.git#misc now.
Thanks,
Michal
> ---
> Makefile | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index d0901b4..574e8da 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1036,6 +1036,13 @@ headers_check: headers_install
> $(Q)$(MAKE) $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) HDRCHECK=1
>
> # ---------------------------------------------------------------------------
> +# Kernel selftest
> +
> +PHONY += kselftest
> +kselftest:
> + $(Q)$(MAKE) -C tools/testing/selftests run_tests
> +
> +# ---------------------------------------------------------------------------
> # Modules
>
> ifdef CONFIG_MODULES
> @@ -1238,6 +1245,11 @@ help:
> @echo ' headerdep - Detect inclusion cycles in headers'
> @$(MAKE) -f $(srctree)/scripts/Makefile.help checker-help
> @echo ''
> + @echo 'Kernel selftest'
> + @echo ' kselftest - Build and run kernel selftest (run as root)'
> + @echo ' Build, install, and boot kernel before'
> + @echo ' running kselftest on it'
> + @echo ''
> @echo 'Kernel packaging:'
> @$(MAKE) $(build)=$(package-dir) help
> @echo ''
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] kbuild: kselftest - new make target to build and run kernel selftests
2014-08-07 19:07 [PATCH v3] kbuild: kselftest - new make target to build and run kernel selftests Shuah Khan
2014-08-07 20:11 ` Michal Marek
@ 2014-08-07 20:18 ` Sam Ravnborg
1 sibling, 0 replies; 3+ messages in thread
From: Sam Ravnborg @ 2014-08-07 20:18 UTC (permalink / raw)
To: Shuah Khan; +Cc: mmarek, gregkh, linux-kbuild, linux-kernel
On Thu, Aug 07, 2014 at 01:07:46PM -0600, Shuah Khan wrote:
> Add a new make target "kselftest" to enable kernel testing. This
> new target builds and runs kernel selftests. Running as root is
> recommended for a complete test run as some tests don't run when
> run by non-root user. Build, install, and boot kernel before
> running kselftest on it.
>
> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
> ---
> Makefile | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index d0901b4..574e8da 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1036,6 +1036,13 @@ headers_check: headers_install
> $(Q)$(MAKE) $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) HDRCHECK=1
>
> # ---------------------------------------------------------------------------
> +# Kernel selftest
> +
> +PHONY += kselftest
> +kselftest:
> + $(Q)$(MAKE) -C tools/testing/selftests run_tests
> +
> +# ---------------------------------------------------------------------------
> # Modules
>
> ifdef CONFIG_MODULES
> @@ -1238,6 +1245,11 @@ help:
> @echo ' headerdep - Detect inclusion cycles in headers'
> @$(MAKE) -f $(srctree)/scripts/Makefile.help checker-help
> @echo ''
> + @echo 'Kernel selftest'
> + @echo ' kselftest - Build and run kernel selftest (run as root)'
> + @echo ' Build, install, and boot kernel before'
> + @echo ' running kselftest on it'
It is never good to advertise to run something as root.
But I see that this is recommended for now so the patch has my:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Sam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-07 20:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-07 19:07 [PATCH v3] kbuild: kselftest - new make target to build and run kernel selftests Shuah Khan
2014-08-07 20:11 ` Michal Marek
2014-08-07 20:18 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).