From: Sam Ravnborg <sam@ravnborg.org>
To: Michael Ton <linuxham@gmail.com>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] kbuild: fix bug with modpost Makefile warn flag inclusion
Date: Tue, 19 Aug 2014 06:35:18 +0200 [thread overview]
Message-ID: <20140819043517.GA21121@ravnborg.org> (raw)
In-Reply-To: <53F26025.4010902@gmail.com>
On Mon, Aug 18, 2014 at 02:20:53PM -0600, Michael Ton wrote:
> From: Michael Ton <linuxham@gmail.com>
>
> The current Makefile.modpost file includes a warn (-w) flag to modpost if
> KBUILD_EXTMOD or KBUILD_MODPOST_WARN. This flag should only be added if
> both flags are true. Whenever KBUILD_MODPOST is true, modpost currently
> only prints warnings and does not exit on error (such as on an undefined
> symbol).
From the documentation:
KBUILD_MODPOST_WARN
--------------------------------------------------
KBUILD_MODPOST_WARN can be set to avoid errors in case of undefined
symbols in the final module linking stage. It changes such errors
into warnings.
Nothing here say that we need KBUILD_EXTMOD to use this.
Why did you conclude that KBUILD_MODPOST_WARN is only relevant for
KBUILD_EXTMOD? Something must have triggerede the patch...
Sam
next prev parent reply other threads:[~2014-08-19 4:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 20:20 [PATCH] kbuild: fix bug with modpost Makefile warn flag inclusion Michael Ton
2014-08-19 4:35 ` Sam Ravnborg [this message]
[not found] <CA+1_+FO=65Hbd1bcTgb6WS4OwdF6W38fyiE1C2rWiU+=s_CHQQ@mail.gmail.com>
2014-08-19 7:00 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140819043517.GA21121@ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linuxham@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).