From: Michael Ton <linuxham@gmail.com>
To: linux-kbuild@vger.kernel.org
Subject: [PATCH] kbuild: fix bug with modpost Makefile warn flag inclusion
Date: Mon, 18 Aug 2014 14:20:53 -0600 [thread overview]
Message-ID: <53F26025.4010902@gmail.com> (raw)
From: Michael Ton <linuxham@gmail.com>
The current Makefile.modpost file includes a warn (-w) flag to modpost
if KBUILD_EXTMOD or KBUILD_MODPOST_WARN. This flag should only be added
if both flags are true. Whenever KBUILD_MODPOST is true, modpost
currently only prints warnings and does not exit on error (such as on an
undefined symbol).
Signed-off-by: Michael Ton <linuxham@gmail.com>
---
--- scripts/Makefile.modpost.orig 2014-08-18 13:18:18.704048707 -0600
+++ scripts/Makefile.modpost 2014-08-18 13:24:20.902520603 -0600
@@ -77,7 +77,7 @@ modpost = scripts/mod/modpost
$(if $(KBUILD_EXTRA_SYMBOLS), $(patsubst %, -e
%,$(KBUILD_EXTRA_SYMBOLS))) \
$(if $(KBUILD_EXTMOD),-o $(modulesymfile)) \
$(if $(CONFIG_DEBUG_SECTION_MISMATCH),,-S) \
- $(if $(KBUILD_EXTMOD)$(KBUILD_MODPOST_WARN),-w)
+ $(if $(KBUILD_EXTMOD), $(if $(KBUILD_MODPOST_WARN),-w))
MODPOST_OPT=$(subst -i,-n,$(filter -i,$(MAKEFLAGS)))
next reply other threads:[~2014-08-18 20:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 20:20 Michael Ton [this message]
2014-08-19 4:35 ` [PATCH] kbuild: fix bug with modpost Makefile warn flag inclusion Sam Ravnborg
[not found] <CA+1_+FO=65Hbd1bcTgb6WS4OwdF6W38fyiE1C2rWiU+=s_CHQQ@mail.gmail.com>
2014-08-19 7:00 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F26025.4010902@gmail.com \
--to=linuxham@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).