* [PATCH] kbuild: update headers_install.txt document
@ 2014-12-03 6:45 Masahiro Yamada
2014-12-03 14:02 ` Jonathan Corbet
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2014-12-03 6:45 UTC (permalink / raw)
To: linux-kbuild
Cc: Jonathan Corbet, Masahiro Yamada, Michal Marek, linux-doc, linux-kernel
The arch header directories "include/asm-*" were moved long ago.
Now we should check the existence of arch/*/include/uapi/asm/Kbuild
to see if an architecture supports the headers installation.
(Actually, "um" is the only architecture that does not have it.)
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/Documentation/kbuild/headers_install.txt b/Documentation/kbuild/headers_install.txt
index 951eb9f..8e668d4 100644
--- a/Documentation/kbuild/headers_install.txt
+++ b/Documentation/kbuild/headers_install.txt
@@ -31,7 +31,7 @@ current architecture. The linux/asm directory of the exported kernel headers
is platform-specific, to see a complete list of supported architectures use
the command:
- ls -d include/asm-* | sed 's/.*-//'
+ for i in arch/*; do [ -e $i/include/uapi/asm/Kbuild ] && basename $i; done
INSTALL_HDR_PATH indicates where to install the headers. It defaults to
"./usr/include".
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kbuild: update headers_install.txt document
2014-12-03 6:45 [PATCH] kbuild: update headers_install.txt document Masahiro Yamada
@ 2014-12-03 14:02 ` Jonathan Corbet
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Corbet @ 2014-12-03 14:02 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-kbuild, Michal Marek, linux-doc, linux-kernel
On Wed, 3 Dec 2014 15:45:41 +0900
Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:
> The arch header directories "include/asm-*" were moved long ago.
> Now we should check the existence of arch/*/include/uapi/asm/Kbuild
> to see if an architecture supports the headers installation.
> (Actually, "um" is the only architecture that does not have it.)
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
So please forgive me if I seem overly difficult and fussy, but... while
I'm all for fancy shell one-liners, wouldn't it be more straightforward,
in this case, to simply say in the documentation that all architectures
other than um have support?
Thanks,
jon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-03 14:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-03 6:45 [PATCH] kbuild: update headers_install.txt document Masahiro Yamada
2014-12-03 14:02 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).