From: Pavel Machek <pavel@ucw.cz>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Michael Witten <mfwitten@gmail.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Cong Wang <xiyou.wangcong@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Sam Ravnborg <sam@ravnborg.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
John Levon <john.levon@joyent.com>,
John Levon <levon@movementarian.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Makefile: Yes. Finally remove '-Wdeclaration-after-statement'
Date: Tue, 18 Aug 2020 00:09:08 +0200 [thread overview]
Message-ID: <20200817220908.GA3701@amd> (raw)
In-Reply-To: <CAHk-=wj04wKCjHz6b6d7N58xoS4AftnwTUBaXsEekQ5RhfWVnw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 995 bytes --]
On Mon 2020-08-17 14:29:37, Linus Torvalds wrote:
> On Mon, Aug 17, 2020 at 2:15 PM Eric W. Biederman <ebiederm@xmission.com> wrote:
> >
> > Does anyone remember why we added this warning? I had always thought
> > it's purpose was to ensure we stayed within our chosen dialect of C.
>
> As far as I'm concerned, that's the primary motivation.
>
> I'm not seeing why we'd suddenly allow the "put variable declarations
> anywhere" when we've been able to keep from doing it until now.
>
> We're still building primarily good old K&R ANSI C, just with
> extensions. Wild variable placement doesn't seem like a useful
> extension.
I certainly hope we are not going back to good old K&R C :-).
Submitter believes "wild variable placement" can help with
#ifdefs.. and that may be actually good tradeoff.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2020-08-17 22:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-16 16:35 [PATCH] Makefile: Yes. Finally remove '-Wdeclaration-after-statement' Michael Witten
2020-08-16 17:53 ` Al Viro
2020-08-17 20:42 ` Pavel Machek
2020-08-17 21:12 ` Eric W. Biederman
2020-08-17 21:29 ` Linus Torvalds
2020-08-17 22:09 ` Pavel Machek [this message]
2020-08-17 22:12 ` Linus Torvalds
2020-08-18 5:17 ` Ingo Molnar
2020-08-18 8:56 ` David Laight
2020-08-16 17:56 ` Joe Perches
2020-08-17 3:37 ` Michael Witten
2020-08-17 4:19 ` Joe Perches
2020-08-17 11:40 ` Michael Witten
2020-08-17 20:38 ` Pavel Machek
2020-08-18 22:05 ` Michael Witten
2020-08-19 21:15 ` Michael Witten
2020-08-20 0:15 ` [RFC v2] kbuild: Introduce "Warnings for maintainers" Michael Witten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817220908.GA3701@amd \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=hannes@cmpxchg.org \
--cc=john.levon@joyent.com \
--cc=levon@movementarian.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mfwitten@gmail.com \
--cc=michal.lkml@markovi.net \
--cc=sam@ravnborg.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).