linux-kbuild.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] xconfig: Display dependency values in debug_info
@ 2012-07-25 22:56 Salar Ali Mumtaz
  2012-07-25 23:18 ` Randy Dunlap
  0 siblings, 1 reply; 14+ messages in thread
From: Salar Ali Mumtaz @ 2012-07-25 22:56 UTC (permalink / raw)
  To: Michal Marek; +Cc: linux-kbuild, linux-kernel, Salar Ali Mumtaz

Displays the current value of each of the dependencies of a menu item.
Before, you needed to do tedious searching to find out the current values
of the dependences. Now they all are included in the debug_info, making
the task easier

Signed-off-by: Salar Ali Mumtaz <salaarali@gmail.com>
---
 scripts/kconfig/qconf.cc |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
index df274fe..abd500f 100644
--- a/scripts/kconfig/qconf.cc
+++ b/scripts/kconfig/qconf.cc
@@ -1073,8 +1073,10 @@ QString ConfigInfoView::debug_info(struct symbol *sym)
 		debug += " (choice)";
 	debug += "<br>";
 	if (sym->rev_dep.expr) {
-		debug += "reverse dep: ";
+		debug += "reverse dep: (";
 		expr_print(sym->rev_dep.expr, expr_print_help, &debug, E_NONE);
+		debug += " )  =";
+		debug += print_filter(sym_get_string_value(sym));
 		debug += "<br>";
 	}
 	for (struct property *prop = sym->prop; prop; prop = prop->next) {
@@ -1108,7 +1110,10 @@ QString ConfigInfoView::debug_info(struct symbol *sym)
 		}
 		if (prop->visible.expr) {
 			debug += "&nbsp;&nbsp;&nbsp;&nbsp;dep: ";
+			debug += " ( ";
 			expr_print(prop->visible.expr, expr_print_help, &debug, E_NONE);
+			debug += " )  =";
+			debug += print_filter(sym_get_string_value(sym));
 			debug += "<br>";
 		}
 	}
@@ -1157,6 +1162,9 @@ void ConfigInfoView::expr_print_help(void *data, struct symbol *sym, const char
 		*text += QString().sprintf("<a href=\"s%p\">", sym);
 		*text += str2;
 		*text += "</a>";
+		*text += "<b>   ";
+		*text += print_filter(sym_get_string_value(sym));
+		*text += "</b>";
 	} else
 		*text += str2;
 }
-- 
1.7.5.4


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [PATCH] xconfig: Display dependency values in debug_info
  2012-07-25 22:56 [PATCH] xconfig: Display dependency values in debug_info Salar Ali Mumtaz
@ 2012-07-25 23:18 ` Randy Dunlap
       [not found]   ` <CA+jpPM=nrbpDJpaka6xAp4dbEOQjJrtwQWtUXwi_gGS9b4yK-A@mail.gmail.com>
  0 siblings, 1 reply; 14+ messages in thread
From: Randy Dunlap @ 2012-07-25 23:18 UTC (permalink / raw)
  To: Salar Ali Mumtaz; +Cc: Michal Marek, linux-kbuild, linux-kernel

On 07/25/2012 03:56 PM, Salar Ali Mumtaz wrote:

> Displays the current value of each of the dependencies of a menu item.
> Before, you needed to do tedious searching to find out the current values
> of the dependences. Now they all are included in the debug_info, making
> the task easier

Hi,
Would you please provide before and after examples?

I use xconfig quite a lot and it already shows me, e.g., for
CONFIG_DRM:


Symbol: DRM [=y]
Type : tristate
Prompt: Direct Rendering Manager (XFree86 4.1.0 and higher DRI support)
Defined at drivers/gpu/drm/Kconfig:7
Depends on: HAS_IOMEM [=y] && (AGP [=y] || AGP [=y]=n) && !EMULATED_CMPXCHG && MMU [=y]
Location:
-> Device Drivers
-> Graphics support
Selects: I2C [=y] && I2C_ALGOBIT [=y] && DMA_SHARED_BUFFER [=y]




so what and where does this patch add debug info?

Thanks.


> Signed-off-by: Salar Ali Mumtaz <salaarali@gmail.com>
> ---
>  scripts/kconfig/qconf.cc |   10 +++++++++-
>  1 files changed, 9 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
> index df274fe..abd500f 100644
> --- a/scripts/kconfig/qconf.cc
> +++ b/scripts/kconfig/qconf.cc
> @@ -1073,8 +1073,10 @@ QString ConfigInfoView::debug_info(struct symbol *sym)
>  		debug += " (choice)";
>  	debug += "<br>";
>  	if (sym->rev_dep.expr) {
> -		debug += "reverse dep: ";
> +		debug += "reverse dep: (";
>  		expr_print(sym->rev_dep.expr, expr_print_help, &debug, E_NONE);
> +		debug += " )  =";
> +		debug += print_filter(sym_get_string_value(sym));
>  		debug += "<br>";
>  	}
>  	for (struct property *prop = sym->prop; prop; prop = prop->next) {
> @@ -1108,7 +1110,10 @@ QString ConfigInfoView::debug_info(struct symbol *sym)
>  		}
>  		if (prop->visible.expr) {
>  			debug += "&nbsp;&nbsp;&nbsp;&nbsp;dep: ";
> +			debug += " ( ";
>  			expr_print(prop->visible.expr, expr_print_help, &debug, E_NONE);
> +			debug += " )  =";
> +			debug += print_filter(sym_get_string_value(sym));
>  			debug += "<br>";
>  		}
>  	}
> @@ -1157,6 +1162,9 @@ void ConfigInfoView::expr_print_help(void *data, struct symbol *sym, const char
>  		*text += QString().sprintf("<a href=\"s%p\">", sym);
>  		*text += str2;
>  		*text += "</a>";
> +		*text += "<b>   ";
> +		*text += print_filter(sym_get_string_value(sym));
> +		*text += "</b>";
>  	} else
>  		*text += str2;
>  }



-- 
~Randy

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] xconfig: Display dependency values in debug_info
       [not found]   ` <CA+jpPM=nrbpDJpaka6xAp4dbEOQjJrtwQWtUXwi_gGS9b4yK-A@mail.gmail.com>
@ 2012-07-26 17:02     ` Randy Dunlap
  2012-07-31 16:51       ` Salar Ali Mumtaz
                         ` (2 more replies)
  0 siblings, 3 replies; 14+ messages in thread
From: Randy Dunlap @ 2012-07-26 17:02 UTC (permalink / raw)
  To: Salar Ali Mumtaz; +Cc: Michal Marek, linux-kbuild, linux-kernel

On 07/26/2012 09:19 AM, Salar Ali Mumtaz wrote:

> Hi.
> 
> Thanks for the quick reply.
> 
> This adds the current values to the dependencies in the debug_info, which you get when you select "Show debug info" 
> from the popup you get after you right click. For some values, there is no help available. For those, there is usually 
> information in the debug_info that is not displayed normally.
> 
> COMPAT_BINFMT_ELF
> 
> //This is added by debug_info
> type: boolean
> reverse dep: (IA32_EMULATION n && X86_64 n ) =n
> unknown property: symbol
>     dep: ( COMPAT n && BINFMT_ELF y ) =n
> //This is added by debug_info
> 
> defined at fs/Kconfig.binfmt:26
> 
> There is no help available for this option.
> Symbol: COMPAT_BINFMT_ELF [=n]
> Type : boolean
> Selected by: IA32_EMULATION [=n] && X86_64 [=n]
> 
> Hope this helps.
> 


Yes, it does help.  Thanks.


For BINFMT_ELF (not your example of COMPAT_BINFMT_ELF)
in Linux 3.5, I see this:


BEFORE PATCH:

type: boolean
unknown property: symbol
    dep: MMU && (BROKEN || !FRV)
prompt: Kernel support for ELF binaries
    dep: MMU && (BROKEN || !FRV)
default: y
    dep: MMU && (BROKEN || !FRV)

defined at fs/Kconfig.binfmt:1



AFTER PATCH:

type: boolean
unknown property: symbol
    dep: ( MMU y && (BROKEN n || !FRV FRV) ) =y
prompt: Kernel support for ELF binaries
    dep: ( MMU y && (BROKEN n || !FRV FRV) ) =y
default: y
    dep: ( MMU y && (BROKEN n || !FRV FRV) ) =y

defined at fs/Kconfig.binfmt:1




The added y/n/m are clear, but the "!FRV FRV" is confusing,
isn't it?


-- 
~Randy

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] xconfig: Display dependency values in debug_info
  2012-07-26 17:02     ` Randy Dunlap
@ 2012-07-31 16:51       ` Salar Ali Mumtaz
  2012-07-31 18:58       ` [PATCH v2] " Salar Ali Mumtaz
  2012-08-07 16:08       ` [PATCH] " Salar Ali Mumtaz
  2 siblings, 0 replies; 14+ messages in thread
From: Salar Ali Mumtaz @ 2012-07-31 16:51 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: Michal Marek, linux-kbuild, linux-kernel

On 12-07-26 01:02 PM, Randy Dunlap wrote:

> 
> The added y/n/m are clear, but the "!FRV FRV" is confusing,
> isn't it?
> 
> 

Yes. But that is easily fixable.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH v2] xconfig: Display dependency values in debug_info
  2012-07-26 17:02     ` Randy Dunlap
  2012-07-31 16:51       ` Salar Ali Mumtaz
@ 2012-07-31 18:58       ` Salar Ali Mumtaz
  2012-07-31 20:21         ` Randy Dunlap
  2012-08-07 16:08       ` [PATCH] " Salar Ali Mumtaz
  2 siblings, 1 reply; 14+ messages in thread
From: Salar Ali Mumtaz @ 2012-07-31 18:58 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: Michal Marek, linux-kbuild, linux-kernel

Now the debug_info only shows y/n/m values.

Signed-off-by: Salar Ali Mumtaz <salaarali@gmail.com>
---
 scripts/kconfig/qconf.cc |   14 +++++++++++++-
 1 files changed, 13 insertions(+), 1 deletions(-)

diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
index df274fe..b6a7cc5 100644
--- a/scripts/kconfig/qconf.cc
+++ b/scripts/kconfig/qconf.cc
@@ -1073,8 +1073,10 @@ QString ConfigInfoView::debug_info(struct symbol *sym)
 		debug += " (choice)";
 	debug += "<br>";
 	if (sym->rev_dep.expr) {
-		debug += "reverse dep: ";
+		debug += "reverse dep: (";
 		expr_print(sym->rev_dep.expr, expr_print_help, &debug, E_NONE);
+		debug += " )  =";
+		debug += print_filter(sym_get_string_value(sym));
 		debug += "<br>";
 	}
 	for (struct property *prop = sym->prop; prop; prop = prop->next) {
@@ -1108,7 +1110,10 @@ QString ConfigInfoView::debug_info(struct symbol *sym)
 		}
 		if (prop->visible.expr) {
 			debug += "&nbsp;&nbsp;&nbsp;&nbsp;dep: ";
+			debug += " ( ";
 			expr_print(prop->visible.expr, expr_print_help, &debug, E_NONE);
+			debug += " )  =";
+			debug += print_filter(sym_get_string_value(sym));
 			debug += "<br>";
 		}
 	}
@@ -1152,11 +1157,18 @@ void ConfigInfoView::expr_print_help(void *data, struct symbol *sym, const char
 {
 	QString* text = reinterpret_cast<QString*>(data);
 	QString str2 = print_filter(str);
+	QString value;
 
 	if (sym && sym->name && !(sym->flags & SYMBOL_CONST)) {
+		value = print_filter(sym_get_string_value(sym));
+
 		*text += QString().sprintf("<a href=\"s%p\">", sym);
 		*text += str2;
 		*text += "</a>";
+		*text += "<b>   ";
+		if(value == "y" || value == "m" || value == "n")
+			*text += print_filter(sym_get_string_value(sym));
+		*text += "</b>";
 	} else
 		*text += str2;
 }
-- 
1.7.5.4

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [PATCH v2] xconfig: Display dependency values in debug_info
  2012-07-31 18:58       ` [PATCH v2] " Salar Ali Mumtaz
@ 2012-07-31 20:21         ` Randy Dunlap
  2012-08-02  4:20           ` Salar Ali Mumtaz
  0 siblings, 1 reply; 14+ messages in thread
From: Randy Dunlap @ 2012-07-31 20:21 UTC (permalink / raw)
  To: Salar Ali Mumtaz; +Cc: Michal Marek, linux-kbuild, linux-kernel

On 07/31/2012 11:58 AM, Salar Ali Mumtaz wrote:

> Now the debug_info only shows y/n/m values.
> 


or no value at all??

for CONFIG_BINFMT_ELF:



Kernel support for ELF binaries (BINFMT_ELF)

type: boolean
unknown property: symbol
    dep: ( MMU y && (BROKEN n || !FRV ) ) =y
prompt: Kernel support for ELF binaries
    dep: ( MMU y && (BROKEN n || !FRV ) ) =y
default: y
    dep: ( MMU y && (BROKEN n || !FRV ) ) =y

defined at fs/Kconfig.binfmt:1

CONFIG_BINFMT_ELF:





> Signed-off-by: Salar Ali Mumtaz <salaarali@gmail.com>
> ---
>  scripts/kconfig/qconf.cc |   14 +++++++++++++-
>  1 files changed, 13 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
> index df274fe..b6a7cc5 100644
> --- a/scripts/kconfig/qconf.cc
> +++ b/scripts/kconfig/qconf.cc
> @@ -1073,8 +1073,10 @@ QString ConfigInfoView::debug_info(struct symbol *sym)
>  		debug += " (choice)";
>  	debug += "<br>";
>  	if (sym->rev_dep.expr) {
> -		debug += "reverse dep: ";
> +		debug += "reverse dep: (";
>  		expr_print(sym->rev_dep.expr, expr_print_help, &debug, E_NONE);
> +		debug += " )  =";
> +		debug += print_filter(sym_get_string_value(sym));
>  		debug += "<br>";
>  	}
>  	for (struct property *prop = sym->prop; prop; prop = prop->next) {
> @@ -1108,7 +1110,10 @@ QString ConfigInfoView::debug_info(struct symbol *sym)
>  		}
>  		if (prop->visible.expr) {
>  			debug += "&nbsp;&nbsp;&nbsp;&nbsp;dep: ";
> +			debug += " ( ";
>  			expr_print(prop->visible.expr, expr_print_help, &debug, E_NONE);
> +			debug += " )  =";
> +			debug += print_filter(sym_get_string_value(sym));
>  			debug += "<br>";
>  		}
>  	}
> @@ -1152,11 +1157,18 @@ void ConfigInfoView::expr_print_help(void *data, struct symbol *sym, const char
>  {
>  	QString* text = reinterpret_cast<QString*>(data);
>  	QString str2 = print_filter(str);
> +	QString value;
>  
>  	if (sym && sym->name && !(sym->flags & SYMBOL_CONST)) {
> +		value = print_filter(sym_get_string_value(sym));
> +
>  		*text += QString().sprintf("<a href=\"s%p\">", sym);
>  		*text += str2;
>  		*text += "</a>";
> +		*text += "<b>   ";
> +		if(value == "y" || value == "m" || value == "n")
> +			*text += print_filter(sym_get_string_value(sym));
> +		*text += "</b>";
>  	} else
>  		*text += str2;
>  }



thanks,
-- 
~Randy

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v2] xconfig: Display dependency values in debug_info
  2012-07-31 20:21         ` Randy Dunlap
@ 2012-08-02  4:20           ` Salar Ali Mumtaz
  2012-08-02  4:47             ` Randy Dunlap
  0 siblings, 1 reply; 14+ messages in thread
From: Salar Ali Mumtaz @ 2012-08-02  4:20 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: Michal Marek, linux-kbuild, linux-kernel

On 12-07-31 04:21 PM, Randy Dunlap wrote:
> On 07/31/2012 11:58 AM, Salar Ali Mumtaz wrote:
> 
>> Now the debug_info only shows y/n/m values.
>>
> 
> 
> or no value at all??


Yes.

y/n/m or no value at all.


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v2] xconfig: Display dependency values in debug_info
  2012-08-02  4:20           ` Salar Ali Mumtaz
@ 2012-08-02  4:47             ` Randy Dunlap
  0 siblings, 0 replies; 14+ messages in thread
From: Randy Dunlap @ 2012-08-02  4:47 UTC (permalink / raw)
  To: Salar Ali Mumtaz; +Cc: Michal Marek, linux-kbuild, linux-kernel

On 08/01/2012 09:20 PM, Salar Ali Mumtaz wrote:

> On 12-07-31 04:21 PM, Randy Dunlap wrote:
>> On 07/31/2012 11:58 AM, Salar Ali Mumtaz wrote:
>>
>>> Now the debug_info only shows y/n/m values.
>>>
>>
>>
>> or no value at all??
> 
> 
> Yes.
> 
> y/n/m or no value at all.
> 


so in:

Kernel support for ELF binaries (BINFMT_ELF)

type: boolean
unknown property: symbol
    dep: ( MMU y && (BROKEN n || !FRV ) ) =y
prompt: Kernel support for ELF binaries
    dep: ( MMU y && (BROKEN n || !FRV ) ) =y
default: y
    dep: ( MMU y && (BROKEN n || !FRV ) ) =y



does that mean that FRV is n, so !FRV is y ??
It's still confusing.


-- 
~Randy

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] xconfig: Display dependency values in debug_info
  2012-07-26 17:02     ` Randy Dunlap
  2012-07-31 16:51       ` Salar Ali Mumtaz
  2012-07-31 18:58       ` [PATCH v2] " Salar Ali Mumtaz
@ 2012-08-07 16:08       ` Salar Ali Mumtaz
  2012-08-07 16:55         ` Randy Dunlap
  2 siblings, 1 reply; 14+ messages in thread
From: Salar Ali Mumtaz @ 2012-08-07 16:08 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: Michal Marek, linux-kbuild, linux-kernel

On 12-07-26 01:02 PM, Randy Dunlap wrote:

> The added y/n/m are clear, but the "!FRV FRV" is confusing,
> isn't it?
> 
> 

Is this notation clear ?

Kernel support for ELF binaries (BINFMT_ELF)

type: boolean
unknown property: symbol
    dep: ( MMU [=y] && (BROKEN [n] || !FRV [= ""]) ) [=y]
prompt: Kernel support for ELF binaries
    dep: ( MMU [=y] && (BROKEN [n] || !FRV [= ""]) ) [=y]
default: y
    dep: ( MMU [=y] && (BROKEN [n] || !FRV [= ""]) ) [=y]


If not, could you suggest a better way to represent this information?

Thanks.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] xconfig: Display dependency values in debug_info
  2012-08-07 16:08       ` [PATCH] " Salar Ali Mumtaz
@ 2012-08-07 16:55         ` Randy Dunlap
  2012-08-09 18:54           ` Salar Ali Mumtaz
  0 siblings, 1 reply; 14+ messages in thread
From: Randy Dunlap @ 2012-08-07 16:55 UTC (permalink / raw)
  To: Salar Ali Mumtaz; +Cc: Michal Marek, linux-kbuild, linux-kernel

On 08/07/2012 09:08 AM, Salar Ali Mumtaz wrote:

> On 12-07-26 01:02 PM, Randy Dunlap wrote:
> 
>> The added y/n/m are clear, but the "!FRV FRV" is confusing,
>> isn't it?
>>
>>
> 
> Is this notation clear ?
> 
> Kernel support for ELF binaries (BINFMT_ELF)
> 
> type: boolean
> unknown property: symbol
>     dep: ( MMU [=y] && (BROKEN [n] || !FRV [= ""]) ) [=y]
> prompt: Kernel support for ELF binaries
>     dep: ( MMU [=y] && (BROKEN [n] || !FRV [= ""]) ) [=y]
> default: y
>     dep: ( MMU [=y] && (BROKEN [n] || !FRV [= ""]) ) [=y]



In Kconfig language, is "" the same as 'n' ?
If so, I'm OK with your proposal above.


> If not, could you suggest a better way to represent this information?
> 
> Thanks.



thanks,
-- 
~Randy

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] xconfig: Display dependency values in debug_info
  2012-08-07 16:55         ` Randy Dunlap
@ 2012-08-09 18:54           ` Salar Ali Mumtaz
  2012-08-11  0:39             ` Randy Dunlap
  0 siblings, 1 reply; 14+ messages in thread
From: Salar Ali Mumtaz @ 2012-08-09 18:54 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: Michal Marek, linux-kbuild, linux-kernel

On 12-08-07 12:55 PM, Randy Dunlap wrote:

> In Kconfig language, is "" the same as 'n' ?
> If so, I'm OK with your proposal above.
> 


So a colleague of mine tested this and came up with a conclusion that expressions in Kconfig can only deal with boolean or tristate operands and no casting is made with strings. Using any string operand as part of a boolean expression is simply a type error and Kconfig probably marks such operand as 'n', regardless of its value.


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] xconfig: Display dependency values in debug_info
  2012-08-09 18:54           ` Salar Ali Mumtaz
@ 2012-08-11  0:39             ` Randy Dunlap
  2012-08-15 16:32               ` Salar Ali Mumtaz
  0 siblings, 1 reply; 14+ messages in thread
From: Randy Dunlap @ 2012-08-11  0:39 UTC (permalink / raw)
  To: Salar Ali Mumtaz; +Cc: Michal Marek, linux-kbuild, linux-kernel

On 08/09/2012 11:54 AM, Salar Ali Mumtaz wrote:

> On 12-08-07 12:55 PM, Randy Dunlap wrote:
> 
>> In Kconfig language, is "" the same as 'n' ?
>> If so, I'm OK with your proposal above.
>>
> 
> 
> So a colleague of mine tested this and came up with a conclusion that expressions in Kconfig can only deal with boolean or tristate operands and no casting is made with strings. Using any string operand as part of a boolean expression is simply a type error and Kconfig probably marks such operand as 'n', regardless of its value.
> 


My question was about FRV, which is a boolean,
but still did not display as 'n' in your example.


-- 
~Randy

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] xconfig: Display dependency values in debug_info
  2012-08-11  0:39             ` Randy Dunlap
@ 2012-08-15 16:32               ` Salar Ali Mumtaz
  2012-08-15 17:29                 ` Randy Dunlap
  0 siblings, 1 reply; 14+ messages in thread
From: Salar Ali Mumtaz @ 2012-08-15 16:32 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: Michal Marek, linux-kbuild, linux-kernel

On 12-08-10 08:39 PM, Randy Dunlap wrote:
> On 08/09/2012 11:54 AM, Salar Ali Mumtaz wrote:
> 
>> On 12-08-07 12:55 PM, Randy Dunlap wrote:
>>
>>> In Kconfig language, is "" the same as 'n' ?
>>> If so, I'm OK with your proposal above.
>>>
>>
>>
>> So a colleague of mine tested this and came up with a conclusion that expressions in Kconfig can only deal with boolean or tristate operands and no casting is made with strings. Using any string operand as part of a boolean expression is simply a type error and Kconfig probably marks such operand as 'n', regardless of its value.
>>
> 
> 
> My question was about FRV, which is a boolean,
> but still did not display as 'n' in your example.
> 
> 

FRV is not a boolean.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] xconfig: Display dependency values in debug_info
  2012-08-15 16:32               ` Salar Ali Mumtaz
@ 2012-08-15 17:29                 ` Randy Dunlap
  0 siblings, 0 replies; 14+ messages in thread
From: Randy Dunlap @ 2012-08-15 17:29 UTC (permalink / raw)
  To: Salar Ali Mumtaz; +Cc: Michal Marek, linux-kbuild, linux-kernel

On 08/15/2012 09:32 AM, Salar Ali Mumtaz wrote:

> On 12-08-10 08:39 PM, Randy Dunlap wrote:
>> On 08/09/2012 11:54 AM, Salar Ali Mumtaz wrote:
>>
>>> On 12-08-07 12:55 PM, Randy Dunlap wrote:
>>>
>>>> In Kconfig language, is "" the same as 'n' ?
>>>> If so, I'm OK with your proposal above.
>>>>
>>>
>>>
>>> So a colleague of mine tested this and came up with a conclusion that expressions in Kconfig can only deal with boolean or tristate operands and no casting is made with strings. Using any string operand as part of a boolean expression is simply a type error and Kconfig probably marks such operand as 'n', regardless of its value.
>>>
>>
>>
>> My question was about FRV, which is a boolean,
>> but still did not display as 'n' in your example.
>>
>>
> 
> FRV is not a boolean.



Hm, why do you say that?  Please explain.


from arch/frv/Kconfig:

config FRV
	bool
	default y



-- 
~Randy

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2012-08-15 17:30 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-25 22:56 [PATCH] xconfig: Display dependency values in debug_info Salar Ali Mumtaz
2012-07-25 23:18 ` Randy Dunlap
     [not found]   ` <CA+jpPM=nrbpDJpaka6xAp4dbEOQjJrtwQWtUXwi_gGS9b4yK-A@mail.gmail.com>
2012-07-26 17:02     ` Randy Dunlap
2012-07-31 16:51       ` Salar Ali Mumtaz
2012-07-31 18:58       ` [PATCH v2] " Salar Ali Mumtaz
2012-07-31 20:21         ` Randy Dunlap
2012-08-02  4:20           ` Salar Ali Mumtaz
2012-08-02  4:47             ` Randy Dunlap
2012-08-07 16:08       ` [PATCH] " Salar Ali Mumtaz
2012-08-07 16:55         ` Randy Dunlap
2012-08-09 18:54           ` Salar Ali Mumtaz
2012-08-11  0:39             ` Randy Dunlap
2012-08-15 16:32               ` Salar Ali Mumtaz
2012-08-15 17:29                 ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).