* [PATCH] fixdep: trivial: typo fix and correction
@ 2017-08-08 13:20 Cao jin
2017-08-09 16:05 ` Masahiro Yamada
0 siblings, 1 reply; 5+ messages in thread
From: Cao jin @ 2017-08-08 13:20 UTC (permalink / raw)
To: linux-kernel, linux-kbuild; +Cc: yamada.masahiro, mmarek
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
scripts/basic/fixdep.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c
index fff818b..bbf62cb 100644
--- a/scripts/basic/fixdep.c
+++ b/scripts/basic/fixdep.c
@@ -25,7 +25,7 @@
*
* So we play the same trick that "mkdep" played before. We replace
* the dependency on autoconf.h by a dependency on every config
- * option which is mentioned in any of the listed prequisites.
+ * option which is mentioned in any of the listed prerequisites.
*
* kconfig populates a tree in include/config/ with an empty file
* for each config symbol and when the configuration is updated
@@ -34,7 +34,7 @@
* the config symbols are rebuilt.
*
* So if the user changes his CONFIG_HIS_DRIVER option, only the objects
- * which depend on "include/linux/config/his/driver.h" will be rebuilt,
+ * which depend on "include/config/his/driver.h" will be rebuilt,
* so most likely only his driver ;-)
*
* The idea above dates, by the way, back to Michael E Chastain, AFAIK.
@@ -75,7 +75,7 @@
* and then basically copies the .<target>.d file to stdout, in the
* process filtering out the dependency on autoconf.h and adding
* dependencies on include/config/my/option.h for every
- * CONFIG_MY_OPTION encountered in any of the prequisites.
+ * CONFIG_MY_OPTION encountered in any of the prerequisites.
*
* It will also filter out all the dependencies on *.ver. We need
* to make sure that the generated version checksum are globally up
--
2.1.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] fixdep: trivial: typo fix and correction
2017-08-08 13:20 [PATCH] fixdep: trivial: typo fix and correction Cao jin
@ 2017-08-09 16:05 ` Masahiro Yamada
2017-08-10 13:50 ` Cao jin
0 siblings, 1 reply; 5+ messages in thread
From: Masahiro Yamada @ 2017-08-09 16:05 UTC (permalink / raw)
To: Cao jin
Cc: Linux Kernel Mailing List, Linux Kbuild mailing list, Michal Marek
2017-08-08 22:20 GMT+09:00 Cao jin <caoj.fnst@cn.fujitsu.com>:
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
Applied to linux-kbuild/fixes. Thanks!
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fixdep: trivial: typo fix and correction
2017-08-09 16:05 ` Masahiro Yamada
@ 2017-08-10 13:50 ` Cao jin
2017-08-11 23:31 ` Masahiro Yamada
0 siblings, 1 reply; 5+ messages in thread
From: Cao jin @ 2017-08-10 13:50 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Linux Kernel Mailing List, Linux Kbuild mailing list, Michal Marek
Hi Masahiro-san
On 08/10/2017 12:05 AM, Masahiro Yamada wrote:
> 2017-08-08 22:20 GMT+09:00 Cao jin <caoj.fnst@cn.fujitsu.com>:
>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>
> Applied to linux-kbuild/fixes. Thanks!
>
I want to ask a question via this thread.
I am tracing how each kernel source file compiled, and I met mounts-y in
init/Makefile, I have trouble in finding the rule which compile
$(mounts-y), but I clearly see the files in $(mounts-y) are compiled in
the output of `make -n vmlinux`, but the files listed in mounts-y are
not listed in obj-y. I think I must miss something, could you give some
hint?
--
Sincerely,
Cao jin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fixdep: trivial: typo fix and correction
2017-08-10 13:50 ` Cao jin
@ 2017-08-11 23:31 ` Masahiro Yamada
2017-08-12 10:49 ` Cao jin
0 siblings, 1 reply; 5+ messages in thread
From: Masahiro Yamada @ 2017-08-11 23:31 UTC (permalink / raw)
To: Cao jin
Cc: Linux Kernel Mailing List, Linux Kbuild mailing list, Michal Marek
Hi.
2017-08-10 22:50 GMT+09:00 Cao jin <caoj.fnst@cn.fujitsu.com>:
> Hi Masahiro-san
>
> On 08/10/2017 12:05 AM, Masahiro Yamada wrote:
>> 2017-08-08 22:20 GMT+09:00 Cao jin <caoj.fnst@cn.fujitsu.com>:
>>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>>
>> Applied to linux-kbuild/fixes. Thanks!
>>
>
> I want to ask a question via this thread.
>
> I am tracing how each kernel source file compiled, and I met mounts-y in
> init/Makefile, I have trouble in finding the rule which compile
> $(mounts-y), but I clearly see the files in $(mounts-y) are compiled in
> the output of `make -n vmlinux`, but the files listed in mounts-y are
> not listed in obj-y. I think I must miss something, could you give some
> hint?
>
The magic is the following line:
scripts/Makefile.lib line 55
# if $(foo-objs) exists, foo.o is a composite object
multi-used-y := $(sort $(foreach m,$(obj-y), $(if $(strip
$($(m:.o=-objs)) $($(m:.o=-y))), $(m))))
If foo.o is added to obj-y and foo-objs or foo-y exist,
they are also expanded.
If you see init/Makefile, mounts.o is added to obj-y.
obj-y := main.o version.o mounts.o
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fixdep: trivial: typo fix and correction
2017-08-11 23:31 ` Masahiro Yamada
@ 2017-08-12 10:49 ` Cao jin
0 siblings, 0 replies; 5+ messages in thread
From: Cao jin @ 2017-08-12 10:49 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Linux Kernel Mailing List, Linux Kbuild mailing list, Michal Marek
On 08/12/2017 07:31 AM, Masahiro Yamada wrote:
> Hi.
>
> 2017-08-10 22:50 GMT+09:00 Cao jin <caoj.fnst@cn.fujitsu.com>:
>> Hi Masahiro-san
>>
>> On 08/10/2017 12:05 AM, Masahiro Yamada wrote:
>>> 2017-08-08 22:20 GMT+09:00 Cao jin <caoj.fnst@cn.fujitsu.com>:
>>>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>>>
>>> Applied to linux-kbuild/fixes. Thanks!
>>>
>>
>> I want to ask a question via this thread.
>>
>> I am tracing how each kernel source file compiled, and I met mounts-y in
>> init/Makefile, I have trouble in finding the rule which compile
>> $(mounts-y), but I clearly see the files in $(mounts-y) are compiled in
>> the output of `make -n vmlinux`, but the files listed in mounts-y are
>> not listed in obj-y. I think I must miss something, could you give some
>> hint?
>>
>
>
> The magic is the following line:
>
> scripts/Makefile.lib line 55
>
> # if $(foo-objs) exists, foo.o is a composite object
> multi-used-y := $(sort $(foreach m,$(obj-y), $(if $(strip
> $($(m:.o=-objs)) $($(m:.o=-y))), $(m))))
>
>
> If foo.o is added to obj-y and foo-objs or foo-y exist,
> they are also expanded.
>
>
>
>
>
> If you see init/Makefile, mounts.o is added to obj-y.
>
> obj-y := main.o version.o mounts.o
>
>
Finally figured out how $(mounts-y) is compiled and how init/mounts.o is
linked, it is a bit complex than I expected, your hint really helps:)
Thanks you very much, Masahiro-san.
--
Sincerely,
Cao jin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-08-12 10:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-08 13:20 [PATCH] fixdep: trivial: typo fix and correction Cao jin
2017-08-09 16:05 ` Masahiro Yamada
2017-08-10 13:50 ` Cao jin
2017-08-11 23:31 ` Masahiro Yamada
2017-08-12 10:49 ` Cao jin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).