[PATCH] hexagon: get rid of #include <generated/compile.h>

[PATCH] hexagon: get rid of #include <generated/compile.h>

[Masahiro Yamada]

<generated/compile.h> is created (or updated) when Kbuild descends
into the init/ directory.  In parallel building from a pristine
source tree, there is no guarantee <generated/compile.h> exists when
arch/hexagon/kernel/ptrace.c is compiled.

For hexagon architecture, we know UTS_MACHINE is a fixed string
"hexagon", so let's hard-code it, like many architectures do.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 arch/hexagon/kernel/ptrace.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/hexagon/kernel/ptrace.c b/arch/hexagon/kernel/ptrace.c
index ecd75e2..fa76493 100644
--- a/arch/hexagon/kernel/ptrace.c
+++ b/arch/hexagon/kernel/ptrace.c
@@ -18,8 +18,6 @@
  * 02110-1301, USA.
  */
 
-#include <generated/compile.h>
-
 #include <linux/kernel.h>
 #include <linux/sched.h>
 #include <linux/sched/task_stack.h>
@@ -180,7 +178,7 @@ static const struct user_regset hexagon_regsets[] = {
 };
 
 static const struct user_regset_view hexagon_user_view = {
-	.name = UTS_MACHINE,
+	.name = "hexagon",
 	.e_machine = ELF_ARCH,
 	.ei_osabi = ELF_OSABI,
 	.regsets = hexagon_regsets,
-- 
2.7.4

Re: [PATCH] hexagon: get rid of #include <generated/compile.h>

[Richard Kuo]

On Thu, Sep 21, 2017 at 12:17:50AM +0900, Masahiro Yamada wrote:
> <generated/compile.h> is created (or updated) when Kbuild descends
> into the init/ directory.  In parallel building from a pristine
> source tree, there is no guarantee <generated/compile.h> exists when
> arch/hexagon/kernel/ptrace.c is compiled.
> 
> For hexagon architecture, we know UTS_MACHINE is a fixed string
> "hexagon", so let's hard-code it, like many architectures do.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>  arch/hexagon/kernel/ptrace.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 

Acked-by: Richard Kuo <rkuo@codeaurora.org>


-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, 
a Linux Foundation Collaborative Project

Re: [PATCH] hexagon: get rid of #include <generated/compile.h>

[Masahiro Yamada]

Hi Richard,

2017-09-28 8:24 GMT+09:00 Richard Kuo <rkuo@codeaurora.org>:
> On Thu, Sep 21, 2017 at 12:17:50AM +0900, Masahiro Yamada wrote:
>> <generated/compile.h> is created (or updated) when Kbuild descends
>> into the init/ directory.  In parallel building from a pristine
>> source tree, there is no guarantee <generated/compile.h> exists when
>> arch/hexagon/kernel/ptrace.c is compiled.
>>
>> For hexagon architecture, we know UTS_MACHINE is a fixed string
>> "hexagon", so let's hard-code it, like many architectures do.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>>  arch/hexagon/kernel/ptrace.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>
> Acked-by: Richard Kuo <rkuo@codeaurora.org>
>

How should this patch be handled?




-- 
Best Regards
Masahiro Yamada

Re: [PATCH] hexagon: get rid of #include <generated/compile.h>

[Masahiro Yamada]

2017-10-03 10:26 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> Hi Richard,
>
> 2017-09-28 8:24 GMT+09:00 Richard Kuo <rkuo@codeaurora.org>:
>> On Thu, Sep 21, 2017 at 12:17:50AM +0900, Masahiro Yamada wrote:
>>> <generated/compile.h> is created (or updated) when Kbuild descends
>>> into the init/ directory.  In parallel building from a pristine
>>> source tree, there is no guarantee <generated/compile.h> exists when
>>> arch/hexagon/kernel/ptrace.c is compiled.
>>>
>>> For hexagon architecture, we know UTS_MACHINE is a fixed string
>>> "hexagon", so let's hard-code it, like many architectures do.
>>>
>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>> ---
>>>
>>>  arch/hexagon/kernel/ptrace.c | 4 +---
>>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>>
>>
>> Acked-by: Richard Kuo <rkuo@codeaurora.org>
>>
>
> How should this patch be handled?
>

I checked
git://git.kernel.org/pub/scm/linux/kernel/git/rkuo/linux-hexagon-kernel.git

I could not see any patch applied to the tree since last year.

Assuming the tree is unmaintained, I am picking this patch to Kbuild tree.



Applied to linux-kbuild/kbuild with Rechard's Acked.



-- 
Best Regards
Masahiro Yamada

Re: [PATCH] hexagon: get rid of #include <generated/compile.h>

[Richard Kuo]

On Mon, Oct 09, 2017 at 11:25:28PM +0900, Masahiro Yamada wrote:
> >>
> >
> > How should this patch be handled?
> >
> 
> I checked
> git://git.kernel.org/pub/scm/linux/kernel/git/rkuo/linux-hexagon-kernel.git
> 
> I could not see any patch applied to the tree since last year.
> 
> Assuming the tree is unmaintained, I am picking this patch to Kbuild tree.
> 
> 
> 
> Applied to linux-kbuild/kbuild with Rechard's Acked.
> 
> 
> 
> -- 
> Best Regards
> Masahiro Yamada


Sorry about that.  For the record I'm fine with these patches going up
some of the other trees, like trivial or kbuild.  Might go faster that way.


Thanks,
Richard Kuo




-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, 
a Linux Foundation Collaborative Project